diff --git a/radio/src/gui/menu_model.cpp b/radio/src/gui/menu_model.cpp index 61cba0a89..1c0a63b91 100644 --- a/radio/src/gui/menu_model.cpp +++ b/radio/src/gui/menu_model.cpp @@ -2737,9 +2737,8 @@ void insertExpoMix(uint8_t expo, uint8_t idx) #if defined(PCBTARANIS) expo->srcRaw = (s_currCh > 4 ? MIXSRC_Rud - 1 + s_currCh : MIXSRC_Rud - 1 + channel_order(s_currCh)); expo->curve.type = CURVE_REF_EXPO; -#else - expo->mode = 3; // pos&neg #endif + expo->mode = 3; // pos&neg expo->chn = s_currCh - 1; expo->weight = 100; } @@ -2880,7 +2879,7 @@ enum ExposFields { IF_CURVES(EXPO_FIELD_CURVE) IF_FLIGHT_MODES(EXPO_FIELD_FLIGHT_PHASE) EXPO_FIELD_SWITCH, - CASE_9X(EXPO_FIELD_SIDE) + EXPO_FIELD_SIDE, CASE_PCBTARANIS(EXPO_FIELD_TRIM) EXPO_FIELD_MAX }; @@ -3014,11 +3013,9 @@ void menuModelExpoOne(uint8_t event) ed->swtch = switchMenuItem(EXPO_ONE_2ND_COLUMN-IF_9X(3*FW), y, ed->swtch, attr, event); break; -#if !defined(PCBTARANIS) case EXPO_FIELD_SIDE: - ed->mode = 4 - selectMenuItem(EXPO_ONE_2ND_COLUMN-3*FW, y, STR_SIDE, STR_VSIDE, 4-ed->mode, 1, 3, attr, event); + ed->mode = 4 - selectMenuItem(EXPO_ONE_2ND_COLUMN-IF_9X(3*FW), y, STR_SIDE, STR_VSIDE, 4-ed->mode, 1, 3, attr, event); break; -#endif #if defined(PCBTARANIS) case EXPO_FIELD_TRIM: @@ -3286,8 +3283,9 @@ static uint8_t s_copySrcCh; #define EXPO_LINE_SRC_POS 9*FW-2 #define EXPO_LINE_CURVE_POS 12*FW+4 #define EXPO_LINE_SWITCH_POS 17*FW-1 + #define EXPO_LINE_SIDE_POS 20*FW-1 #define EXPO_LINE_SELECT_POS 5*FW+2 - #define EXPO_LINE_FM_POS LCD_W-LEN_EXPOMIX_NAME*FW-MENUS_SCROLLBAR_WIDTH-FW-1 + #define EXPO_LINE_FM_POS LCD_W-LEN_EXPOMIX_NAME*FW-MENUS_SCROLLBAR_WIDTH-FW #define EXPO_LINE_NAME_POS LCD_W-LEN_EXPOMIX_NAME*FW-MENUS_SCROLLBAR_WIDTH #define MIX_LINE_WEIGHT_POS 11*FW+5 #define MIX_LINE_CURVE_POS 12*FW+4 @@ -3578,9 +3576,7 @@ void menuModelExpoMix(uint8_t expo, uint8_t event) putsSwitches(EXPO_LINE_SWITCH_POS, y, ed->swtch, 0); -#if !defined(PCBTARANIS) if (ed->mode!=3) lcd_putc(EXPO_LINE_SIDE_POS, y, ed->mode == 2 ? 126 : 127); -#endif #if defined(CPUARM) && LCD_W >= 212 displayFlightModes(EXPO_LINE_FM_POS, y, ed->phases); diff --git a/radio/src/myeeprom.h b/radio/src/myeeprom.h index 119c69f87..e14146ca1 100644 --- a/radio/src/myeeprom.h +++ b/radio/src/myeeprom.h @@ -446,15 +446,16 @@ PACK(typedef struct t_ExpoData { int8_t swtch; uint16_t phases; int8_t weight; - int8_t carryTrim; + int8_t carryTrim:6; + uint8_t mode:2; char name[LEN_EXPOMIX_NAME]; int8_t offset; CurveRef curve; uint8_t spare; }) ExpoData; #define MIN_EXPO_WEIGHT -100 -#define EXPO_VALID(ed) ((ed)->srcRaw) -#define EXPO_MODE_ENABLE(ed, v) (true) +#define EXPO_VALID(ed) ((ed)->mode) +#define EXPO_MODE_ENABLE(ed, v) (((v)<0 && ((ed)->mode&1)) || ((v)>=0 && ((ed)->mode&2))) #elif defined(CPUARM) PACK(typedef struct t_ExpoData { uint8_t mode; // 0=end, 1=pos, 2=neg, 3=both @@ -468,7 +469,7 @@ PACK(typedef struct t_ExpoData { }) ExpoData; #define MIN_EXPO_WEIGHT 0 #define EXPO_VALID(ed) ((ed)->mode) -#define EXPO_MODE_ENABLE(ed, v) ((v<0 && (ed->mode&1)) || (v>=0 && (ed->mode&2))) +#define EXPO_MODE_ENABLE(ed, v) (((v)<0 && ((ed)->mode&1)) || ((v)>=0 && ((ed)->mode&2))) #elif defined(CPUM2560) || defined(CPUM2561) PACK(typedef struct t_ExpoData { uint8_t mode:2; // 0=end, 1=pos, 2=neg, 3=both @@ -482,7 +483,7 @@ PACK(typedef struct t_ExpoData { }) ExpoData; #define MIN_EXPO_WEIGHT 0 #define EXPO_VALID(ed) ((ed)->mode) -#define EXPO_MODE_ENABLE(ed, v) ((v<0 && (ed->mode&1)) || (v>=0 && (ed->mode&2))) +#define EXPO_MODE_ENABLE(ed, v) (((v)<0 && ((ed)->mode&1)) || ((v)>=0 && ((ed)->mode&2))) #else PACK(typedef struct t_ExpoData { uint8_t mode:2; // 0=end, 1=pos, 2=neg, 3=both @@ -495,7 +496,7 @@ PACK(typedef struct t_ExpoData { }) ExpoData; #define MIN_EXPO_WEIGHT 0 #define EXPO_VALID(ed) ((ed)->mode) -#define EXPO_MODE_ENABLE(ed, v) ((v<0 && (ed->mode&1)) || (v>=0 && (ed->mode&2))) +#define EXPO_MODE_ENABLE(ed, v) (((v)<0 && ((ed)->mode&1)) || ((v)>=0 && ((ed)->mode&2))) #endif #if defined(CPUARM) diff --git a/radio/src/opentx.cpp b/radio/src/opentx.cpp index 6e179bd5c..ff1ee3fa0 100644 --- a/radio/src/opentx.cpp +++ b/radio/src/opentx.cpp @@ -540,6 +540,7 @@ void applyDefaultTemplate() expo->curve.type = CURVE_REF_EXPO; expo->chn = i; expo->weight = 100; + expo->mode = 3; // TODO constant for (int c=0; c<4; c++) { g_model.inputNames[i][c] = char2idx(STR_VSRCRAW[1+STR_VSRCRAW[0]*stick_index+c]); } diff --git a/radio/src/templates.cpp b/radio/src/templates.cpp index 1b2e59a10..1b725bded 100644 --- a/radio/src/templates.cpp +++ b/radio/src/templates.cpp @@ -113,6 +113,7 @@ void defaultInputs() expo->curve.type = CURVE_REF_EXPO; expo->chn = i; expo->weight = 100; + expo->mode = 3; // TODO constant for (int c=0; c<4; c++) { g_model.inputNames[i][c] = char2idx(STR_VSRCRAW[1+STR_VSRCRAW[0]*stick_index+c]); }