Clean up build warnings (#4169)

* [build][OSX] Fix clang warnings.

* [build][OSX] A few more warnings taken care of.

* [build] Fixed yet more build warnings across all platforms.

* [build] Fix final warning due to bad CMake flag.

* [build] Remove unused variables as requested, fix indent.

* Fix output display limit type for 8-bit targets.

companion/src/storage/mountlist.cpp

@@ -227,7 +227,7 @@
 
 #ifdef MOUNTED_GETMNTINFO
 
-# if ! HAVE_STRUCT_STATFS_F_FSTYPENAME
+# if ! HAVE_STRUCT_STATFS_F_FSTYPENAME && !defined(__clang__)
 static const char *
 fstype_to_string (short int t)
 {
@@ -323,6 +323,7 @@ fstype_to_string (short int t)
 }
 # endif
 
+#if !defined(__clang__)
 static const char *
 fsp_to_string (const struct statfs *fsp)
 {
@@ -332,6 +333,7 @@ fsp_to_string (const struct statfs *fsp)
   return fstype_to_string (fsp->f_type);
 # endif
 }
+#endif
 
 #endif /* MOUNTED_GETMNTINFO */
 
@@ -918,7 +920,7 @@ read_file_system_list (bool need_fs_type)
   *mtail = NULL;
   return mount_list;
 
-
+#if !defined(__clang__)
  free_then_fail:
   {
     int saved_errno = errno;
@@ -938,6 +940,7 @@ read_file_system_list (bool need_fs_type)
     errno = saved_errno;
     return NULL;
   }
+#endif
 }
 
 void free_file_system_list(struct mount_entry * mount_list)