Clean up build warnings (#4169)

* [build][OSX] Fix clang warnings.

* [build][OSX] A few more warnings taken care of.

* [build] Fixed yet more build warnings across all platforms.

* [build] Fix final warning due to bad CMake flag.

* [build] Remove unused variables as requested, fix indent.

* Fix output display limit type for 8-bit targets.

radio/src/targets/taranis/adc_driver.cpp

@@ -24,6 +24,7 @@
 #define SAMPTIME       2   // sample time = 28 cycles
 #define SAMPTIME_LONG  3   // sample time = 56 cycles
 
+#if !defined(SIMU)
 #if defined(PCBX9E) && defined(HORUS_STICKS)
   const int8_t ana_direction[NUMBER_ANALOG] = {1,-1,1,-1,  -1,-1,-1,1, -1,1,1,1,  -1};
 #elif defined(PCBX9E)
@@ -37,15 +38,18 @@
 #else
   const int8_t ana_direction[NUMBER_ANALOG] = {1,-1,1,-1,  -1,1,0,   -1,1,  1};
 #endif
+#endif // #if !defined(SIMU)
 
 #if defined(PCBX9E)
     #define NUMBER_ANALOG_ADC1      10
     #define NUMBER_ANALOG_ADC3      (NUMBER_ANALOG - 10)
+#if !defined(SIMU)
     // mapping from adcValues order to enum Analogs
     const uint8_t ana_mapping[NUMBER_ANALOG] = { 0 /*STICK1*/, 1 /*STICK2*/, 2 /*STICK3*/, 3 /*STICK4*/,
                                                  10 /*POT1*/, 4 /*POT2*/, 5 /*POT3*/, 6 /*POT4*/,
                                                  11 /*SLIDER1*/, 12 /*SLIDER2*/, 7 /*SLIDER3*/, 8 /*SLIDER4*/,
                                                  9 /*TX_VOLTAGE*/ };
+#endif  // !defined(SIMU)
 #else
     #define NUMBER_ANALOG_ADC1      NUMBER_ANALOG
 #endif