Merge pull request #664 from EdgeTX/pfeerick/issue663

Set more sensible default colors for output widget
This commit is contained in:
Peter Feerick
2021-09-09 10:09:44 +10:00
committed by GitHub
+120 -90
View File
@@ -1,7 +1,8 @@
/* /*
* Copyright (C) OpenTX * Copyright (C) EdgeTX
* *
* Based on code named * Based on code named
* opentx - https://github.com/opentx/opentx
* th9x - http://code.google.com/p/th9x * th9x - http://code.google.com/p/th9x
* er9x - http://code.google.com/p/er9x * er9x - http://code.google.com/p/er9x
* gruvin9x - http://code.google.com/p/gruvin9x * gruvin9x - http://code.google.com/p/gruvin9x
@@ -21,113 +22,142 @@
#include "opentx.h" #include "opentx.h"
#include "widgets_container_impl.h" #include "widgets_container_impl.h"
#define RECT_BORDER 1 #define RECT_BORDER 1
#define ROW_HEIGHT 17 #define ROW_HEIGHT 17
#define VIEW_CHANNELS_LIMIT_PCT (g_model.extendedLimits ? LIMIT_EXT_PERCENT : 100) #define VIEW_CHANNELS_LIMIT_PCT \
(g_model.extendedLimits ? LIMIT_EXT_PERCENT : 100)
constexpr uint32_t OUTPUTS_REFRESH = 1000 / 5; // 5 Hz constexpr uint32_t OUTPUTS_REFRESH = 1000 / 5; // 5 Hz
class OutputsWidget : public Widget
class OutputsWidget: public Widget
{ {
public: public:
OutputsWidget(const WidgetFactory * factory, FormGroup * parent, const rect_t & rect, Widget::PersistentData * persistentData): OutputsWidget(const WidgetFactory* factory, FormGroup* parent,
const rect_t& rect, Widget::PersistentData* persistentData) :
Widget(factory, parent, rect, persistentData) Widget(factory, parent, rect, persistentData)
{ {
} }
void refresh(BitmapBuffer * dc) override void refresh(BitmapBuffer* dc) override
{ {
if (width() > 300 && height() > 20) if (width() > 300 && height() > 20)
twoColumns(dc); twoColumns(dc);
else if (width() > 150 && height() > 20) else if (width() > 150 && height() > 20)
oneColumn(dc); oneColumn(dc);
} }
uint8_t drawChannels(BitmapBuffer * dc, const uint16_t & x, const uint16_t & y, const uint16_t & w, const uint16_t & h, const uint8_t & firstChan, const bool & bg_shown, const uint16_t & bg_color) uint8_t drawChannels(BitmapBuffer* dc, const uint16_t& x, const uint16_t& y,
{ const uint16_t& w, const uint16_t& h,
const uint8_t numChan = h / ROW_HEIGHT; const uint8_t& firstChan, const bool& bg_shown,
const uint8_t lastChan = firstChan + numChan; const uint16_t& bg_color, const uint16_t& txt_color,
const uint8_t rowH = (h - numChan * ROW_HEIGHT >= numChan ? ROW_HEIGHT + 1 : ROW_HEIGHT); const uint16_t& bar_color)
const uint16_t barW = w - RECT_BORDER * 2; {
const uint8_t barH = rowH - RECT_BORDER; const uint8_t numChan = h / ROW_HEIGHT;
const uint16_t barLft = x + RECT_BORDER; const uint8_t lastChan = firstChan + numChan;
const uint16_t barMid = barLft + barW / 2; const uint8_t rowH =
(h - numChan * ROW_HEIGHT >= numChan ? ROW_HEIGHT + 1 : ROW_HEIGHT);
const uint16_t barW = w - RECT_BORDER * 2;
const uint8_t barH = rowH - RECT_BORDER;
const uint16_t barLft = x + RECT_BORDER;
const uint16_t barMid = barLft + barW / 2;
for (uint8_t curChan = firstChan; curChan < lastChan && curChan <= MAX_OUTPUT_CHANNELS; curChan++) { LcdFlags barColor = COLOR2FLAGS(bar_color);
const int16_t chanVal = calcRESXto100(channelOutputs[curChan-1]); LcdFlags txtColor = COLOR2FLAGS(txt_color);
const uint16_t rowTop = y + (curChan - firstChan) * rowH;
const uint16_t barTop = rowTop + RECT_BORDER;
const uint16_t fillW = divRoundClosest(barW * limit<int16_t>(0, abs(chanVal), VIEW_CHANNELS_LIMIT_PCT), VIEW_CHANNELS_LIMIT_PCT * 2);
if (bg_shown) { for (uint8_t curChan = firstChan;
lcdSetColor(bg_color); curChan < lastChan && curChan <= MAX_OUTPUT_CHANNELS; curChan++) {
dc->drawSolidFilledRect(barLft, barTop, barW , barH, CUSTOM_COLOR); const int16_t chanVal = calcRESXto100(channelOutputs[curChan - 1]);
} const uint16_t rowTop = y + (curChan - firstChan) * rowH;
if (fillW) const uint16_t barTop = rowTop + RECT_BORDER;
dc->drawSolidFilledRect((chanVal > 0 ? barMid : barMid - fillW), barTop, fillW, barH, COLOR_THEME_SECONDARY1); const uint16_t fillW = divRoundClosest(
lcd->drawSolidVerticalLine(barMid, barTop, barH, COLOR_THEME_SECONDARY1); barW * limit<int16_t>(0, abs(chanVal), VIEW_CHANNELS_LIMIT_PCT),
dc->drawRect(x, rowTop, w, rowH + 1); VIEW_CHANNELS_LIMIT_PCT * 2);
dc->drawNumber(x + barW - 10, barTop, chanVal, FONT(XS) | COLOR_THEME_SECONDARY1 | RIGHT, 0, nullptr, "%");
if (g_model.limitData[curChan - 1].name[0] != 0) { if (bg_shown) {
dc->drawNumber(barLft + 1, barTop, curChan, FONT(XS) | COLOR_THEME_SECONDARY1 | LEFT | LEADING0, 2); lcdSetColor(bg_color);
dc->drawSizedText(barLft + 23, barTop, g_model.limitData[curChan - 1].name, sizeof(g_model.limitData[curChan - 1].name), FONT(XS) | COLOR_THEME_SECONDARY1 | LEFT); dc->drawSolidFilledRect(barLft, barTop, barW, barH, CUSTOM_COLOR);
}
else {
drawSource(dc, barLft + 1, barTop, MIXSRC_FIRST_CH+curChan-1, FONT(XS) | COLOR_THEME_SECONDARY1 | LEFT);
}
} }
return lastChan - 1; if (fillW)
} dc->drawSolidFilledRect((chanVal > 0 ? barMid : barMid - fillW), barTop,
fillW, barH, barColor);
void twoColumns(BitmapBuffer * dc) lcd->drawSolidVerticalLine(barMid, barTop, barH, COLOR_THEME_SECONDARY1);
{ dc->drawRect(x, rowTop, w, rowH + 1);
uint8_t endColumn = drawChannels(dc, 0, 0, (width() / 2) - 1, height(), dc->drawNumber(x + barW - 10, barTop, chanVal,
persistentData->options[0].value.unsignedValue, FONT(XS) | txtColor | RIGHT, 0, nullptr, "%");
persistentData->options[1].value.boolValue, if (g_model.limitData[curChan - 1].name[0] != 0) {
persistentData->options[2].value.unsignedValue); dc->drawNumber(barLft + 1, barTop, curChan,
FONT(XS) | txtColor | LEFT | LEADING0, 2);
drawChannels(dc, width() / 2, 0, (width() / 2) - 1, height(), endColumn + 1, dc->drawSizedText(barLft + 23, barTop,
persistentData->options[1].value.boolValue, g_model.limitData[curChan - 1].name,
persistentData->options[2].value.unsignedValue); sizeof(g_model.limitData[curChan - 1].name),
} FONT(XS) | txtColor | LEFT);
} else {
void oneColumn(BitmapBuffer * dc) drawSource(dc, barLft + 1, barTop, MIXSRC_FIRST_CH + curChan - 1,
{ FONT(XS) | txtColor | LEFT);
drawChannels(dc, 0, 0, width(), height(),
persistentData->options[0].value.unsignedValue,
persistentData->options[1].value.boolValue,
persistentData->options[2].value.unsignedValue);
}
void checkEvents() override
{
Widget::checkEvents();
// Last time we refreshed the window
uint32_t now = RTOS_GET_MS();
if (now - lastRefresh >= OUTPUTS_REFRESH) {
lastRefresh = now;
invalidate();
} }
}
return lastChan - 1;
}
void twoColumns(BitmapBuffer* dc)
{
uint8_t endColumn =
drawChannels(dc, 0, 0, (width() / 2) - 1, height(),
persistentData->options[0].value.unsignedValue,
persistentData->options[1].value.boolValue,
persistentData->options[2].value.unsignedValue,
persistentData->options[3].value.unsignedValue,
persistentData->options[4].value.unsignedValue);
drawChannels(dc, width() / 2, 0, (width() / 2) - 1, height(), endColumn + 1,
persistentData->options[1].value.boolValue,
persistentData->options[2].value.unsignedValue,
persistentData->options[3].value.unsignedValue,
persistentData->options[4].value.unsignedValue);
}
void oneColumn(BitmapBuffer* dc)
{
drawChannels(dc, 0, 0, width(), height(),
persistentData->options[0].value.unsignedValue,
persistentData->options[1].value.boolValue,
persistentData->options[2].value.unsignedValue,
persistentData->options[3].value.unsignedValue,
persistentData->options[4].value.unsignedValue);
}
void checkEvents() override
{
Widget::checkEvents();
// Last time we refreshed the window
uint32_t now = RTOS_GET_MS();
if (now - lastRefresh >= OUTPUTS_REFRESH) {
lastRefresh = now;
invalidate(); invalidate();
} }
invalidate();
}
static const ZoneOption options[]; static const ZoneOption options[];
protected: protected:
// Last time we refreshed the window // Last time we refreshed the window
uint32_t lastRefresh = 0; uint32_t lastRefresh = 0;
}; };
const ZoneOption OutputsWidget::options[] = { const ZoneOption OutputsWidget::options[] = {
{ STR_FIRST_CHANNEL, ZoneOption::Integer, OPTION_VALUE_UNSIGNED(1), OPTION_VALUE_UNSIGNED(1), OPTION_VALUE_UNSIGNED(32) }, {STR_FIRST_CHANNEL, ZoneOption::Integer, OPTION_VALUE_UNSIGNED(1),
{ STR_FILL_BACKGROUND, ZoneOption::Bool, OPTION_VALUE_BOOL(false) }, OPTION_VALUE_UNSIGNED(1), OPTION_VALUE_UNSIGNED(32)},
{ STR_BG_COLOR, ZoneOption::Color, OPTION_VALUE_UNSIGNED(LIGHTGREY) }, {STR_FILL_BACKGROUND, ZoneOption::Bool, OPTION_VALUE_BOOL(false)},
{ nullptr, ZoneOption::Bool } {STR_BG_COLOR, ZoneOption::Color, OPTION_VALUE_UNSIGNED(LIGHTGREY)},
}; {STR_TEXT_COLOR, ZoneOption::Color,
OPTION_VALUE_UNSIGNED(COLOR_THEME_PRIMARY1 >> 16)},
{STR_COLOR, ZoneOption::Color,
OPTION_VALUE_UNSIGNED(COLOR_THEME_SECONDARY1 >> 16)},
{nullptr, ZoneOption::Bool}};
BaseWidgetFactory<OutputsWidget> outputsWidget("Outputs", OutputsWidget::options); BaseWidgetFactory<OutputsWidget> outputsWidget("Outputs",
OutputsWidget::options);