From 0c74a9839bd935fe04b133a0eb9e788371dad4de Mon Sep 17 00:00:00 2001 From: Bertrand Songis Date: Mon, 12 Aug 2019 11:06:51 +0200 Subject: [PATCH 01/11] X9D+ 2019 Companion support started --- companion/src/firmwares/boards.cpp | 5 +++++ companion/src/firmwares/boards.h | 7 ++++--- companion/src/firmwares/opentx/opentxinterface.cpp | 9 +++++++++ companion/src/simulation/simulatorwidget.cpp | 1 + 4 files changed, 19 insertions(+), 3 deletions(-) diff --git a/companion/src/firmwares/boards.cpp b/companion/src/firmwares/boards.cpp index 2feff463d..b5acd02c9 100644 --- a/companion/src/firmwares/boards.cpp +++ b/companion/src/firmwares/boards.cpp @@ -70,6 +70,7 @@ uint32_t Boards::getFourCC(Type board) return 0x3578746F; case BOARD_TARANIS_X9D: case BOARD_TARANIS_X9DP: + case BOARD_TARANIS_X9DP_2019: return 0x3378746F; case BOARD_TARANIS_X9LITE: return 0x3C78746F; @@ -113,6 +114,7 @@ const int Boards::getEEpromSize(Board::Type board) case BOARD_TARANIS_X9LITE: case BOARD_TARANIS_X9D: case BOARD_TARANIS_X9DP: + case BOARD_TARANIS_X9DP_2019: case BOARD_TARANIS_X9E: case BOARD_JUMPER_T12: return EESIZE_TARANIS; @@ -147,6 +149,7 @@ const int Boards::getFlashSize(Type board) case BOARD_TARANIS_X9LITE: case BOARD_TARANIS_X9D: case BOARD_TARANIS_X9DP: + case BOARD_TARANIS_X9DP_2019: case BOARD_TARANIS_X9E: case BOARD_JUMPER_T12: return FSIZE_TARANIS; @@ -483,6 +486,8 @@ const QString Boards::getBoardName(Board::Type board) return "Taranis X9D"; case BOARD_TARANIS_X9DP: return "Taranis X9D+"; + case BOARD_TARANIS_X9DP_2019: + return "Taranis X9D+ 2019"; case BOARD_TARANIS_X9E: return "Taranis X9E"; case BOARD_TARANIS_X9LITE: diff --git a/companion/src/firmwares/boards.h b/companion/src/firmwares/boards.h index e9fe9ae54..efb1b2be1 100644 --- a/companion/src/firmwares/boards.h +++ b/companion/src/firmwares/boards.h @@ -42,13 +42,14 @@ namespace Board { BOARD_TARANIS_X7, BOARD_TARANIS_X9D, BOARD_TARANIS_X9DP, + BOARD_TARANIS_X9DP_2019, BOARD_TARANIS_X9E, BOARD_X12S, BOARD_X10, BOARD_TARANIS_XLITE, BOARD_TARANIS_XLITES, BOARD_TARANIS_X9LITE, - BOARD_JUMPER_T12 + BOARD_JUMPER_T12, }; constexpr int BOARD_TYPE_MAX = BOARD_JUMPER_T12 ; @@ -196,8 +197,8 @@ class Boards #define IS_TARANIS_XLITES(board) (board==Board::BOARD_TARANIS_XLITES) #define IS_TARANIS_X7(board) (board==Board::BOARD_TARANIS_X7) #define IS_TARANIS_X9LITE(board) (board==Board::BOARD_TARANIS_X9LITE) -#define IS_TARANIS_X9(board) (board==Board::BOARD_TARANIS_X9D || board==Board::BOARD_TARANIS_X9DP || board==Board::BOARD_TARANIS_X9E) -#define IS_TARANIS_X9D(board) (board==Board::BOARD_TARANIS_X9D || board==Board::BOARD_TARANIS_X9DP) +#define IS_TARANIS_X9(board) (board==Board::BOARD_TARANIS_X9D || board==Board::BOARD_TARANIS_X9DP || board==Board::BOARD_TARANIS_X9DP_2019 || board==Board::BOARD_TARANIS_X9E) +#define IS_TARANIS_X9D(board) (board==Board::BOARD_TARANIS_X9D || board==Board::BOARD_TARANIS_X9DP || board==Board::BOARD_TARANIS_X9DP_2019) #define IS_TARANIS_PLUS(board) (board==Board::BOARD_TARANIS_X9DP || board==Board::BOARD_TARANIS_X9E) #define IS_TARANIS_X9E(board) (board==Board::BOARD_TARANIS_X9E) #define IS_TARANIS(board) (IS_TARANIS_X9(board) || IS_TARANIS_X7(board) || IS_TARANIS_X9LITE(board) || IS_TARANIS_XLITE(board) || IS_JUMPER_T12(board)) diff --git a/companion/src/firmwares/opentx/opentxinterface.cpp b/companion/src/firmwares/opentx/opentxinterface.cpp index 9ebda4d32..e6653598c 100644 --- a/companion/src/firmwares/opentx/opentxinterface.cpp +++ b/companion/src/firmwares/opentx/opentxinterface.cpp @@ -72,6 +72,8 @@ const char * OpenTxEepromInterface::getName() return "OpenTX for FrSky Taranis X9D"; case BOARD_TARANIS_X9DP: return "OpenTX for FrSky Taranis X9D+"; + case BOARD_TARANIS_X9DP_2019: + return "OpenTX for FrSky Taranis X9D+ 2019"; case BOARD_TARANIS_X9E: return "OpenTX for FrSky Taranis X9E"; case BOARD_TARANIS_X7: @@ -1209,6 +1211,13 @@ void registerOpenTxFirmwares() addPPMInternalModuleHack(firmware); registerOpenTxFirmware(firmware); + /* FrSky Taranis X9D+ board */ + firmware = new OpenTxFirmware("opentx-x9d+2019", Firmware::tr("FrSky Taranis X9D+ 2019"), BOARD_TARANIS_X9DP_2019); + firmware->addOption("noras", Firmware::tr("Disable RAS (SWR)")); + addOpenTxTaranisOptions(firmware); + addPPMInternalModuleHack(firmware); + registerOpenTxFirmware(firmware); + /* FrSky Taranis X9D board */ firmware = new OpenTxFirmware("opentx-x9d", Firmware::tr("FrSky Taranis X9D"), BOARD_TARANIS_X9D); firmware->addOption("haptic", Firmware::tr("Haptic module installed")); diff --git a/companion/src/simulation/simulatorwidget.cpp b/companion/src/simulation/simulatorwidget.cpp index e945d7a65..2ec00381d 100644 --- a/companion/src/simulation/simulatorwidget.cpp +++ b/companion/src/simulation/simulatorwidget.cpp @@ -76,6 +76,7 @@ SimulatorWidget::SimulatorWidget(QWidget * parent, SimulatorInterface * simulato break; case Board::BOARD_TARANIS_X9D: case Board::BOARD_TARANIS_X9DP: + case Board::BOARD_TARANIS_X9DP_2019: radioUiWidget = new SimulatedUIWidgetX9(simulator, this); break; case Board::BOARD_TARANIS_XLITE: From 23a28b9b10564d42b68fa64e06be8dc94d4558a1 Mon Sep 17 00:00:00 2001 From: Bertrand Songis Date: Mon, 12 Aug 2019 11:28:18 +0200 Subject: [PATCH 02/11] X9D+ 2019 builds added --- radio/util/build-firmware.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/radio/util/build-firmware.py b/radio/util/build-firmware.py index 6c319b8cb..eaa548055 100755 --- a/radio/util/build-firmware.py +++ b/radio/util/build-firmware.py @@ -6,6 +6,7 @@ import sys import subprocess import shutil import filelock + from fwoptions import * # Error codes @@ -100,6 +101,14 @@ elif options[optcount] == "x9d+": maxsize = 65536 * 8 board = BOARD_TARANIS board_family = BOARD_FAMILY_ARM +elif options[optcount] == "x9d+2019": + command_options["PCB"] = "X9D+" + command_options["PCBREV"] = "2019" + command_options["MULTI_SPORT"] = "ON" + firmware_options = options_taranis_x9dp + maxsize = 65536 * 8 + board = BOARD_TARANIS + board_family = BOARD_FAMILY_ARM elif options[optcount] == "x9e": command_options["PCB"] = "X9E" command_options["MULTI_SPORT"] = "ON" From b9d64c2ca1bc12b3fd2a611c0cb8e720d4c40a8b Mon Sep 17 00:00:00 2001 From: Bertrand Songis Date: Mon, 12 Aug 2019 11:29:04 +0200 Subject: [PATCH 03/11] X9D+ 2019 has 9 switches --- companion/src/firmwares/boards.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/companion/src/firmwares/boards.cpp b/companion/src/firmwares/boards.cpp index b5acd02c9..d5d87e63e 100644 --- a/companion/src/firmwares/boards.cpp +++ b/companion/src/firmwares/boards.cpp @@ -226,7 +226,7 @@ const SwitchInfo Boards::getSwitchInfo(Board::Type board, int index) {SWITCH_2POS, "SF"}, {SWITCH_3POS, "SG"}, {SWITCH_TOGGLE, "SH"}, - {SWITCH_3POS, "SI"}, + {board == Board::BOARD_TARANIS_X9DP_2019 ? SWITCH_TOGGLE : SWITCH_3POS, "SI"}, {SWITCH_3POS, "SJ"}, {SWITCH_3POS, "SK"}, {SWITCH_3POS, "SL"}, @@ -321,6 +321,8 @@ const int Boards::getCapability(Board::Type board, Board::Capability capability) return 6; else if (IS_TARANIS_XLITE(board)) return 4; + else if (board == Board::BOARD_TARANIS_X9DP_2019) + return 9; else if (IS_HORUS_OR_TARANIS(board)) return 8; else From 08290d76fb7d4e1dce1da27c841a73da8bffd1ea Mon Sep 17 00:00:00 2001 From: Bertrand Songis Date: Mon, 12 Aug 2019 11:29:34 +0200 Subject: [PATCH 04/11] Warnings fixes on recent compilers --- companion/src/simulation/joystickdialog.cpp | 6 +++--- companion/src/simulation/simulatorinterface.cpp | 2 +- companion/src/simulation/widgets/virtualjoystickwidget.cpp | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/companion/src/simulation/joystickdialog.cpp b/companion/src/simulation/joystickdialog.cpp index 39058a5bc..223e2d77d 100644 --- a/companion/src/simulation/joystickdialog.cpp +++ b/companion/src/simulation/joystickdialog.cpp @@ -45,14 +45,14 @@ joystickDialog::joystickDialog(QWidget *parent, int stick) : }; memcpy(jscal, jscaltmp, sizeof (jscal)); - foreach(QComboBox *cb, findChildren(QRegExp("jsmapCB_[0-9]+"))) { + foreach(QComboBox *cb, findChildren(QRegularExpression("jsmapCB_[0-9]+"))) { populateSourceCombo(cb); sticks[cb->property("channel").toUInt()] = cb; } - foreach(QCheckBox *ib, findChildren(QRegExp("ChInv_[0-9]+"))) { + foreach(QCheckBox *ib, findChildren(QRegularExpression("ChInv_[0-9]+"))) { invert[ib->property("channel").toUInt()] = ib; } - foreach(QSlider *sl, findChildren(QRegExp("Ch_[0-9]+"))) { + foreach(QSlider *sl, findChildren(QRegularExpression("Ch_[0-9]+"))) { sliders[sl->property("channel").toUInt()] = sl; } diff --git a/companion/src/simulation/simulatorinterface.cpp b/companion/src/simulation/simulatorinterface.cpp index 24919e055..1ed9cc520 100644 --- a/companion/src/simulation/simulatorinterface.cpp +++ b/companion/src/simulation/simulatorinterface.cpp @@ -100,7 +100,7 @@ void SimulatorLoader::registerSimulators() path.truncate(path.lastIndexOf('\\')); dir.setPath(path); #else - dir = SIMULATOR_LIB_SEARCH_PATH; + dir.setPath(SIMULATOR_LIB_SEARCH_PATH); #endif registerSimulators(dir); } diff --git a/companion/src/simulation/widgets/virtualjoystickwidget.cpp b/companion/src/simulation/widgets/virtualjoystickwidget.cpp index 8e9a4fa45..8ba63daa4 100644 --- a/companion/src/simulation/widgets/virtualjoystickwidget.cpp +++ b/companion/src/simulation/widgets/virtualjoystickwidget.cpp @@ -444,7 +444,7 @@ QLayout *VirtualJoystickWidget::createNodeValueLayout(QChar type, QLabel *& valL val->setObjectName(QString("val_%1").arg(type)); val->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Fixed); val->setAlignment(Qt::AlignCenter); - val->setMinimumWidth(val->fontMetrics().width("-100 ")); + val->setMinimumWidth(val->fontMetrics().horizontalAdvance("-100 ")); QVBoxLayout * layout = new QVBoxLayout(); layout->setContentsMargins(2, 2, 2, 2); layout->setSpacing(2); From 8c6cb524c4b31a872dbf7122831096e6451609f9 Mon Sep 17 00:00:00 2001 From: 3djc Date: Mon, 12 Aug 2019 11:51:52 +0200 Subject: [PATCH 05/11] No 'noras' option for 2019 version --- companion/src/firmwares/opentx/opentxinterface.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/companion/src/firmwares/opentx/opentxinterface.cpp b/companion/src/firmwares/opentx/opentxinterface.cpp index e6653598c..437dc4b16 100644 --- a/companion/src/firmwares/opentx/opentxinterface.cpp +++ b/companion/src/firmwares/opentx/opentxinterface.cpp @@ -1211,9 +1211,8 @@ void registerOpenTxFirmwares() addPPMInternalModuleHack(firmware); registerOpenTxFirmware(firmware); - /* FrSky Taranis X9D+ board */ + /* FrSky Taranis X9D+ 2019 board */ firmware = new OpenTxFirmware("opentx-x9d+2019", Firmware::tr("FrSky Taranis X9D+ 2019"), BOARD_TARANIS_X9DP_2019); - firmware->addOption("noras", Firmware::tr("Disable RAS (SWR)")); addOpenTxTaranisOptions(firmware); addPPMInternalModuleHack(firmware); registerOpenTxFirmware(firmware); From a724d742af699911d7402940354de7905391e8ea Mon Sep 17 00:00:00 2001 From: Bertrand Songis Date: Mon, 12 Aug 2019 14:25:34 +0200 Subject: [PATCH 06/11] Too early fix (not compatible with Qt5.7) --- companion/src/simulation/widgets/virtualjoystickwidget.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/companion/src/simulation/widgets/virtualjoystickwidget.cpp b/companion/src/simulation/widgets/virtualjoystickwidget.cpp index 8ba63daa4..7fdab15bb 100644 --- a/companion/src/simulation/widgets/virtualjoystickwidget.cpp +++ b/companion/src/simulation/widgets/virtualjoystickwidget.cpp @@ -444,7 +444,8 @@ QLayout *VirtualJoystickWidget::createNodeValueLayout(QChar type, QLabel *& valL val->setObjectName(QString("val_%1").arg(type)); val->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Fixed); val->setAlignment(Qt::AlignCenter); - val->setMinimumWidth(val->fontMetrics().horizontalAdvance("-100 ")); + val->setMinimumWidth(val->fontMetrics().width("-100 ")); + // TODO 2.4 => val->setMinimumWidth(val->fontMetrics().horizontalAdvance("-100 ")); QVBoxLayout * layout = new QVBoxLayout(); layout->setContentsMargins(2, 2, 2, 2); layout->setSpacing(2); From 239dfdfcdd40133dafc56e4fdc0b85eb134a5307 Mon Sep 17 00:00:00 2001 From: 3djc Date: Mon, 12 Aug 2019 14:29:25 +0200 Subject: [PATCH 07/11] Allow 212 radios --- tools/nightly23/build-nightly.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/nightly23/build-nightly.sh b/tools/nightly23/build-nightly.sh index 606297a34..71c1c920a 100755 --- a/tools/nightly23/build-nightly.sh +++ b/tools/nightly23/build-nightly.sh @@ -35,7 +35,7 @@ docker run -dit --name companion -v /home/opentx/${docker}:/opentx ${docker} docker exec companion sh -c "mkdir -p build && cd build && cmake /opentx/code && cp radio/src/stamp.h /opentx/binaries/stamp-opentx.txt" cp -f ${workdir}/binaries/stamp-opentx.txt ${output}/firmware # These radios are currently not enabled -echo "#define BLOCK \"x9d,x9d+,x9e,x10,x12s\"" >> ${output}/firmware/stamp-opentx.txt +echo "#define BLOCK \"x10,x12s\"" >> ${output}/firmware/stamp-opentx.txt docker exec companion rm -rf build echo "Check if Linux companion is needed" From abe1f843c1c14249d99e89fedb7e144d4c833da9 Mon Sep 17 00:00:00 2001 From: Bertrand Songis Date: Mon, 12 Aug 2019 14:35:55 +0200 Subject: [PATCH 08/11] Warning better fix --- companion/src/simulation/widgets/virtualjoystickwidget.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/companion/src/simulation/widgets/virtualjoystickwidget.cpp b/companion/src/simulation/widgets/virtualjoystickwidget.cpp index 7fdab15bb..4da39137e 100644 --- a/companion/src/simulation/widgets/virtualjoystickwidget.cpp +++ b/companion/src/simulation/widgets/virtualjoystickwidget.cpp @@ -444,8 +444,11 @@ QLayout *VirtualJoystickWidget::createNodeValueLayout(QChar type, QLabel *& valL val->setObjectName(QString("val_%1").arg(type)); val->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Fixed); val->setAlignment(Qt::AlignCenter); +#if QT_VERSION < QT_VERSION_CHECK(5, 11, 0) val->setMinimumWidth(val->fontMetrics().width("-100 ")); - // TODO 2.4 => val->setMinimumWidth(val->fontMetrics().horizontalAdvance("-100 ")); +#else + val->setMinimumWidth(val->fontMetrics().horizontalAdvance("-100 ")); +#endif QVBoxLayout * layout = new QVBoxLayout(); layout->setContentsMargins(2, 2, 2, 2); layout->setSpacing(2); From 75a5dfef2461c4280ede8b8a7010d7b417b72c23 Mon Sep 17 00:00:00 2001 From: Bertrand Songis Date: Mon, 12 Aug 2019 14:54:16 +0200 Subject: [PATCH 09/11] Warnings removed --- companion/src/firmwares/rawsource.cpp | 4 ++-- companion/src/firmwares/sensordata.cpp | 8 ++++---- companion/src/mainwindow.cpp | 18 +++++++++--------- .../src/simulation/radiooutputswidget.cpp | 4 ++++ 4 files changed, 19 insertions(+), 15 deletions(-) diff --git a/companion/src/firmwares/rawsource.cpp b/companion/src/firmwares/rawsource.cpp index 507518150..b2d13e401 100644 --- a/companion/src/firmwares/rawsource.cpp +++ b/companion/src/firmwares/rawsource.cpp @@ -128,13 +128,13 @@ RawSourceRange RawSource::getRange(const ModelData * model, const GeneralSetting case TELEMETRY_SOURCE_T2_MAX: result.min = -30; result.max = 225; - result.unit = trUtf8("°C"); + result.unit = tr("°C"); break; case TELEMETRY_SOURCE_HDG: result.step = 2; result.max = 360; result.offset = 256; - result.unit = trUtf8("°"); + result.unit = tr("°"); break; case TELEMETRY_SOURCE_RPM: case TELEMETRY_SOURCE_RPM_MAX: diff --git a/companion/src/firmwares/sensordata.cpp b/companion/src/firmwares/sensordata.cpp index cf294a390..56c2653fe 100644 --- a/companion/src/firmwares/sensordata.cpp +++ b/companion/src/firmwares/sensordata.cpp @@ -52,9 +52,9 @@ QString SensorData::unitString() const case UNIT_FEET: return tr("f"); case UNIT_CELSIUS: - return trUtf8("°C"); + return tr("°C"); case UNIT_FAHRENHEIT: - return trUtf8("°F"); + return tr("°F"); case UNIT_PERCENT: return tr("%"); case UNIT_MAH: @@ -70,9 +70,9 @@ QString SensorData::unitString() const case UNIT_G: return tr("g"); case UNIT_DEGREE: - return trUtf8("°"); + return tr("°"); case UNIT_RADIANS: - return trUtf8("Rad"); + return tr("Rad"); case UNIT_HOURS: return tr("hours"); case UNIT_MINUTES: diff --git a/companion/src/mainwindow.cpp b/companion/src/mainwindow.cpp index 4e1dd7fbf..e795594cb 100644 --- a/companion/src/mainwindow.cpp +++ b/companion/src/mainwindow.cpp @@ -323,13 +323,13 @@ QString MainWindow::seekCodeString(const QByteArray & qba, const QString & label { int posLabel = qba.indexOf(label); if (posLabel < 0) - return QString::null; + return QString(); int start = qba.indexOf("\"", posLabel + label.length()); if (start < 0) - return QString::null; + return QString(); int end = qba.indexOf("\"", start + 1); if (end < 0) - return QString::null; + return QString(); return qba.mid(start + 1, end - start - 1); } @@ -529,10 +529,10 @@ void MainWindow::checkForFirmwareUpdateFinished(QNetworkReply * reply) QAbstractButton *rnButton = nullptr; msgBox.setText(tr("Firmware %1 does not seem to have ever been downloaded.\nVersion %2 is available.\nDo you want to download it now?\n\nWe recommend you view the release notes using the button below to learn about any changes that may be important to you.") .arg(Firmware::getCurrentVariant()->getId()).arg(fullVersionString)); - QAbstractButton *YesButton = msgBox.addButton(trUtf8("Yes"), QMessageBox::YesRole); - msgBox.addButton(trUtf8("No"), QMessageBox::NoRole); + QAbstractButton *YesButton = msgBox.addButton(tr("Yes"), QMessageBox::YesRole); + msgBox.addButton(tr("No"), QMessageBox::NoRole); if (!rn.isEmpty()) { - rnButton = msgBox.addButton(trUtf8("Release Notes"), QMessageBox::ActionRole); + rnButton = msgBox.addButton(tr("Release Notes"), QMessageBox::ActionRole); } msgBox.setIcon(QMessageBox::Question); msgBox.resize(0, 0); @@ -558,10 +558,10 @@ void MainWindow::checkForFirmwareUpdateFinished(QNetworkReply * reply) QAbstractButton *rnButton = nullptr; msgBox.setText(tr("A new version of %1 firmware is available:\n - current is %2\n - newer is %3\n\nDo you want to download it now?\n\nWe recommend you view the release notes using the button below to learn about any changes that may be important to you.") .arg(Firmware::getCurrentVariant()->getId()).arg(currentVersionString).arg(fullVersionString)); - QAbstractButton *YesButton = msgBox.addButton(trUtf8("Yes"), QMessageBox::YesRole); - msgBox.addButton(trUtf8("No"), QMessageBox::NoRole); + QAbstractButton *YesButton = msgBox.addButton(tr("Yes"), QMessageBox::YesRole); + msgBox.addButton(tr("No"), QMessageBox::NoRole); if (!rn.isEmpty()) { - rnButton = msgBox.addButton(trUtf8("Release Notes"), QMessageBox::ActionRole); + rnButton = msgBox.addButton(tr("Release Notes"), QMessageBox::ActionRole); } msgBox.setIcon(QMessageBox::Question); msgBox.resize(0,0); diff --git a/companion/src/simulation/radiooutputswidget.cpp b/companion/src/simulation/radiooutputswidget.cpp index 18cdbec81..d1c1434f5 100644 --- a/companion/src/simulation/radiooutputswidget.cpp +++ b/companion/src/simulation/radiooutputswidget.cpp @@ -290,7 +290,11 @@ QWidget * RadioOutputsWidget::createLogicalSwitch(QWidget * parent, int switchNo QFont font = swtch->font(); font.setBold(true); swtch->setFont(font); +#if QT_VERSION < QT_VERSION_CHECK(5, 11, 0) swtch->setMinimumWidth(swtch->fontMetrics().width("99") + 10); +#else + swtch->setMinimumWidth(swtch->fontMetrics().horizontalAdvance("99") + 10); +#endif font.setBold(false); swtch->setFont(font); swtch->setText(QString("%1").arg(switchNo+1, 2, 10, QChar('0'))); From 725d5606d78eb69e2adfe3aaa5b8a5e0ed49a8c4 Mon Sep 17 00:00:00 2001 From: Bertrand Songis Date: Mon, 12 Aug 2019 15:01:10 +0200 Subject: [PATCH 10/11] More warnings removed --- companion/src/helpers.cpp | 2 +- companion/src/logsdialog.cpp | 2 +- companion/src/modeledit/inputs.cpp | 2 +- companion/src/modeledit/mixes.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/companion/src/helpers.cpp b/companion/src/helpers.cpp index 4dd966ebc..8ecf55f12 100644 --- a/companion/src/helpers.cpp +++ b/companion/src/helpers.cpp @@ -443,7 +443,7 @@ void Helpers::populateFileComboBox(QComboBox * b, const QSet & set, con bool added = false; // Convert set into list and sort it alphabetically case insensitive QStringList list = QStringList::fromSet(set); - qSort(list.begin(), list.end(), caseInsensitiveLessThan); + std::sort(list.begin(), list.end(), caseInsensitiveLessThan); foreach (QString entry, list) { b->addItem(entry); if (entry == current) { diff --git a/companion/src/logsdialog.cpp b/companion/src/logsdialog.cpp index ed28245ba..e60318c69 100644 --- a/companion/src/logsdialog.cpp +++ b/companion/src/logsdialog.cpp @@ -830,7 +830,7 @@ void LogsDialog::plotLogs() foreach (QModelIndex index, selection) { selectedRows.append(index.row()); } - qSort(selectedRows.begin(), selectedRows.end()); + std::sort(selectedRows.begin(), selectedRows.end()); } else { hasLogSelection = false; rowCount = ui->logTable->rowCount(); diff --git a/companion/src/modeledit/inputs.cpp b/companion/src/modeledit/inputs.cpp index cbdefb581..27ca4c42f 100644 --- a/companion/src/modeledit/inputs.cpp +++ b/companion/src/modeledit/inputs.cpp @@ -483,7 +483,7 @@ void InputsPanel::expolistWidget_doubleClicked(QModelIndex index) void InputsPanel::exposDeleteList(QList list, bool clearName) { - qSort(list.begin(), list.end()); + std::sort(list.begin(), list.end()); int iDec = 0; foreach(int idx, list) { diff --git a/companion/src/modeledit/mixes.cpp b/companion/src/modeledit/mixes.cpp index f5d76d32f..c92105ec6 100644 --- a/companion/src/modeledit/mixes.cpp +++ b/companion/src/modeledit/mixes.cpp @@ -222,7 +222,7 @@ void MixesPanel::mixerlistWidget_doubleClicked(QModelIndex index) void MixesPanel::mixersDeleteList(QList list) { - qSort(list.begin(), list.end()); + std::sort(list.begin(), list.end()); int iDec = 0; foreach(int idx, list) { From 039c58fdc9afa7cb4f90691eace51efc96acb41f Mon Sep 17 00:00:00 2001 From: Bertrand Songis Date: Mon, 12 Aug 2019 15:09:06 +0200 Subject: [PATCH 11/11] More warnings fixed --- companion/src/modeledit/node.cpp | 6 +++--- companion/src/modeledit/setup.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/companion/src/modeledit/node.cpp b/companion/src/modeledit/node.cpp index a93e0fb2c..302bfebc8 100644 --- a/companion/src/modeledit/node.cpp +++ b/companion/src/modeledit/node.cpp @@ -160,11 +160,11 @@ void Node::paint(QPainter *painter, const QStyleOptionGraphicsItem *option, QWid if (option->state & QStyle::State_Sunken) { gradient.setCenter(ballHeight, ballHeight); gradient.setFocalPoint(ballHeight, ballHeight); - gradient.setColorAt(1, nodecolor.light(180)); - gradient.setColorAt(0, nodecolor.light(120)); + gradient.setColorAt(1, nodecolor.lighter(180)); + gradient.setColorAt(0, nodecolor.lighter(120)); } else { gradient.setColorAt(0, nodecolor); - gradient.setColorAt(1, nodecolor.dark(120)); + gradient.setColorAt(1, nodecolor.darker(120)); } painter->setBrush(gradient); painter->setPen(QPen(Qt::black, 0)); diff --git a/companion/src/modeledit/setup.cpp b/companion/src/modeledit/setup.cpp index a30949446..2dc74e5fe 100644 --- a/companion/src/modeledit/setup.cpp +++ b/companion/src/modeledit/setup.cpp @@ -925,7 +925,7 @@ SetupPanel::SetupPanel(QWidget * parent, ModelData & model, GeneralSettings & ge prevFocus = timers[i]->getLastFocus(); } else { - foreach(QLabel *label, findChildren(QRegExp(QString("label_timer%1").arg(i+1)))) { + foreach(QLabel *label, findChildren(QRegularExpression(QString("label_timer%1").arg(i+1)))) { label->hide(); } }