[simulation] Fix some potential crashes & 26 memory leaks, improve LCD redraws. (#4634)

* [simulation] Hardening: Fix some potential crashes & 26 memory leaks, improve LCD performance.
  * [simpgmspace] Init trims; Make sure `REa` is really defined (to match board files).
  * [simpgmspace][opentxsimulator] Verify current running state before start/stop; Move rotary enc. init.
  * [simpgmspace][LcdWidget] Improve performance by moving LCD content change check to lcdRefresh() & limiting LcdWidget refresh time to 60 fps max.
  * [simueeprom] Ensure thread could be started, set default running state to false.
  * [simufatfs] Fix paths report trace.
  * [eepromimportexport] Fix memory leaks resulting from import debugging scheme being used.
  * [customdebug] Introduce new scheme for custom debug output in compliance with Qt recommendations (see docs for QLoggingCategory).
  * [opentxeeprom] Fix extra conversion table cache elements being created and also not properly deleted (and hence leaking).
  * [opentxinterface] Unregister EEpromInterfaces in unregisterOpenTxFirmwares();
  * [storage] Unregister storage factories on exit (fixes leak); create virtual StorageFormat/StorageFactory destructors (prevents warnings).
  * [helpers] GVarGroup now emits own signal, no need to pass ModelPanel pointer (removes dependency on modeledit.h)
  * [DebugOutput] Clear simulator trace hook before exiting (prevent possible issues); Fix leak and possible bad QString allocations when reading from buffer; Fix leak with combo box event filter.
  * [TelemetrySimulator] Fix leak by deleting LogPlaybackController object on exit; Only set up data fields once; convert timers to static.
  * [build] Consolidate all Companion/Simulator shared items in `common` library to reduce build time/etc (node & edge still remain awkward).

* [simulatorwidget] Delete removed spacer object (previously-forgotten "26th" leak).

* [DebugOutput] Fix stray trailing characters issue with new text buffer allocation (from previous commit); Increase maximum buffer sizes to better accommodate slower systems.

* Cosmetics.

This commit is contained in:

Max Paperno

2017-03-21 07:43:40 +01:00

committed by

Bertrand Songis

parent 52e65179a8

commit 4aa0c1bbe4

28 changed files with 290 additions and 210 deletions

									
										companion/src/simulator.cpp
									
		+4
		
												View File
												
				@@ -34,6 +34,7 @@

				#include "appdata.h"

				#include "appdebugmessagehandler.h"

				#include "constants.h"

				#include "customdebug.h"

				#include "eeprominterface.h"

				#include "simulator.h"

				#include "simulatormainwindow.h"

				@@ -95,6 +96,8 @@ int main(int argc, char *argv[])

				  if (AppDebugMessageHandler::instance())

				    AppDebugMessageHandler::instance()->installAppMessageHandler();

				  CustomDebug::setFilterRules();

				  g.init();

				  QTranslator companionTranslator;

				@@ -257,6 +260,7 @@ int finish(int exitCode)

				  qDebug() << "SIMULATOR EXIT" << exitCode;

				  unregisterSimulators();

				  unregisterOpenTxFirmwares();

				  unregisterStorageFactories();

				#if defined(JOYSTICKS) || defined(SIMU_AUDIO)

				  SDL_Quit();