diff --git a/companion/src/modeledit/setup.cpp b/companion/src/modeledit/setup.cpp index 373e12579..cd67f0a9d 100644 --- a/companion/src/modeledit/setup.cpp +++ b/companion/src/modeledit/setup.cpp @@ -173,6 +173,7 @@ ModulePanel::ModulePanel(QWidget * parent, ModelData & model, ModuleData & modul ui->label_trainerMode->hide(); ui->trainerMode->hide(); } + ui->formLayout_col1->setSpacing(0); } else { ui->label_trainerMode->hide(); @@ -201,10 +202,10 @@ ModulePanel::ModulePanel(QWidget * parent, ModelData & model, ModuleData & modul for (int i=0; iisAvailable((PulsesProtocol)i, moduleIdx)) { ui->protocol->addItem(ModelPrinter::printModuleProtocol(i), (QVariant)i); - if (i == module.protocol) ui->protocol->setCurrentIndex(ui->protocol->count()-1); + if (i == module.protocol) + ui->protocol->setCurrentIndex(ui->protocol->count()-1); } } - for (int i=0; i<=MM_RF_PROTO_LAST; i++) { ui->multiProtocol->addItem(ModelPrinter::printMultiRfProtocol(i, false), (QVariant) i); } @@ -240,6 +241,11 @@ ModulePanel::ModulePanel(QWidget * parent, ModelData & model, ModuleData & modul disableMouseScrolling(); lock = false; + + // a change will not register if only one item was added + if (ui->protocol->count() == 1) + on_protocol_currentIndexChanged(ui->protocol->currentIndex()); + } ModulePanel::~ModulePanel() @@ -378,7 +384,7 @@ void ModulePanel::update() ui->label_failsafeMode->setVisible(mask & MASK_FAILSAFES); ui->failsafeMode->setVisible(mask & MASK_FAILSAFES); ui->failsafeMode->setCurrentIndex(module.failsafeMode); - ui->failsafesFrame->setEnabled(module.failsafeMode == FAILSAFE_CUSTOM); + ui->failsafesGroupBox->setEnabled(module.failsafeMode == FAILSAFE_CUSTOM); if (firmware->getCapability(ChannelsName) > 0) { for(int i=0; ilimitData[i+module.channelsStart].name).trimmed(); @@ -395,8 +401,7 @@ void ModulePanel::update() mask = 0; } - ui->failsafesLayoutLabel->setVisible(mask & MASK_FAILSAFES); - ui->failsafesFrame->setVisible(mask & MASK_FAILSAFES); + ui->failsafesGroupBox->setVisible((mask & MASK_FAILSAFES) && module.failsafeMode == FAILSAFE_CUSTOM); if (mask & MASK_CHANNELS_RANGE) { ui->channelsStart->setMaximum(33 - ui->channelsCount->value()); diff --git a/companion/src/modeledit/setup.ui b/companion/src/modeledit/setup.ui index a36c85767..b94f55ac0 100644 --- a/companion/src/modeledit/setup.ui +++ b/companion/src/modeledit/setup.ui @@ -7,7 +7,7 @@ 0 0 840 - 520 + 371 @@ -206,7 +206,7 @@ 20 - 40 + 0 @@ -251,7 +251,7 @@ 20 - 40 + 0 @@ -615,7 +615,7 @@ If this is checked the throttle will be reversed. Idle will be forward, trim wi 20 - 40 + 0 diff --git a/companion/src/modeledit/setup_module.ui b/companion/src/modeledit/setup_module.ui index 6fc71bf6e..d5a9c8e3d 100644 --- a/companion/src/modeledit/setup_module.ui +++ b/companion/src/modeledit/setup_module.ui @@ -6,8 +6,8 @@ 0 0 - 757 - 300 + 674 + 205 @@ -17,7 +17,16 @@ 6 - + + 0 + + + 0 + + + 0 + + 0 @@ -61,465 +70,636 @@ - + - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - 0 - - + + 6 - - - - - 125 - 16777215 - - - + + 7 + + + 6 + + + 7 + + + 6 + + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - + + 6 - - CH + + 4 - - 1 - - - 32 - - - 1 - - - 1 - - + + + + + 16777215 + 16777215 + + + + Start + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + CH + + + 1 + + + 32 + + + 1 + + + 1 + + + + + + + SubType + + + + + + + + 0 + 0 + + + + QComboBox::AdjustToContents + + + + + + + + 16777215 + 16777215 + + + + Polarity + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + QComboBox::AdjustToContents + + + + Negative + + + + + Positive + + + + + + + + + 16777215 + 16777215 + + + + Antenna + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + QComboBox::AdjustToContents + + + + Internal + + + + + Ext. + Int. + + + + + + + + Output type + + + + + + + + 0 + 0 + + + + QComboBox::AdjustToContents + + + + Open Drain + + + + + Push Pull + + + + + - - - - - 700 - 16777215 - + + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - QFrame::StyledPanel + + 6 - - QFrame::Sunken + + 4 + + + + + + 0 + 0 + + + + + 16777215 + 16777215 + + + + Channels + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + 4 + + + 16 + + + 2 + + + 8 + + + + + + + + 16777215 + 16777215 + + + + Receiver No. + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + + + + 0 + + + 63 + + + 1 + + + 0 + + + + + + + Bind on startup + + + + + + + Low Power + + + + + + + + 16777215 + 16777215 + + + + PPM delay + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + us + + + 100 + + + 800 + + + 50 + + + 300 + + + + + + + + 16777215 + 16777215 + + + + PPM Frame Length + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + ms + + + 1 + + + 12.500000000000000 + + + 32.500000000000000 + + + 0.500000000000000 + + + 22.500000000000000 + + + + + + + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + 6 + + + 4 + + + + + + 16777215 + 16777215 + + + + Protocol + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + QComboBox::AdjustToContents + + + + + + + Multi Radio Protocol + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + QComboBox::AdjustToContents + + + + + + + + 16777215 + 16777215 + + + + Failsafe Mode + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + QComboBox::AdjustToContents + + + + Not set + + + + + Hold + + + + + Custom + + + + + No Pulses + + + + + Receiver + + + + + + + + + 16777215 + 16777215 + + + + Trainer Mode + + + Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter + + + + + + + + 0 + 0 + + + + QComboBox::AdjustToContents + + + + Master/Jack + + + + + Slave/Jack + + + + + Master/SBUS Module + + + + + Master/CPPM Module + + + + + Master/SBUS in battery compartment + + + + + + + + + + Failsafe Positions + + 3 + + + 6 + + + 4 + + + 6 + + + 4 + - + + + 6 + + - - - + + + + Qt::Vertical + + - 16777215 - 16777215 + 20 + 0 - - Failsafe Mode - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - + - - - - - 16777215 - 16777215 - - - - Start - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - - - 125 - 16777215 - - - - - - - - - 16777215 - 16777215 - - - - Antenna - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - - - 0 - 0 - - - - - 125 - 16777215 - - - - - Internal - - - - - Ext. + Int. - - - - - - - - - 16777215 - 16777215 - - - - PPM delay - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - - - 125 - 16777215 - - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - us - - - 100 - - - 800 - - - 50 - - - 300 - - - - - - - - 0 - 0 - - - - - 125 - 16777215 - - - - - Negative - - - - - Positive - - - - - - - - - 0 - 0 - - - - - Master/Jack - - - - - Slave/Jack - - - - - Master/SBUS Module - - - - - Master/CPPM Module - - - - - Master/SBUS in battery compartment - - - - - - - - - 16777215 - 16777215 - - - - Polarity - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - - - 16777215 - 16777215 - - - - Trainer Mode - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - - - 0 - 0 - - - - - 125 - 16777215 - - - - ms - - - 1 - - - 12.500000000000000 - - - 32.500000000000000 - - - 0.500000000000000 - - - 22.500000000000000 - - - - - - - - 125 - 16777215 - - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - 4 - - - 16 - - - 2 - - - 8 - - - - - - - - 16777215 - 16777215 - - - - PPM Frame Length - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - - - 0 - 0 - - - - - 16777215 - 16777215 - - - - Channels - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - - - 0 - 0 - - - - - 125 - 16777215 - - - - - Not set - - - - - Hold - - - - - Custom - - - - - No Pulses - - - - - Receiver - - - - - - - - - 16777215 - 16777215 - - - - Failsafe Positions - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - - - 16777215 - 16777215 - - - - Protocol - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - + Qt::Horizontal @@ -532,154 +712,16 @@ - - - - Qt::Vertical - - - - 20 - 40 - - - - - - - - - 0 - 0 - - - - - 125 - 16777215 - - - - - - - 0 - - - 63 - - - 1 - - - 0 - - - - - - - Multi Radio Protocol - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - - - 125 - 16777215 - - - - - - - - - 16777215 - 16777215 - - - - Receiver No. - - - Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter - - - - - - - Output type - - - - - - - - Open Drain - - - - - Push Pull - - - - - - - - SubType - - - - - - - - 125 - 16777215 - - - - - - - - Bind on startup - - - - - - - Low Power - - - - trainerMode protocol channelsStart channelsCount - ppmFrameLength - ppmPolarity - ppmDelay failsafeMode - ppmOutputType - rxNumber