Serial port settings are mutually exclusive
This commit is contained in:
@@ -35,6 +35,50 @@ constexpr char FIM_SWITCHTYPE2POS[] {"Switch Type 2 Pos"};
|
|||||||
constexpr char FIM_SWITCHTYPE3POS[] {"Switch Type 3 Pos"};
|
constexpr char FIM_SWITCHTYPE3POS[] {"Switch Type 3 Pos"};
|
||||||
constexpr char FIM_INTERNALMODULES[] {"Internal Modules"};
|
constexpr char FIM_INTERNALMODULES[] {"Internal Modules"};
|
||||||
|
|
||||||
|
class ExclusiveComboGroup: public QObject
|
||||||
|
{
|
||||||
|
static constexpr auto _role = Qt::UserRole + 500;
|
||||||
|
|
||||||
|
QList<QComboBox*> combos;
|
||||||
|
std::function<bool(const QVariant&)> filter;
|
||||||
|
|
||||||
|
public:
|
||||||
|
ExclusiveComboGroup(QObject *parent, std::function<bool(const QVariant&)> filter) :
|
||||||
|
QObject(parent), filter(std::move(filter))
|
||||||
|
{
|
||||||
|
}
|
||||||
|
|
||||||
|
void addCombo(QComboBox *comboBox)
|
||||||
|
{
|
||||||
|
connect(comboBox, QOverload<int>::of(&QComboBox::activated),
|
||||||
|
[=](int index) { this->handleActivated(comboBox, index); });
|
||||||
|
combos.append(comboBox);
|
||||||
|
}
|
||||||
|
|
||||||
|
void handleActivated(QComboBox* target, int index) {
|
||||||
|
auto data = target->itemData(index);
|
||||||
|
auto targetidx = combos.indexOf(target);
|
||||||
|
for (auto combo : combos) {
|
||||||
|
if (target == combo) continue;
|
||||||
|
auto view = dynamic_cast<QListView*>(combo->view());
|
||||||
|
Q_ASSERT(view);
|
||||||
|
|
||||||
|
auto previous = combo->findData(targetidx, _role);
|
||||||
|
if (previous >= 0) {
|
||||||
|
view->setRowHidden(previous, false);
|
||||||
|
combo->setItemData(previous, QVariant(), _role);
|
||||||
|
}
|
||||||
|
if (!filter(data)) {
|
||||||
|
auto idx = combo->findData(data);
|
||||||
|
if (idx >= 0) {
|
||||||
|
view->setRowHidden(idx, true);
|
||||||
|
combo->setItemData(idx, targetidx, _role);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
HardwarePanel::HardwarePanel(QWidget * parent, GeneralSettings & generalSettings, Firmware * firmware, CompoundItemModelFactory * sharedItemModels):
|
HardwarePanel::HardwarePanel(QWidget * parent, GeneralSettings & generalSettings, Firmware * firmware, CompoundItemModelFactory * sharedItemModels):
|
||||||
GeneralPanel(parent, generalSettings, firmware),
|
GeneralPanel(parent, generalSettings, firmware),
|
||||||
board(firmware->getBoard()),
|
board(firmware->getBoard()),
|
||||||
@@ -150,6 +194,10 @@ HardwarePanel::HardwarePanel(QWidget * parent, GeneralSettings & generalSettings
|
|||||||
addParams(row, maxBaudRate);
|
addParams(row, maxBaudRate);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// All values except 0 are mutually exclusive
|
||||||
|
ExclusiveComboGroup *exclGroup = new ExclusiveComboGroup(
|
||||||
|
this, [=](const QVariant &value) { return value == 0; });
|
||||||
|
|
||||||
if (firmware->getCapability(HasAuxSerialMode)) {
|
if (firmware->getCapability(HasAuxSerialMode)) {
|
||||||
QString lbl = "Serial Port";
|
QString lbl = "Serial Port";
|
||||||
if (IS_RADIOMASTER_TX16S(board))
|
if (IS_RADIOMASTER_TX16S(board))
|
||||||
@@ -158,6 +206,7 @@ HardwarePanel::HardwarePanel(QWidget * parent, GeneralSettings & generalSettings
|
|||||||
AutoComboBox *serialPortMode = new AutoComboBox(this);
|
AutoComboBox *serialPortMode = new AutoComboBox(this);
|
||||||
serialPortMode->setModel(editorItemModels->getItemModel(auxmodelid));
|
serialPortMode->setModel(editorItemModels->getItemModel(auxmodelid));
|
||||||
serialPortMode->setField(generalSettings.serialPort[GeneralSettings::SP_AUX1]);
|
serialPortMode->setField(generalSettings.serialPort[GeneralSettings::SP_AUX1]);
|
||||||
|
exclGroup->addCombo(serialPortMode);
|
||||||
addParams(row, serialPortMode);
|
addParams(row, serialPortMode);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -169,6 +218,7 @@ HardwarePanel::HardwarePanel(QWidget * parent, GeneralSettings & generalSettings
|
|||||||
AutoComboBox *serialPortMode = new AutoComboBox(this);
|
AutoComboBox *serialPortMode = new AutoComboBox(this);
|
||||||
serialPortMode->setModel(editorItemModels->getItemModel(auxmodelid));
|
serialPortMode->setModel(editorItemModels->getItemModel(auxmodelid));
|
||||||
serialPortMode->setField(generalSettings.serialPort[GeneralSettings::SP_AUX2]);
|
serialPortMode->setField(generalSettings.serialPort[GeneralSettings::SP_AUX2]);
|
||||||
|
exclGroup->addCombo(serialPortMode);
|
||||||
addParams(row, serialPortMode);
|
addParams(row, serialPortMode);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -177,6 +227,7 @@ HardwarePanel::HardwarePanel(QWidget * parent, GeneralSettings & generalSettings
|
|||||||
AutoComboBox *serialPortMode = new AutoComboBox(this);
|
AutoComboBox *serialPortMode = new AutoComboBox(this);
|
||||||
serialPortMode->setModel(editorItemModels->getItemModel(vcpmodelid));
|
serialPortMode->setModel(editorItemModels->getItemModel(vcpmodelid));
|
||||||
serialPortMode->setField(generalSettings.serialPort[GeneralSettings::SP_VCP]);
|
serialPortMode->setField(generalSettings.serialPort[GeneralSettings::SP_VCP]);
|
||||||
|
exclGroup->addCombo(serialPortMode);
|
||||||
addParams(row, serialPortMode);
|
addParams(row, serialPortMode);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user