Bsongis/sonar (#5555)

Some sonar issues fixed
This commit is contained in:
Bertrand Songis
2017-12-21 18:25:27 +01:00
committed by GitHub
parent b7855cf14d
commit 7806c2096d
13 changed files with 77 additions and 73 deletions
+1 -1
View File
@@ -35,7 +35,7 @@ if(GTEST_INCDIR AND GTEST_SRCDIR AND Qt5Widgets_FOUND)
set(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} -O0")
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -O0")
use_cxx11() # ensure gnu++11 in CXX_FLAGS with CMake < 3.1
use_cxx14() # ensure c++14 in CXX_FLAGS with CMake < 3.1
add_executable(gtests EXCLUDE_FROM_ALL ${TEST_SRC_FILES} ${CMAKE_CURRENT_SOURCE_DIR}/location.h ${RADIO_SRC} ../targets/simu/simpgmspace.cpp ../targets/simu/simueeprom.cpp ../targets/simu/simufatfs.cpp)
qt5_use_modules(gtests Core Widgets)
+6 -6
View File
@@ -62,17 +62,17 @@ TEST(Lua, testPanicProtection)
bool passed = false;
PROTECT_LUA() {
PROTECT_LUA() {
//simulate panic
// simulate panic
longjmp(global_lj->b, 1);
}
else {
//we should come here
// we should come here
passed = true;
}
UNPROTECT_LUA();
}
else {
// an not here
// and not here
// TRACE("testLuaProtection: test 1 FAILED");
FAIL() << "Failed test 1";
}
@@ -85,15 +85,15 @@ TEST(Lua, testPanicProtection)
PROTECT_LUA() {
PROTECT_LUA() {
int a = 5;
a = a; // avoids the warning
UNUSED(a);
}
else {
//we should not come here
// we should not come here
// TRACE("testLuaProtection: test 2 FAILED");
FAIL() << "Failed test 2";
}
UNPROTECT_LUA()
//simulate panic
// simulate panic
longjmp(global_lj->b, 1);
}
else {