diff --git a/radio/src/gui/128x64/model_setup.cpp b/radio/src/gui/128x64/model_setup.cpp index 7727db70b..17351eaca 100644 --- a/radio/src/gui/128x64/model_setup.cpp +++ b/radio/src/gui/128x64/model_setup.cpp @@ -1034,7 +1034,7 @@ void menuModelSetup(event_t event) else if (isModuleXJT(INTERNAL_MODULE)) { g_model.moduleData[INTERNAL_MODULE].rfProtocol = checkIncDec(event, g_model.moduleData[INTERNAL_MODULE].rfProtocol, 0, MODULE_SUBTYPE_PXX1_LAST, EE_MODEL, isRfProtocolAvailable); if (checkIncDec_Ret) { - g_model.moduleData[0].type = MODULE_TYPE_PXX1_XJT; + g_model.moduleData[0].type = MODULE_TYPE_XJT_PXX1; g_model.moduleData[0].channelsStart = 0; g_model.moduleData[0].channelsCount = defaultModuleChannels_M8(INTERNAL_MODULE); } @@ -1045,7 +1045,7 @@ void menuModelSetup(event_t event) } #else uint8_t index = 0; - if (g_model.moduleData[INTERNAL_MODULE].type == MODULE_TYPE_PXX2_ISRM) { + if (g_model.moduleData[INTERNAL_MODULE].type == MODULE_TYPE_ISRM_PXX2) { index = 1 + g_model.moduleData[INTERNAL_MODULE].subType; } lcdDrawTextAtIndex(MODEL_SETUP_2ND_COLUMN, y, STR_ISRM_PXX2_RF_PROTOCOLS, index, attr); @@ -1054,7 +1054,7 @@ void menuModelSetup(event_t event) if (checkIncDec_Ret) { memclear(&g_model.moduleData[INTERNAL_MODULE], sizeof(ModuleData)); if (index > 0) { - g_model.moduleData[INTERNAL_MODULE].type = MODULE_TYPE_PXX2_ISRM; + g_model.moduleData[INTERNAL_MODULE].type = MODULE_TYPE_ISRM_PXX2; g_model.moduleData[INTERNAL_MODULE].subType = index - 1; g_model.moduleData[INTERNAL_MODULE].channelsCount = defaultModuleChannels_M8(INTERNAL_MODULE); } @@ -1305,7 +1305,7 @@ void menuModelSetup(event_t event) CHECK_INCDEC_MODELVAR_ZERO(event, moduleData.channelsStart, 32-8-moduleData.channelsCount); break; case 1: - CHECK_INCDEC_MODELVAR_CHECK(event, moduleData.channelsCount, -4, min(maxModuleChannels_M8(moduleIdx), 32-8-moduleData.channelsStart), moduleData.type == MODULE_TYPE_PXX2_ISRM ? isPxx2IsrmChannelsCountAllowed : nullptr); + CHECK_INCDEC_MODELVAR_CHECK(event, moduleData.channelsCount, -4, min(maxModuleChannels_M8(moduleIdx), 32-8-moduleData.channelsStart), moduleData.type == MODULE_TYPE_ISRM_PXX2 ? isPxx2IsrmChannelsCountAllowed : nullptr); if ((k == ITEM_MODEL_SETUP_EXTERNAL_MODULE_CHANNELS && g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_PPM)) { SET_DEFAULT_PPM_FRAME_LENGTH(moduleIdx); } @@ -1764,7 +1764,7 @@ void menuModelSetup(event_t event) lcdDrawTextAlignedLeft(y, TR_MULTI_RFPOWER); if (isModuleR9M_FCC_VARIANT(moduleIdx)) { g_model.moduleData[moduleIdx].pxx.power = min((uint8_t)g_model.moduleData[moduleIdx].pxx.power, (uint8_t)R9M_FCC_POWER_MAX); // Lite FCC has only one setting - if (g_model.moduleData[moduleIdx].type == MODULE_TYPE_PXX1_R9M_LITE) { // R9M lite FCC has only one power value, so displayed for info only + if (g_model.moduleData[moduleIdx].type == MODULE_TYPE_R9M_LITE_PXX1) { // R9M lite FCC has only one power value, so displayed for info only lcdDrawTextAtIndex(MODEL_SETUP_2ND_COLUMN, y, STR_R9M_LITE_FCC_POWER_VALUES, g_model.moduleData[moduleIdx].pxx.power, LEFT); if (attr) REPEAT_LAST_CURSOR_MOVE(); @@ -1775,7 +1775,7 @@ void menuModelSetup(event_t event) CHECK_INCDEC_MODELVAR_ZERO(event, g_model.moduleData[moduleIdx].pxx.power, R9M_FCC_POWER_MAX); } } - else if (g_model.moduleData[moduleIdx].type == MODULE_TYPE_PXX1_R9M_LITE) { + else if (g_model.moduleData[moduleIdx].type == MODULE_TYPE_R9M_LITE_PXX1) { g_model.moduleData[moduleIdx].pxx.power = min((uint8_t)g_model.moduleData[moduleIdx].pxx.power, (uint8_t)R9M_LITE_LBT_POWER_MAX); lcdDrawTextAtIndex(MODEL_SETUP_2ND_COLUMN, y, STR_R9M_LITE_LBT_POWER_VALUES, g_model.moduleData[moduleIdx].pxx.power, LEFT | attr); if (attr) { @@ -1788,7 +1788,7 @@ void menuModelSetup(event_t event) reusableBuffer.moduleSetup.r9mPower = g_model.moduleData[moduleIdx].pxx.power; } } - else if (g_model.moduleData[moduleIdx].type == MODULE_TYPE_PXX1_R9M) { + else if (g_model.moduleData[moduleIdx].type == MODULE_TYPE_R9M_PXX1) { g_model.moduleData[moduleIdx].pxx.power = min((uint8_t)g_model.moduleData[moduleIdx].pxx.power, (uint8_t)R9M_LBT_POWER_MAX); lcdDrawTextAtIndex(MODEL_SETUP_2ND_COLUMN, y, STR_R9M_LBT_POWER_VALUES, g_model.moduleData[moduleIdx].pxx.power, LEFT | attr); if (attr) { diff --git a/radio/src/gui/212x64/model_setup.cpp b/radio/src/gui/212x64/model_setup.cpp index c72951aeb..9aaab8f74 100644 --- a/radio/src/gui/212x64/model_setup.cpp +++ b/radio/src/gui/212x64/model_setup.cpp @@ -674,7 +674,7 @@ void menuModelSetup(event_t event) if (attr && s_editMode>0) { switch (menuHorizontalPosition) { case 0: - g_model.moduleData[INTERNAL_MODULE].type = checkIncDec(event, g_model.moduleData[INTERNAL_MODULE].type, MODULE_TYPE_NONE, MODULE_TYPE_PXX1_XJT, EE_MODEL, isModuleAvailable); + g_model.moduleData[INTERNAL_MODULE].type = checkIncDec(event, g_model.moduleData[INTERNAL_MODULE].type, MODULE_TYPE_NONE, MODULE_TYPE_XJT_PXX1, EE_MODEL, isModuleAvailable); if (checkIncDec_Ret) { g_model.moduleData[INTERNAL_MODULE].rfProtocol = 0; g_model.moduleData[INTERNAL_MODULE].channelsStart = 0; @@ -698,7 +698,7 @@ void menuModelSetup(event_t event) g_model.moduleData[INTERNAL_MODULE].rfProtocol = checkIncDec(event, g_model.moduleData[INTERNAL_MODULE].rfProtocol, -1, MODULE_SUBTYPE_PXX1_LAST, EE_MODEL, isRfProtocolAvailable); if (checkIncDec_Ret) { - g_model.moduleData[INTERNAL_MODULE].type = MODULE_TYPE_PXX1_XJT; + g_model.moduleData[INTERNAL_MODULE].type = MODULE_TYPE_XJT_PXX1; g_model.moduleData[INTERNAL_MODULE].channelsStart = 0; g_model.moduleData[INTERNAL_MODULE].channelsCount = defaultModuleChannels_M8(INTERNAL_MODULE); if (g_model.moduleData[INTERNAL_MODULE].rfProtocol == MODULE_SUBTYPE_PXX1_OFF) diff --git a/radio/src/gui/212x64/model_telemetry.cpp b/radio/src/gui/212x64/model_telemetry.cpp index 42661edab..d952497da 100644 --- a/radio/src/gui/212x64/model_telemetry.cpp +++ b/radio/src/gui/212x64/model_telemetry.cpp @@ -214,7 +214,7 @@ void menuModelTelemetryFrsky(event_t event) case ITEM_TELEMETRY_RSSI_LABEL: #if defined(MULTIMODULE) - if (g_model.moduleData[INTERNAL_MODULE].type != MODULE_TYPE_PXX1_XJT && + if (g_model.moduleData[INTERNAL_MODULE].type != MODULE_TYPE_XJT_PXX1 && g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_MULTIMODULE && g_model.moduleData[EXTERNAL_MODULE].getMultiProtocol(false) == MODULE_SUBTYPE_MULTI_FS_AFHDS2A) lcdDrawTextAlignedLeft(y, "RSNR"); diff --git a/radio/src/gui/480x272/model_setup.cpp b/radio/src/gui/480x272/model_setup.cpp index b10a178fd..e84e71a94 100644 --- a/radio/src/gui/480x272/model_setup.cpp +++ b/radio/src/gui/480x272/model_setup.cpp @@ -943,7 +943,7 @@ bool menuModelSetup(event_t event) else if (isModuleXJT(INTERNAL_MODULE)) { g_model.moduleData[INTERNAL_MODULE].rfProtocol = checkIncDec(event, g_model.moduleData[INTERNAL_MODULE].rfProtocol, MODULE_SUBTYPE_PXX1_ACCST_D16, MODULE_SUBTYPE_PXX1_LAST, EE_MODEL, isRfProtocolAvailable); if (checkIncDec_Ret) { - g_model.moduleData[0].type = MODULE_TYPE_PXX1_XJT; + g_model.moduleData[0].type = MODULE_TYPE_XJT_PXX1; g_model.moduleData[0].channelsStart = 0; g_model.moduleData[0].channelsCount = defaultModuleChannels_M8(INTERNAL_MODULE); } diff --git a/radio/src/gui/gui_common.cpp b/radio/src/gui/gui_common.cpp index 9e3f533dd..b2f3ef029 100644 --- a/radio/src/gui/gui_common.cpp +++ b/radio/src/gui/gui_common.cpp @@ -555,11 +555,11 @@ bool isModuleUSingSport(uint8_t moduleBay, uint8_t moduleType) case MODULE_TYPE_PPM: case MODULE_TYPE_DSM2: case MODULE_TYPE_MULTIMODULE: - case MODULE_TYPE_PXX2_R9M_LITE: - case MODULE_TYPE_PXX2_R9M_LITE_PRO: + case MODULE_TYPE_R9M_LITE_PXX2: + case MODULE_TYPE_R9M_LITE_PRO_PXX2: return false; - case MODULE_TYPE_PXX2_ISRM: + case MODULE_TYPE_ISRM_PXX2: if (moduleBay == EXTERNAL_MODULE) return false; @@ -579,15 +579,15 @@ bool isInternalModuleAvailable(int moduleType) return true; #if defined(PXX1) && defined(INTERNAL_MODULE_PXX1) - if (moduleType == MODULE_TYPE_PXX1_XJT) + if (moduleType == MODULE_TYPE_XJT_PXX1) return !isModuleUSingSport(EXTERNAL_MODULE, g_model.moduleData[EXTERNAL_MODULE].type); #else - if (moduleType == MODULE_TYPE_PXX1_XJT) + if (moduleType == MODULE_TYPE_XJT_PXX1) return false; #endif #if defined(PXX2) - if (moduleType == MODULE_TYPE_PXX2_ISRM) + if (moduleType == MODULE_TYPE_ISRM_PXX2) #if defined(INTMODULE_USART) return true; #else @@ -602,30 +602,30 @@ bool isInternalModuleAvailable(int moduleType) bool isExternalModuleAvailable(int moduleType) { #if !defined(PCBXLITE) && !defined(PCBX9LITE) - if (moduleType == MODULE_TYPE_PXX1_R9M_LITE || moduleType == MODULE_TYPE_PXX2_R9M_LITE || moduleType == MODULE_TYPE_PXX2_R9M_LITE_PRO) + if (moduleType == MODULE_TYPE_R9M_LITE_PXX1 || moduleType == MODULE_TYPE_R9M_LITE_PXX2 || moduleType == MODULE_TYPE_R9M_LITE_PRO_PXX2) return false; #endif #if !defined(PXX1) - if (moduleType == MODULE_TYPE_PXX1_XJT || moduleType == MODULE_TYPE_PXX1_R9M || moduleType == MODULE_TYPE_PXX1_R9M_LITE) + if (moduleType == MODULE_TYPE_XJT_PXX1 || moduleType == MODULE_TYPE_R9M_PXX1 || moduleType == MODULE_TYPE_R9M_LITE_PXX1) return false; #endif #if !defined(XJT) - if (moduleType == MODULE_TYPE_PXX1_XJT) + if (moduleType == MODULE_TYPE_XJT_PXX1) return false; #endif #if !defined(R9M_SIZE_STD) - if (moduleType == MODULE_TYPE_PXX1_R9M) + if (moduleType == MODULE_TYPE_R9M_PXX1) return false; #endif - if (moduleType == MODULE_TYPE_PXX2_ISRM || moduleType == MODULE_TYPE_PXX2_R9M) + if (moduleType == MODULE_TYPE_ISRM_PXX2 || moduleType == MODULE_TYPE_R9M_PXX2) return false; #if !defined(PXX2) - if (moduleType == MODULE_TYPE_PXX2_R9M || moduleType == MODULE_TYPE_PXX2_R9M_LITE || moduleType == MODULE_TYPE_PXX2_R9M_LITE_PRO) { + if (moduleType == MODULE_TYPE_R9M_PXX2 || moduleType == MODULE_TYPE_R9M_LITE_PXX2 || moduleType == MODULE_TYPE_R9M_LITE_PRO_PXX2) { return false; } #endif @@ -676,10 +676,10 @@ bool isRfProtocolAvailable(int protocol) } #endif #if defined(PCBTARANIS) || defined(PCBHORUS) - if (protocol != MODULE_SUBTYPE_PXX1_OFF && g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_PXX1_R9M) { + if (protocol != MODULE_SUBTYPE_PXX1_OFF && g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_R9M_PXX1) { return false; } - if (protocol != MODULE_SUBTYPE_PXX1_OFF && g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_PXX2_R9M) { + if (protocol != MODULE_SUBTYPE_PXX1_OFF && g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_R9M_PXX2) { return false; } #endif diff --git a/radio/src/gui/gui_common.h b/radio/src/gui/gui_common.h index 1c9279845..a14d0f329 100644 --- a/radio/src/gui/gui_common.h +++ b/radio/src/gui/gui_common.h @@ -160,7 +160,7 @@ const mm_protocol_definition *getMultiProtocolDefinition (uint8_t protocol); #define EXTERNAL_MODULE_OPTION_ROW (isModuleR9M(EXTERNAL_MODULE) || isModuleSBUS(EXTERNAL_MODULE) ? TITLE_ROW : MULTIMODULE_OPTIONS_ROW) -#define EXTERNAL_MODULE_POWER_ROW (isModuleMultimodule(EXTERNAL_MODULE) || isModuleR9M(EXTERNAL_MODULE)) ? (g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_PXX1_R9M_LITE ? TITLE_ROW : (uint8_t) 0) : HIDDEN_ROW +#define EXTERNAL_MODULE_POWER_ROW (isModuleMultimodule(EXTERNAL_MODULE) || isModuleR9M(EXTERNAL_MODULE)) ? (g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_R9M_LITE_PXX1 ? TITLE_ROW : (uint8_t) 0) : HIDDEN_ROW void editStickHardwareSettings(coord_t x, coord_t y, int idx, event_t event, LcdFlags flags); diff --git a/radio/src/opentx.cpp b/radio/src/opentx.cpp index 2b8f9022e..0ede92872 100644 --- a/radio/src/opentx.cpp +++ b/radio/src/opentx.cpp @@ -473,7 +473,7 @@ void modelDefault(uint8_t id) #endif #if defined(HARDWARE_INTERNAL_MODULE) - g_model.moduleData[INTERNAL_MODULE].type = IS_PXX2_INTERNAL_ENABLED() ? MODULE_TYPE_PXX2_ISRM : MODULE_TYPE_PXX1_XJT; + g_model.moduleData[INTERNAL_MODULE].type = IS_PXX2_INTERNAL_ENABLED() ? MODULE_TYPE_ISRM_PXX2 : MODULE_TYPE_XJT_PXX1; g_model.moduleData[INTERNAL_MODULE].channelsCount = defaultModuleChannels_M8(INTERNAL_MODULE); #elif defined(PCBSKY9X) g_model.moduleData[EXTERNAL_MODULE].type = MODULE_TYPE_PPM; diff --git a/radio/src/pulses/modules_constants.h b/radio/src/pulses/modules_constants.h index deec44c12..b8d190660 100644 --- a/radio/src/pulses/modules_constants.h +++ b/radio/src/pulses/modules_constants.h @@ -1,16 +1,16 @@ enum ModuleType { MODULE_TYPE_NONE = 0, MODULE_TYPE_PPM, - MODULE_TYPE_PXX1_XJT, - MODULE_TYPE_PXX2_ISRM, + MODULE_TYPE_XJT_PXX1, + MODULE_TYPE_ISRM_PXX2, MODULE_TYPE_DSM2, MODULE_TYPE_CROSSFIRE, MODULE_TYPE_MULTIMODULE, - MODULE_TYPE_PXX1_R9M, - MODULE_TYPE_PXX2_R9M, - MODULE_TYPE_PXX1_R9M_LITE, - MODULE_TYPE_PXX2_R9M_LITE, - MODULE_TYPE_PXX2_R9M_LITE_PRO, + MODULE_TYPE_R9M_PXX1, + MODULE_TYPE_R9M_PXX2, + MODULE_TYPE_R9M_LITE_PXX1, + MODULE_TYPE_R9M_LITE_PXX2, + MODULE_TYPE_R9M_LITE_PRO_PXX2, MODULE_TYPE_SBUS, MODULE_TYPE_MAX = MODULE_TYPE_SBUS, MODULE_TYPE_COUNT diff --git a/radio/src/pulses/modules_helpers.h b/radio/src/pulses/modules_helpers.h index ce44b3928..2ae4280bf 100644 --- a/radio/src/pulses/modules_helpers.h +++ b/radio/src/pulses/modules_helpers.h @@ -51,17 +51,17 @@ inline bool isModuleMultimoduleDSM2(uint8_t) inline bool isModuleXJT(uint8_t idx) { - return g_model.moduleData[idx].type == MODULE_TYPE_PXX1_XJT; + return g_model.moduleData[idx].type == MODULE_TYPE_XJT_PXX1; } inline bool isModuleXJT2(uint8_t idx) { - return g_model.moduleData[idx].type == MODULE_TYPE_PXX2_ISRM; + return g_model.moduleData[idx].type == MODULE_TYPE_ISRM_PXX2; } inline bool isModuleXJTVariant(uint8_t idx) { - return g_model.moduleData[idx].type == MODULE_TYPE_PXX1_XJT || g_model.moduleData[idx].type == MODULE_TYPE_PXX2_ISRM; + return g_model.moduleData[idx].type == MODULE_TYPE_XJT_PXX1 || g_model.moduleData[idx].type == MODULE_TYPE_ISRM_PXX2; } @@ -105,12 +105,12 @@ inline bool isModulePPM(uint8_t idx) inline bool isModuleR9M(uint8_t idx) { - return g_model.moduleData[idx].type == MODULE_TYPE_PXX1_R9M || g_model.moduleData[idx].type == MODULE_TYPE_PXX1_R9M_LITE; + return g_model.moduleData[idx].type == MODULE_TYPE_R9M_PXX1 || g_model.moduleData[idx].type == MODULE_TYPE_R9M_LITE_PXX1; } inline bool isModuleR9M2(uint8_t idx) { - return g_model.moduleData[idx].type == MODULE_TYPE_PXX2_R9M || g_model.moduleData[idx].type == MODULE_TYPE_PXX2_R9M_LITE || g_model.moduleData[idx].type == MODULE_TYPE_PXX2_R9M_LITE_PRO; + return g_model.moduleData[idx].type == MODULE_TYPE_R9M_PXX2 || g_model.moduleData[idx].type == MODULE_TYPE_R9M_LITE_PXX2 || g_model.moduleData[idx].type == MODULE_TYPE_R9M_LITE_PRO_PXX2; } diff --git a/radio/src/pulses/pulses.cpp b/radio/src/pulses/pulses.cpp index 625ecda37..173165fc2 100755 --- a/radio/src/pulses/pulses.cpp +++ b/radio/src/pulses/pulses.cpp @@ -54,7 +54,7 @@ uint8_t getRequiredProtocol(uint8_t module) protocol = PROTOCOL_CHANNELS_PPM; break; - case MODULE_TYPE_PXX1_XJT: + case MODULE_TYPE_XJT_PXX1: #if defined(INTMODULE_USART) if (module == INTERNAL_MODULE) { protocol = PROTOCOL_CHANNELS_PXX1_SERIAL; @@ -63,18 +63,18 @@ uint8_t getRequiredProtocol(uint8_t module) #endif // no break - case MODULE_TYPE_PXX1_R9M: + case MODULE_TYPE_R9M_PXX1: protocol = PROTOCOL_CHANNELS_PXX1_PULSES; break; - case MODULE_TYPE_PXX1_R9M_LITE: + case MODULE_TYPE_R9M_LITE_PXX1: protocol = PROTOCOL_CHANNELS_PXX1_SERIAL; break; - case MODULE_TYPE_PXX2_ISRM: - case MODULE_TYPE_PXX2_R9M: - case MODULE_TYPE_PXX2_R9M_LITE: - case MODULE_TYPE_PXX2_R9M_LITE_PRO: + case MODULE_TYPE_ISRM_PXX2: + case MODULE_TYPE_R9M_PXX2: + case MODULE_TYPE_R9M_LITE_PXX2: + case MODULE_TYPE_R9M_LITE_PRO_PXX2: protocol = PROTOCOL_CHANNELS_PXX2; break; diff --git a/radio/src/pulses/pulses.h b/radio/src/pulses/pulses.h index 382218d29..c1246e2d4 100644 --- a/radio/src/pulses/pulses.h +++ b/radio/src/pulses/pulses.h @@ -411,5 +411,5 @@ enum R9MLBTPowerValues { }; #define BIND_CH9TO16_ALLOWED(idx) (!isModuleR9M_LBT(idx) || g_model.moduleData[idx].pxx.power != R9M_LBT_POWER_25) -#define BIND_TELEM_ALLOWED(idx) (g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_PXX1_R9M) ? (!(IS_TELEMETRY_INTERNAL_MODULE() && moduleIdx == EXTERNAL_MODULE) && (!isModuleR9M_LBT(idx) || g_model.moduleData[idx].pxx.power < R9M_LBT_POWER_200)) : (!(IS_TELEMETRY_INTERNAL_MODULE() && moduleIdx == EXTERNAL_MODULE) && (!isModuleR9M_LBT(idx) || g_model.moduleData[idx].pxx.power < R9M_LITE_LBT_POWER_100)) +#define BIND_TELEM_ALLOWED(idx) (g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_R9M_PXX1) ? (!(IS_TELEMETRY_INTERNAL_MODULE() && moduleIdx == EXTERNAL_MODULE) && (!isModuleR9M_LBT(idx) || g_model.moduleData[idx].pxx.power < R9M_LBT_POWER_200)) : (!(IS_TELEMETRY_INTERNAL_MODULE() && moduleIdx == EXTERNAL_MODULE) && (!isModuleR9M_LBT(idx) || g_model.moduleData[idx].pxx.power < R9M_LITE_LBT_POWER_100)) #endif // _PULSES_H_ diff --git a/radio/src/pulses/pxx2.cpp b/radio/src/pulses/pxx2.cpp index 99f9474ad..f9d7536b7 100644 --- a/radio/src/pulses/pxx2.cpp +++ b/radio/src/pulses/pxx2.cpp @@ -354,7 +354,7 @@ void Pxx2Pulses::setupFrame(uint8_t module) setupRegisterFrame(module); break; case MODULE_MODE_BIND: - if (g_model.moduleData[module].type == MODULE_TYPE_PXX2_ISRM && g_model.moduleData[module].subType != MODULE_SUBTYPE_ISRM_PXX2_ACCESS) + if (g_model.moduleData[module].type == MODULE_TYPE_ISRM_PXX2 && g_model.moduleData[module].subType != MODULE_SUBTYPE_ISRM_PXX2_ACCESS) setupAccstBindFrame(module); else setupAccessBindFrame(module); diff --git a/radio/src/storage/conversions/conversions_216_218.cpp b/radio/src/storage/conversions/conversions_216_218.cpp index 97f0dcc3f..9839b58f0 100644 --- a/radio/src/storage/conversions/conversions_216_218.cpp +++ b/radio/src/storage/conversions/conversions_216_218.cpp @@ -1059,7 +1059,7 @@ void convertModelData_216_to_217(ModelData &model) } #if defined(PCBTARANIS) - newModel.moduleData[INTERNAL_MODULE].type = MODULE_TYPE_PXX1_XJT; + newModel.moduleData[INTERNAL_MODULE].type = MODULE_TYPE_XJT_PXX1; #endif newModel.moduleData[EXTERNAL_MODULE].type = oldModel.externalModule; @@ -1140,7 +1140,7 @@ void convertModelData_217_to_218(ModelData &model) for (int i=0; i= MODULE_TYPE_PXX2_ISRM) + if (newModel.moduleData[i].type >= MODULE_TYPE_ISRM_PXX2) newModel.moduleData[i].type += 1; - if (newModel.moduleData[i].type >= MODULE_TYPE_PXX2_R9M) + if (newModel.moduleData[i].type >= MODULE_TYPE_R9M_PXX2) newModel.moduleData[i].type += 4; } diff --git a/radio/src/storage/storage_common.cpp b/radio/src/storage/storage_common.cpp index 7428ad604..78cd7f5d0 100644 --- a/radio/src/storage/storage_common.cpp +++ b/radio/src/storage/storage_common.cpp @@ -57,7 +57,7 @@ void preModelLoad() static void fixUpModel() { // Ensure that when rfProtocol is MODULE_SUBTYPE_PXX1_OFF the type of the module is MODULE_TYPE_NONE - if (g_model.moduleData[INTERNAL_MODULE].type == MODULE_TYPE_PXX1_XJT && g_model.moduleData[INTERNAL_MODULE].rfProtocol == MODULE_SUBTYPE_PXX1_OFF) + if (g_model.moduleData[INTERNAL_MODULE].type == MODULE_TYPE_XJT_PXX1 && g_model.moduleData[INTERNAL_MODULE].rfProtocol == MODULE_SUBTYPE_PXX1_OFF) g_model.moduleData[INTERNAL_MODULE].type = MODULE_TYPE_NONE; } #endif diff --git a/radio/src/targets/taranis/extmodule_driver.cpp b/radio/src/targets/taranis/extmodule_driver.cpp index dee0d11a2..6197230db 100644 --- a/radio/src/targets/taranis/extmodule_driver.cpp +++ b/radio/src/targets/taranis/extmodule_driver.cpp @@ -214,7 +214,7 @@ extern "C" void EXTMODULE_USART_IRQHandler(void) void extmodulePxx2Start() { - extmoduleInvertedSerialStart(g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_PXX2_R9M_LITE_PRO ? 450000 : 230400); + extmoduleInvertedSerialStart(g_model.moduleData[EXTERNAL_MODULE].type == MODULE_TYPE_R9M_LITE_PRO_PXX2 ? 450000 : 230400); } #else void extmodulePxx2Start() diff --git a/radio/src/telemetry/telemetry.h b/radio/src/telemetry/telemetry.h index 5f8038183..372219fad 100644 --- a/radio/src/telemetry/telemetry.h +++ b/radio/src/telemetry/telemetry.h @@ -238,7 +238,7 @@ extern Fifo * luaInputTelemetryFifo; #endif #if defined(STM32) -#define IS_TELEMETRY_INTERNAL_MODULE() (g_model.moduleData[INTERNAL_MODULE].type == MODULE_TYPE_PXX1_XJT) +#define IS_TELEMETRY_INTERNAL_MODULE() (g_model.moduleData[INTERNAL_MODULE].type == MODULE_TYPE_XJT_PXX1) #else #define IS_TELEMETRY_INTERNAL_MODULE() (false) #endif diff --git a/radio/src/tests/conversions.cpp b/radio/src/tests/conversions.cpp index dde71449a..50d94c531 100644 --- a/radio/src/tests/conversions.cpp +++ b/radio/src/tests/conversions.cpp @@ -47,7 +47,7 @@ TEST(Conversions, ConversionX9DPFrom22) EXPECT_EQ(SWASH_TYPE_120X, g_model.swashR.type); EXPECT_EQ(10, g_model.flightModeData[0].gvars[0]); EXPECT_ZSTREQ("Tes", g_model.gvars[0].name); - EXPECT_EQ(MODULE_TYPE_PXX1_R9M, g_model.moduleData[EXTERNAL_MODULE].type); + EXPECT_EQ(MODULE_TYPE_R9M_PXX1, g_model.moduleData[EXTERNAL_MODULE].type); EXPECT_EQ(MODULE_SUBTYPE_R9M_FCC, g_model.moduleData[EXTERNAL_MODULE].subType); EXPECT_ZSTREQ("Thr", g_model.inputNames[0]); EXPECT_ZSTREQ("Tes", g_model.telemetrySensors[0].label); @@ -66,7 +66,7 @@ TEST(Conversions, ConversionX7From22) eeLoadModel(0); EXPECT_ZSTREQ("Test", g_model.header.name); - EXPECT_EQ(MODULE_TYPE_PXX1_R9M, g_model.moduleData[EXTERNAL_MODULE].type); + EXPECT_EQ(MODULE_TYPE_R9M_PXX1, g_model.moduleData[EXTERNAL_MODULE].type); EXPECT_EQ(MODULE_SUBTYPE_R9M_EU, g_model.moduleData[EXTERNAL_MODULE].subType); EXPECT_EQ(80, g_model.mixData[0].weight); EXPECT_EQ(80, g_model.expoData[0].weight); @@ -111,7 +111,7 @@ TEST(Conversions, ConversionHorusFrom22) EXPECT_ZSTREQ("Tes", g_model.flightModeData[0].name); EXPECT_EQ(10, g_model.flightModeData[0].gvars[0]); EXPECT_ZSTREQ("Tes", g_model.gvars[0].name); - EXPECT_EQ(MODULE_TYPE_PXX1_R9M, g_model.moduleData[EXTERNAL_MODULE].type); + EXPECT_EQ(MODULE_TYPE_R9M_PXX1, g_model.moduleData[EXTERNAL_MODULE].type); EXPECT_EQ(MODULE_SUBTYPE_R9M_EU, g_model.moduleData[EXTERNAL_MODULE].subType); EXPECT_ZSTREQ("Rud", g_model.inputNames[0]); EXPECT_ZSTREQ("Tes", g_model.telemetrySensors[0].label);