[Companion] Code refactoring

This commit is contained in:
Bertrand Songis
2016-11-21 22:15:52 +01:00
parent 03bb622456
commit a3bff8cf61
+39 -56
View File
@@ -280,69 +280,52 @@ void ModelsListWidget::focusOutEvent ( QFocusEvent * event )
void ModelsListWidget::refreshList() void ModelsListWidget::refreshList()
{ {
clear(); clear();
int msize; addItem(tr("General Settings"));
div_t divresult;
addItem(tr("General Settings"));
EEPROMInterface *eepromInterface = GetEepromInterface(); EEPROMInterface * eepromInterface = GetEepromInterface();
int availableEEpromSize = eepromInterface->getEEpromSize()-64; //let's consider fat BoardEnum board = eepromInterface->getBoard();
divresult=div(eepromInterface->getSize(radioData->generalSettings),15);
divresult.quot+=(divresult.rem!=0 ? 1:0);
availableEEpromSize -= divresult.quot*16;
for(uint8_t i=0; i<GetEepromInterface()->getMaxModels(); i++) // TODO here we calculate the size used by the RLE format, this is clearly not the right place to do that...
{ int availableEEpromSize = eepromInterface->getEEpromSize() - 64; // let's consider fat
QString item = QString().sprintf("%02d: ", i+1); div_t divresult = div(eepromInterface->getSize(radioData->generalSettings), 15);
divresult.quot += (divresult.rem != 0 ? 1 : 0);
availableEEpromSize -= divresult.quot*16;
if (!radioData->models[i].isEmpty()) { for (uint8_t i=0; i<GetEepromInterface()->getMaxModels(); i++) {
if (eepromInterface && IS_SKY9X(eepromInterface->getBoard())) { QString item = QString().sprintf("%02d: ", i+1);
if (radioData->models[i].name[0]==0) { if (!radioData->models[i].isEmpty()) {
QString modelname="Model"; QString modelName;
modelname.append(QString().sprintf("%02d", i+1)); if (strlen(radioData->models[i].name) > 0)
item += modelname; modelName = radioData->models[i].name;
} else { else
item += radioData->models[i].name; modelName = QString().sprintf("Model%02d", i+1);
} item += modelName;
} if (!IS_SKY9X(board) && !IS_HORUS(board)) {
else { item += QString(GetCurrentFirmware()->getCapability(ModelName)-modelName.size(), ' ');
char modelname[256]; int size = eepromInterface->getSize(radioData->models[i]);
if (radioData->models[i].name[0]==0) { item += QString().sprintf("%5d", size);
sprintf(modelname, "Model%02d", i+1); divresult = div(size, 15);
} else { divresult.quot += (divresult.rem != 0 ? 1 : 0);
if (IS_TARANIS(eepromInterface->getBoard())) { availableEEpromSize -= divresult.quot*16;
sprintf(modelname,"%12s",radioData->models[i].name); if (i == radioData->generalSettings.currModel) {
} else { // TODO why?
sprintf(modelname,"%10s",radioData->models[i].name);
}
}
if (IS_TARANIS(eepromInterface->getBoard())) {
item += QString().sprintf("%12s", modelname);
} else {
item += QString().sprintf("%10s", modelname);
}
msize = eepromInterface->getSize(radioData->models[i]);
item += QString().sprintf("%5d", msize);
divresult=div(msize,15);
divresult.quot+=(divresult.rem!=0 ? 1:0);
availableEEpromSize -= divresult.quot*16; availableEEpromSize -= divresult.quot*16;
if (i==radioData->generalSettings.currModel) {
availableEEpromSize -= divresult.quot*16;
}
} }
} }
addItem(item);
}
if (radioData->generalSettings.currModel < (unsigned int)GetEepromInterface()->getMaxModels()) {
QFont f = QFont("Courier New", 12);
f.setBold(true);
this->item(radioData->generalSettings.currModel+1)->setFont(f);
} }
addItem(item);
}
if (eepromInterface && !IS_SKY9X(eepromInterface->getBoard())) { if (radioData->generalSettings.currModel < (unsigned int)eepromInterface->getMaxModels()) {
((MdiChild*)parent())->setEEpromAvail((availableEEpromSize/16)*15); QFont f = QFont("Courier New", 12);
} f.setBold(true);
this->item(radioData->generalSettings.currModel+1)->setFont(f);
}
if (!IS_SKY9X(board) && !IS_HORUS(board)) {
((MdiChild*)parent())->setEEpromAvail((availableEEpromSize/16)*15);
}
} }
void ModelsListWidget::cut() void ModelsListWidget::cut()