From a7e97d1485b70b96c18f7e853120562546fbac95 Mon Sep 17 00:00:00 2001
From: philmoz <philmoz@users.noreply.github.com>
Date: Fri, 14 Aug 2026 14:20:00 +1000
Subject: [PATCH] chore(color): remove redundant calls to getValue() in Value
 widget (#7652)

---
 radio/src/gui/colorlcd/widgets/value.cpp | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/radio/src/gui/colorlcd/widgets/value.cpp b/radio/src/gui/colorlcd/widgets/value.cpp
index 00c3222ed..a913787f2 100644
--- a/radio/src/gui/colorlcd/widgets/value.cpp
+++ b/radio/src/gui/colorlcd/widgets/value.cpp
@@ -135,13 +135,12 @@ class ValueWidget : public Widget
       // Set value text
       if (field == MIXSRC_TX_VOLTAGE) {
         valueTxt =
-            getSourceCustomValueString(field, getValue(field), valueFlags);
+            getSourceCustomValueString(field, newValue, valueFlags);
         valueTxt += STR_V;
       } else if (field == MIXSRC_TX_TIME) {
-        int32_t tme = getValue(MIXSRC_TX_TIME);
         TimerOptions timerOptions;
         timerOptions.options = SHOW_TIME;
-        valueTxt = getTimerString(tme, timerOptions);
+        valueTxt = getTimerString(newValue, timerOptions);
       } else if (field >= MIXSRC_FIRST_TIMER && field <= MIXSRC_LAST_TIMER) {
         TimerState& timerState = timersStates[field - MIXSRC_FIRST_TIMER];
         TimerOptions timerOptions;
@@ -151,16 +150,16 @@ class ValueWidget : public Widget
         std::string getSensorCustomValue(uint8_t sensor, int32_t value,
                                          LcdFlags flags);
         valueTxt = getSensorCustomValue((field - MIXSRC_FIRST_TELEM) / 3,
-                                        getValue(field), valueFlags);
+                                        newValue, valueFlags);
 #if defined(LUA_INPUTS)
       }
       else if (field >= MIXSRC_FIRST_LUA && field <= MIXSRC_LAST_LUA) {
         valueTxt =
-            getSourceCustomValueString(field, calcRESXto1000(getValue(field)), valueFlags | PREC1);
+            getSourceCustomValueString(field, calcRESXto1000(newValue), valueFlags | PREC1);
 #endif
       } else {
         valueTxt =
-            getSourceCustomValueString(field, getValue(field), valueFlags);
+            getSourceCustomValueString(field, newValue, valueFlags);
       }
 
       lv_label_set_text(value, valueTxt.c_str());