fix(color): Deleting empty label caused EM/Hang (#2392)

* If deleting a label, don't check size

* If rename to blank, do nothing
This commit is contained in:
Cliff
2022-09-28 18:19:59 +10:00
committed by GitHub
parent 6fd69f8053
commit ac091b779d
2 changed files with 20 additions and 14 deletions
+11 -9
View File
@@ -776,15 +776,17 @@ void ModelLabelsWindow::buildBody(FormWindow *window)
strncpy(tmpLabel, oldLabel.c_str(), LABEL_LENGTH);
tmpLabel[LABEL_LENGTH] = '\0';
new LabelDialog(this, tmpLabel, [=](std::string newLabel) {
auto rndialog =
new ProgressDialog(this, STR_RENAME_LABEL, [=]() {});
modelslabels.renameLabel(
oldLabel, newLabel, [=](const char *name, int percentage) {
rndialog->updateProgress(name, percentage);
});
auto labels = getLabels();
lblselector->setNames(labels);
updateFilteredLabels(modelslabels.filteredLabels(), false);
if(newLabel.size() > 0) {
auto rndialog =
new ProgressDialog(this, STR_RENAME_LABEL, [=]() {});
modelslabels.renameLabel(
oldLabel, newLabel, [=](const char *name, int percentage) {
rndialog->updateProgress(name, percentage);
});
auto labels = getLabels();
lblselector->setNames(labels);
updateFilteredLabels(modelslabels.filteredLabels(), false);
}
});
return 0;
});