feat(cpn): iFlight Commando8 support (#2244)

* feat(cpn): Initial iFlight Commando8 support

* fix: Commando8 doesn't have trainer port

* feat: Add Simulator for iFlight Commando8
Also some minor code re-order for BetaFPV LR3PRO

* chore: EEPROM_VARIANT not used

* chore: Remove EEPROM bits that don't seem needed

* fix: Build simulator plugin

* fix: Simulator PGUP/PGDN the right way around

* fix: Keep trainer mode in cpn for MPM, etc

radio/src/gui/gui_common.cpp

@@ -882,7 +882,7 @@ bool isTrainerModeAvailable(int mode)
   )
     return false;
 
-#if defined(PCBXLITE) && !defined(PCBXLITES)
+#if (defined(PCBXLITE) && !defined(PCBXLITES)) || defined(RADIO_COMMANDO8)
   if (mode == TRAINER_MODE_MASTER_TRAINER_JACK || mode == TRAINER_MODE_SLAVE)
     return false;
 #endif

radio/src/storage/conversions/CMakeLists.txt

@@ -1,7 +1,7 @@
 set(STORAGE_CONVERSIONS 219)
 
 if(PCB STREQUAL X7)
-  if(PCBREV STREQUAL ZORRO OR PCBREV STREQUAL TPRO OR PCBREV STREQUAL TX12MK2 OR PCBREV STREQUAL LR3PRO)
+  if(PCBREV STREQUAL ZORRO OR PCBREV STREQUAL TPRO OR PCBREV STREQUAL TX12MK2 OR PCBREV STREQUAL LR3PRO OR PCBREV STREQUAL COMMANDO8)
     set(STORAGE_CONVERSIONS 221)
   endif()
 endif()

radio/src/targets/taranis/CMakeLists.txt

@@ -300,7 +300,6 @@ elseif(PCB STREQUAL X7)
     add_definitions(-DRADIO_COMMANDO8)
     add_definitions(-DSTICKS_PWM)
     add_definitions(-DMUTUALLY_EXCLUSIVE_MODULES)
-    add_definitions(-DEEPROM_VARIANT=0x4008)
     add_definitions(-DMANUFACTURER_IFLIGHT)
   elseif(PCBREV STREQUAL ACCESS)
     set(DEFAULT_INTERNAL_MODULE ISRM_PXX2 CACHE STRING "Default internal module")