From bd89b01370bfd4cfb8eb8f35bc5931586cab2b14 Mon Sep 17 00:00:00 2001 From: Michael Date: Thu, 8 Jun 2023 07:39:05 +0200 Subject: [PATCH] fix: HoTT telemetry GPS latitude sign may be wrong in certain circumstances (#3649) * evaluate every N/S hemisphere latitude position for setting sign in decimal GPS coordinates * explicit struct init --- radio/src/telemetry/hott.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/radio/src/telemetry/hott.cpp b/radio/src/telemetry/hott.cpp index ddd5265c8..1c0ab8785 100644 --- a/radio/src/telemetry/hott.cpp +++ b/radio/src/telemetry/hott.cpp @@ -453,7 +453,7 @@ void processHottPacket(const uint8_t * packet) const HottSensor *sensor; int32_t value; static uint8_t prev_page = 0, prev_value = 0; - static HottGPSMinutes min = {}; + static HottGPSMinutes min = { 0, 0, 0 }; int16_t deg = 0, sec = 0; // Set RX Event (HoTT warnings) @@ -557,9 +557,7 @@ void processHottPacket(const uint8_t * packet) // GPS latitude min.value = (int16_t) (packet[11] + (packet[12] << 8)); - if (packet[10] == 1) { - min.isNegative = true; - } + min.isNegative = (packet[10] == 1); break; case HOTT_PAGE_02: