From bff28a6c2814daff052cfc3a28af268e99438461 Mon Sep 17 00:00:00 2001
From: Bertrand Songis <bsongis@gmail.com>
Date: Thu, 23 Jan 2014 07:23:26 +0100
Subject: [PATCH 1/6] [9x stock] Issue #542 -  8 bytes here

---
 radio/src/opentx.cpp | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/radio/src/opentx.cpp b/radio/src/opentx.cpp
index ee634a7d2..aa63566aa 100644
--- a/radio/src/opentx.cpp
+++ b/radio/src/opentx.cpp
@@ -3416,6 +3416,7 @@ void perOut(uint8_t mode, uint8_t tick10ms)
 
       //========== VALUE ===============
       uint8_t stickIndex = md->srcRaw - MIXSRC_Rud;
+      #define MIX_SRCRAW (stickIndex + MIXSRC_Rud)
       getvalue_t v = 0;
       if (mode > e_perout_mode_inactive_phase) {
         if (!mixEnabled || stickIndex >= NUM_STICKS || (stickIndex == THR_STICK && g_model.thrTrim)) {
@@ -3433,12 +3434,12 @@ void perOut(uint8_t mode, uint8_t tick10ms)
         else
 #endif
         {
-          v = getValue(md->srcRaw);
-          if (md->srcRaw>=MIXSRC_CH1 && md->srcRaw<=MIXSRC_LAST_CH && md->destCh != md->srcRaw-MIXSRC_CH1) {
-            if (dirtyChannels & ((bitfield_channels_t)1 << (md->srcRaw-MIXSRC_CH1)) & (passDirtyChannels|~(((bitfield_channels_t) 1 << md->destCh)-1)))
+          v = getValue(MIX_SRCRAW);
+          if (MIX_SRCRAW>=MIXSRC_CH1 && MIX_SRCRAW<=MIXSRC_LAST_CH && md->destCh != MIX_SRCRAW-MIXSRC_CH1) {
+            if (dirtyChannels & ((bitfield_channels_t)1 << (MIX_SRCRAW-MIXSRC_CH1)) & (passDirtyChannels|~(((bitfield_channels_t) 1 << md->destCh)-1)))
               passDirtyChannels |= (bitfield_channels_t) 1 << md->destCh;
-            if (md->srcRaw-MIXSRC_CH1 < md->destCh || pass > 0)
-              v = chans[md->srcRaw-MIXSRC_CH1] >> 8;
+            if (MIX_SRCRAW-MIXSRC_CH1 < md->destCh || pass > 0)
+              v = chans[MIX_SRCRAW-MIXSRC_CH1] >> 8;
           }
         }
         if (!mixCondition) {

From 93646983b53c3d9d1c7dcb0c8ca5edf18e8a7261 Mon Sep 17 00:00:00 2001
From: Bertrand Songis <bsongis@gmail.com>
Date: Thu, 23 Jan 2014 10:27:00 +0100
Subject: [PATCH 2/6] [9x stock] Issue #542 - 2 bytes here

---
 radio/src/opentx.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/radio/src/opentx.cpp b/radio/src/opentx.cpp
index aa63566aa..b4900f8d1 100644
--- a/radio/src/opentx.cpp
+++ b/radio/src/opentx.cpp
@@ -3403,6 +3403,9 @@ void perOut(uint8_t mode, uint8_t tick10ms)
 
       if (md->srcRaw == 0) break;
 
+      uint8_t stickIndex = md->srcRaw - MIXSRC_Rud;
+      #define MIX_SRCRAW (stickIndex + MIXSRC_Rud)
+
       if (!(dirtyChannels & ((bitfield_channels_t)1 << md->destCh))) continue;
 
       // if this is the first calculation for the destination channel, initialize it with 0 (otherwise would be random)
@@ -3415,8 +3418,6 @@ void perOut(uint8_t mode, uint8_t tick10ms)
       delayval_t mixEnabled = !(md->phases & (1 << s_perout_flight_phase)) && getSwitch(md->swtch);
 
       //========== VALUE ===============
-      uint8_t stickIndex = md->srcRaw - MIXSRC_Rud;
-      #define MIX_SRCRAW (stickIndex + MIXSRC_Rud)
       getvalue_t v = 0;
       if (mode > e_perout_mode_inactive_phase) {
         if (!mixEnabled || stickIndex >= NUM_STICKS || (stickIndex == THR_STICK && g_model.thrTrim)) {

From 1c59184583b3022ba5e1e2a0eb7e18db33c0e1a5 Mon Sep 17 00:00:00 2001
From: Bertrand Songis <bsongis@gmail.com>
Date: Thu, 23 Jan 2014 11:07:47 +0100
Subject: [PATCH 3/6] [9x stock] Issue #542 - 4 bytes here

---
 radio/src/gui/menu_model.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/radio/src/gui/menu_model.cpp b/radio/src/gui/menu_model.cpp
index d1f9889fb..325dca789 100644
--- a/radio/src/gui/menu_model.cpp
+++ b/radio/src/gui/menu_model.cpp
@@ -3746,7 +3746,7 @@ enum LimitsItems {
   #undef MIN_MAX_ATTR
   #define MIN_MAX_ATTR          attr
 #else
-  #define MIN_MAX_DISPLAY(x)    (x)
+  #define MIN_MAX_DISPLAY(x)    ((int8_t)(x))
 #endif
 
 #if defined(PCBTARANIS)

From 8a32e769dc70b558d97730c10077550dd35b5651 Mon Sep 17 00:00:00 2001
From: Bertrand Songis <bsongis@gmail.com>
Date: Thu, 23 Jan 2014 11:49:13 +0100
Subject: [PATCH 4/6] [9x stock] Issue #542 - 12 bytes here

---
 radio/src/opentx.cpp    |  7 +++++++
 radio/src/templates.cpp | 11 +++++++----
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/radio/src/opentx.cpp b/radio/src/opentx.cpp
index b4900f8d1..a126db79d 100644
--- a/radio/src/opentx.cpp
+++ b/radio/src/opentx.cpp
@@ -509,6 +509,12 @@ uint16_t evalChkSum()
   return sum;
 }
 
+#if defined(TEMPLATES)
+inline void applyDefaultTemplate()
+{
+  applyTemplate(TMPL_SIMPLE_4CH);
+}
+#else
 void applyDefaultTemplate()
 {
   for (int i=0; i<NUM_STICKS; i++) {
@@ -539,6 +545,7 @@ void applyDefaultTemplate()
   }
   eeDirty(EE_MODEL);
 }
+#endif
 
 #if defined(PXX) && defined(CPUARM)
 void checkModelIdUnique(uint8_t id)
diff --git a/radio/src/templates.cpp b/radio/src/templates.cpp
index e5b10dad1..a4cd243a5 100644
--- a/radio/src/templates.cpp
+++ b/radio/src/templates.cpp
@@ -178,7 +178,13 @@ void applyTemplate(uint8_t idx)
       // Simple 4-Ch
       case TMPL_SIMPLE_4CH:
         clearInputs();
-        applyDefaultTemplate();
+#if defined(PCBTARANIS)
+  #pragma message("Templates with virtual inputs (FrSky Taranis) are not implemented!")
+#endif
+        setDest(ICC(STK_RUD), MIXSRC_Rud);
+        setDest(ICC(STK_ELE), MIXSRC_Ele);
+        setDest(ICC(STK_THR), MIXSRC_Thr);
+        setDest(ICC(STK_AIL), MIXSRC_Ail);
         break;
 
       // Sticky-T-Cut
@@ -203,9 +209,6 @@ void applyTemplate(uint8_t idx)
       // Elevon\\Delta
       case TMPL_ELEVON_DELTA:
         defaultInputs();
-#if defined(PCBTARANIS)
- #pragma message("Templates below are not implemented (only V-TAIL has been done). Feel free to help!")
-#endif
         setDest(ICC(STK_ELE), MIXSRC_Ele, true);
         setDest(ICC(STK_ELE), MIXSRC_Ail);
         setDest(ICC(STK_AIL), MIXSRC_Ele, true);

From c1453cc6cb2974d0608e0f929fb517c534706b3b Mon Sep 17 00:00:00 2001
From: Bertrand Songis <bsongis@gmail.com>
Date: Thu, 23 Jan 2014 14:49:19 +0100
Subject: [PATCH 5/6] Google tests re-enabled

---
 radio/src/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/radio/src/Makefile b/radio/src/Makefile
index 0fba8ef16..2c9ddc635 100644
--- a/radio/src/Makefile
+++ b/radio/src/Makefile
@@ -1363,11 +1363,11 @@ GTEST_SRCS_ = $(GTEST_DIR)/src/*.cc $(GTEST_DIR)/src/*.h $(GTEST_HEADERS)
 # conservative and not optimized.  This is fine as Google Test
 # compiles fast and for ordinary users its source rarely changes.
 gtest-all.o : $(GTEST_SRCS_)
-	$(CXX) $(CPPFLAGS) -I$(GTEST_DIR) -c \
+	$(CXX) $(CPPFLAGS) -I$(GTEST_DIR) -I$(GTEST_DIR)/include -c \
             $(GTEST_DIR)/src/gtest-all.cc
 
 gtest_main.o : $(GTEST_SRCS_)
-	$(CXX) $(CPPFLAGS) -I$(GTEST_DIR) -c \
+	$(CXX) $(CPPFLAGS) -I$(GTEST_DIR) -I$(GTEST_DIR)/include -c \
             $(GTEST_DIR)/src/gtest_main.cc
 
 gtest.a : gtest-all.o
@@ -1381,4 +1381,4 @@ gtest_main.a : gtest-all.o gtest_main.o
 # function.
 
 gtests: $(BOARDSRC) $(CPPSRC) gtests.cpp simpgmspace.cpp *.h gtest_main.a
-	g++ -std=gnu++0x $(CPPFLAGS) $(BOARDSRC) $(CPPSRC) gtests.cpp simpgmspace.cpp -I$(GTEST_DIR) -o gtests -lpthread -MD -DSIMU gtest_main.a 
+	g++ -std=gnu++0x $(CPPFLAGS) $(BOARDSRC) $(CPPSRC) gtests.cpp simpgmspace.cpp -I$(GTEST_DIR) ${INCFLAGS} -I$(GTEST_DIR)/include -o gtests -lpthread -MD -DSIMU gtest_main.a 

From f6ba7e26b7cd156c67408706e3876d6614294039 Mon Sep 17 00:00:00 2001
From: Bertrand Songis <bsongis@gmail.com>
Date: Thu, 23 Jan 2014 15:00:09 +0100
Subject: [PATCH 6/6] [9x stock] Issue #542 - 8 bytes here

---
 radio/src/opentx.cpp | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/radio/src/opentx.cpp b/radio/src/opentx.cpp
index a126db79d..4f2b04e0c 100644
--- a/radio/src/opentx.cpp
+++ b/radio/src/opentx.cpp
@@ -3411,7 +3411,6 @@ void perOut(uint8_t mode, uint8_t tick10ms)
       if (md->srcRaw == 0) break;
 
       uint8_t stickIndex = md->srcRaw - MIXSRC_Rud;
-      #define MIX_SRCRAW (stickIndex + MIXSRC_Rud)
 
       if (!(dirtyChannels & ((bitfield_channels_t)1 << md->destCh))) continue;
 
@@ -3442,12 +3441,14 @@ void perOut(uint8_t mode, uint8_t tick10ms)
         else
 #endif
         {
-          v = getValue(MIX_SRCRAW);
-          if (MIX_SRCRAW>=MIXSRC_CH1 && MIX_SRCRAW<=MIXSRC_LAST_CH && md->destCh != MIX_SRCRAW-MIXSRC_CH1) {
-            if (dirtyChannels & ((bitfield_channels_t)1 << (MIX_SRCRAW-MIXSRC_CH1)) & (passDirtyChannels|~(((bitfield_channels_t) 1 << md->destCh)-1)))
+          int8_t srcRaw = MIXSRC_Rud + stickIndex;
+          v = getValue(srcRaw);
+          srcRaw -= MIXSRC_CH1;
+          if (srcRaw>=0 && srcRaw<=MIXSRC_LAST_CH-MIXSRC_CH1 && md->destCh != srcRaw) {
+            if (dirtyChannels & ((bitfield_channels_t)1 << srcRaw) & (passDirtyChannels|~(((bitfield_channels_t) 1 << md->destCh)-1)))
               passDirtyChannels |= (bitfield_channels_t) 1 << md->destCh;
-            if (MIX_SRCRAW-MIXSRC_CH1 < md->destCh || pass > 0)
-              v = chans[MIX_SRCRAW-MIXSRC_CH1] >> 8;
+            if (srcRaw < md->destCh || pass > 0)
+              v = chans[srcRaw] >> 8;
           }
         }
         if (!mixCondition) {