From c8f01850e77de1fdc49b058f145d8cb765e38890 Mon Sep 17 00:00:00 2001 From: philmoz Date: Fri, 17 Nov 2023 16:16:25 +1100 Subject: [PATCH] fix(color): New input popup not showing all empty inputs (#4330) --- radio/src/gui/colorlcd/model_inputs.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/radio/src/gui/colorlcd/model_inputs.cpp b/radio/src/gui/colorlcd/model_inputs.cpp index a8df82ba1..694fcce15 100644 --- a/radio/src/gui/colorlcd/model_inputs.cpp +++ b/radio/src/gui/colorlcd/model_inputs.cpp @@ -364,14 +364,15 @@ void ModelInputsPage::newInput() // search for unused channels for (uint8_t i = 0; i < MAX_EXPOS && chn < MAX_INPUTS; i++) { if (!EXPO_VALID(line) || (line->chn > chn)) { - std::string name(getSourceString(chn + 1)); - menu->addLineBuffered(name.c_str(), [=]() { insertInput(chn, index); }); + uint8_t chnEnd = EXPO_VALID(line) ? line->chn : chn + 1; + for (; chn < chnEnd; chn += 1) { + std::string name(getSourceString(chn + 1)); + menu->addLineBuffered(name.c_str(), [=]() { insertInput(chn, index); }); + } } if (EXPO_VALID(line)) { chn = line->chn + 1; index += 1; - } else { - chn += 1; } ++line; }