* chores(flysky): separate AFHDS2A and AFHDS3 into 2 different module type
This should allow to remove some of the hacks added earlier.
* chore: Add some EL18 CI bits
* fix(afhds): cmake defs
* fix(ci): add el18 to commit-tests.sh
* chore(cpn): separate AFHDS2A and AFHDS3
* chore(cpn): remove binary import of afhds and legacy fxFreq field for afhds3
* fix(cpn): limit available internal afhds protocols to those supported by hardware
* chore(cpn): update Flysky int module test
* fix(cpn): compile error
* fix(cpn): afhds2a max channels
* fix: TR_MODULE_PROTOCOLS
* enh(cpn): more support for afhds2a and 3
* fix(cpn): rebase compile error
* fix(cpn): bit indexes
* fix(cpn): emi toString
* fix(cpn): limit available internal afhds protocols to those supported by hardware
* enh(cpn): add support for Flysky EL18
* fix(cpn): available protocols
* fix(cpn): rebase moduledata
* chore(cpn): add module fields to model print
* Separate AFHDS2A and AFHDS3 UI settings.
* Fix AFHDS3 conversion from old subtype value.
Fix 'Channel Range' layout on portrait LCD.
* Fix name.
---------
Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
Co-authored-by: elecpower <neilh713@tpg.com.au>
Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
* initial version of clickable checklist
* do not display checkboxes for empty lines if checklist is shorter than screen size
* remove checklist exit after completing it
cannot exit menu from menuTextView as level above there is while loop that cannot be stopped from thic place in code
* menu entry to enable and disable interactive checklist
* only when complete interactive checklist is closed
* config updated & not display checkboxes when entered from "View Notes"
* add setup entry for colorlcd
* do not make interactive checkist when loaded from menu
* fix datastruct size after merge
* Companion support for interactive checklist
* mark checklist lines as non-checkable with '=' for B&W radios
* Process only items visible on screen
This is also crucial when it comes to analyse non-checkable items on a checklist, as in this way there is no need to load non-visible items from SD-card
* WIP fix merge problems
* update yaml datastructs
* restore most functionalities for interactive check lists on color LCD radios
currently no automatic line wrapping and you can always exit the checklist, even when it is not fully done
* finalise interactive checklists for color LCD
* fix: rebase/merge issues
* fix: model setup checklist section
* fix: fix 212 model setup
* Re-work of the some of the color lcd checklist code (#3787)
* Move checklist logic to sub-class.
Show model name instead of file name in title, show 'Preflight checks' in title2 for checklist.
Handle long line wrapping of text.
Don't indent lines without checkbox.
Add 'RTN' button when done.
* Code cleanup.
* Simplify code by storing a list of checkboxes instead of scanning LVGL object hierarchy.
* Indent checkboxes to make touch activation easier.
Keep 'RTN' button visible so last checkbox is further from bottom of screen (for touch activation).
'RTN' button is disabled until checklist complete.
* Add checkbox class constructor for preflight checks.
* Fix checkbox size.
---------
Co-authored-by: Piotr Rzeszut <piotrrze@gmail.com>
Co-authored-by: 3djc <lesitewebdejc@hotmail.com>
Co-authored-by: philmoz <philmoz@users.noreply.github.com>
Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
* disable timers with mode OFF
* fix isModeOff to reference mode not switch
* update model edit source lists when timer mode changed
* add timer mode test to reset function
* add timer mode test for Set and Reset functions
* change yaml special source TIMERx to Tmrx
(to allow aligning with firmware compile option)
* feat(cpn): External module form factor set in Radio Profile to allow aligning with firmware compile option
* Note tweak
* fixes#2552
- remove edit option rssiSource
- reset rssiOption to default (none) if carried over from OpenTX conversion
* deleted rssiSource functional code Companion, simulator and radio
* forgot one commented line
* Add options to disable radio and model menu tabs.
- Update radio and model data structs
- UI for color LCD radios
- Convert existing 'noGlobalFunctions' property.
- Language strings.
* Make 'theme' control specific to color LCD radios.
* Add B&W radio UI.
* Simplify code, reduce compiled code size.
Fix page count display on model select tab.
Fix GVARS for 212x64 radios.
* Collapse timer sections if timer is off.
* Remove 'Use global functions' checkbox from B&W model setup.
* Make preflight checks, throttle and view options sections expand & collapse (default collapsed).
* Fix build.
* Add view options to companion data classes, save and load values in YAML files.
Fix scrolling for radio setup view options.
* Add Companion UI for view option settings.
* Remove 'Mixes' from list of tabs that can be hidden.
* Updated Companion UI from elecpower.
* Use view options flags to enable/disable functionality:
- skip heli mixer logic if heli not enabled
- Remove heli, gvars and telemetry options from source selection if not enabled
* Remove 'flight mode', 'curve' and 'global variable' settings from input & mix editors if option disabled.
* Rename 'View Options' to 'Enabled Features'.
Put GVAR option under Flight Mode and indent text.
Make relationship between FM and GV more obvious.
* Remove global variable option dependency on flight modes.
Hide FM1-FM8 in global variables if flight modes hidden.
* Hide 'Custom Mixer Scripts' in source selection menu popup if disabled.
* Add translation strings for Hebrew language file.
* Fix typo. Add comment for double call to setCurrentTab.
* - Concentrated Multi protocol definitions into a consistent single source. Actually two .h files, one for the protocol list and names, the other for subtypes and capababilites, see comments in .h files as to why
- updated available protocols reflecting 1.3.3.20 (15+ protocols)
- fixed Companion always showing f/s and channel map options in model setup disregarding the protocol capability
* Following @pfeerick's review: changed heaeders and typos
fixed Ubuntu runtime error on assert
fixed change of Multi protocol not triggering writing yaml file
* corrected copy/paste error
* fixed FrSky index juggling
* Updated Multiprotocol database to current MPM project status (ref. MPM Multiprotos.ino)
- changed protocol name FX816 to FX
- added Flysky AFHDS2A options PPM and PPWM SBUS 16ch subtypes "PWM,SB16" and "PPM,SB16
- added V761 option to select TOPRC
- added FX options "816" and "620"
- added FRSKYR9 option "-- 8ch"
* MPM protocol scan excludes some protocols which are not meant to be selected. For Companion and Simualtor (and for radios if there is no MPM connected) this was handled in different places with outdated information. Harmonized and centralized the handling of non-selectabale protocols into the single source for all companion, Simulator and all gui types.
* More cleanup:
- changed some MPM protocol names to the ones the MPM delivers with MPM protocol scan to harmonize names between CPN/Simulator/radio
- added XN2927DUMP and MOULDKG to the list of excluded MPM protocols just like the MPM does with MPM protocol scan
- added new option value limits and moved definitions to single source
- adapted CPN and radio to use common definitions of option values for all GUI types
- moved distributed MPM (as far as possible) to one coherent place under a single #if defined (MULTIMODULE)
- fixed option value not reset at change of protocol
- some editorial stuff
Note: There is still some work to be done on CPN GUI option values. DSM2 servo rates are hard coded, BAYANG telemetry options are only shown by index and not by text as in radio code, AFHDS2A servo update rate is shown as index too which is to no use for users.
I'll try to fix all this in the next session, but request to get rid of BAYANG telemetry options translations. It is much easier to define a common string list by using untranslated.h
* rebase due to fr.h
* resolve merge conflict with main fr.h
* more cleanup:
- deleted multiple definition of MM_RF_CUSTOM_SELECTED in favor of single source define
- bw radios: change to only allow defined protocols rather than a fixed 127 protocols
* Changes:
- magic sentinel number 0xfe as define
- add 10 NN protocol entries for future use of new MPM protocols not yet defined in ETX (still recommend timely ETX maintenance update if MPM releases new firmware)
* Changes by @elecpower:
- align field labels to radio
- change servo update frequency from combo box to spin box with edit only via up/down arrows to stop invalid values being entered via keyboard. Remove frequency list used to populate combo box as only used by Companion.
- add validation to module yaml decode checking for unsupported multi protocols and/or multi protocol sub types and if unsupported set module to OFF just to be safe.
* Changes:
- radio: added validation to module yaml decode checking for unsupported multi protocols and/or multi protocol sub types and if unsupported set module to OFF just to be safe.
* CPN: use sentinel define
* cpn: Sort multi protocols list (courtesy @elecpower)
* fixes#3480
changes:
- moved FrSky subtype defines to MultiProtoDefs.h
- updated bind_button_driver.cpp
* missed replacing one instance of setMultiProtocol()
* changes:
- editorial change
- added multi option to OMP protocol (ref #2713)
* rather go for STR_MULTI_RFTUNE because MPM manual talks about RF tune
* made XN297_DUMP selectable (available with MPM debug fw only)
* corrected merge mistakes
* introducing external MLink module telemetry as module PPM subtype
* implemented fix for sensor discovery display not showing all detected sensors (is in separate PR too)
implemented PPM subtypes in Companion
* add PPM subtype to model printer
finalize subtypes for PPM in Companion
* added logic to try to use HW UART with inverters turned off first (e.g. NV14), then, if not successfull use soft serial inverted (== uninverted data due to HW inverters on PCB)
changed start bit detection IRQ priority from 5 to the previous 0 (also in separate PR)
* extended telemetry timeout to 2s due to slow Mlink RSSI update rate
* changed the "NOTLM" sub-type texts to:
- "No Telem" for 128x64 (this is the max numbers of characters it can take)
- "No Telemetry" everything else including Companion
* Companion:
- lower case 1st charachter on PpmSubTypeStrings to ppmSubTypeStrings
- added telemetry hooks for ppmSubTypeStrings stringx
* simplified serial port initialization for MLink telemetry
* editorial change: corrected obsolete comment
* Add 'Show Instance ID' button to telemetry page to show/hide sensor instance number (default is hidden).
Fix issues with page refresh when all sensors deleted.
Select closest sensor when a single sensor is deleted.
On change, only refresh the sensor list instead of the whole page.
The 'showInstanceIds' property is saved to the model file.
Update Companion to save/load 'showInstanceIds' in model YAML file. Add checkbox to telemetry edit page.
* Update all radio specific files.
* Keep focus on 'Discover/Stop' button when searching for new sensors.
Start sensor ID index at 1 to match B&W radios.
Keep focus on changed parameter when editing sensor, don't rebuild entire parameter list on change.
* Display actual 'instance' ID instead of 'instance' + 1.
* Fix incorrect ID when reloading simulator data.
* Fix incorrect ID when reloading simulator data on B&W radios.
* Add support for the '1x' repeat option for 'Play Script' special functions.
* Add Companion and B&W radio support.
* Fix B&W radio logic and layout.
* Add translation hooks.
* Allow switches on the connected radio to control switches in the simulator via the joystick interface.
* Merge configurable radio joystick interface from banyaszg.
* Add two more 'axis' channels to companion.
* Fix 6POS from USB joystick to simulator.
* Reduce data size.
* Fix build error on B&W radios.
* Add 'Companion' button mode to work with the button logic in the Companion app.
* Build Companion joystick setup layout at runtime.
Change #define names for simulator joystick.
Allow 15 axes and 32 buttons.
Initial support for trim sliders.
* Remove custom joystick button type for companion - use 3 buttons per switch in companion to control simulator switch state.
* Fix joystick constructor calls parameters. Connect some radio joystick trims to simulator widgets.
* Restore 'companion' button type to reduce number of buttons needed. Make trims work via buttons in USB joystick.
* Connect joystick trim buttons to simulator widgets.
* Use companion source names for trims.
* Add encode / decode of usb joystick custom settings to Companion.
* Convert to lvgl layouts.
Update language files.
* Fix generated YAML storage files.
* Fix initialisation error when editing button channel. Cleanup code.
* Fix rebase.
* Fix refresh of joystick channel list view after editing an entry.
Companion joystick config window uses two columns.
* Fix vertical joystick inversion bug.
Change stick axis labels.
---------
Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
* feat: Remove TR# mixsrc when trainer disabled
When trainer mode is not enabled, there is no point
showing the TR# mixer sources. Once you enable a
trainer option, they will become visible again.
* fix: Add missing "Input" check for B&W radios
* fix(cpn): Trainer mode default is off
* chore(cpn): If trainer mode off, hide TR/PPM srcs
* (cpn) Refresh all source lists on change of trainer mode
Co-authored-by: elecpower <neilh713@tpg.com.au>
* Corrected spelling mistake for TR_MOVE_UP
* New label-related items in MdiChild
* Added three not previously translated items
* Minor change
* Minor tweaks
* One minor spelling mistake fixed ("imgage" to "image")
Might cause some confusion for translators (did for me) but the text is probably is never displayed so perhaps doesn't really matter. Now fixed anyways.
* One misplaced bracket (causing build errors) removed
* A few additional improvements
* One minor change for "Menu laguage" translation
* Spelling error corrected
* Special Function to set main screen (#2135)
* chore: Add new SF to LUA constants list
* Companion support
* Formatting
* get rid of magic number
* Add function to get the number of custom screens
* Change screen numbering from 0-based to 1-based.
* Allow SetScreen custom function for Color LCD only
* add range protection
* cleanup
* yet, range protection once again
* fix: paintSpecialFunctionLine can't alter SF param data
* Fix screen initialization in companion
* move screen switching to the UI
* Trigger view change from guiMain()
* chore: Change "SET" to "Set" for consistency
* fix: Somehow missed extra comma in `TW`
Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
Co-authored-by: elecpower <neilh713@tpg.com.au>
Co-authored-by: Raphael Coeffic <raphael.coeffic@frafos.com>
* timer direction: ellapsed or left
* Add AUDIO announcement support
* Storage for showElapsed
* Translations
* Fix storage
* BW implementation
* Different BW implementation
* Companion support
* Color LCD implementation and rebase to lvgl
* Fix problems found by raphaelcoeffic
* chore: Regenerate the YAML files properly
* fix: Remove unused `TR_SHOW` remnant
* chore: Formatting and cleanup
* fix: Timer dir choice was shown in wrong place
Wrong newline used in ce23b50
* Fix cpn ui triggers, remove unnecessary code and some formatting
* fix(colorlcd): Hide timer dir opt if zero value
Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
Co-authored-by: elecpower <neilh713@tpg.com.au>
- fix Companion yaml model read and write
- B&W radios treat bit values the same as color to avoid unnecessary complication for Companion and radio conversions
- B&W radios default is therefore off for all pots and sliders
- B&W radios fix runtime warnings check
- all radios fix to save last pot or slider position when checked and mode AUTO on change of model or power off
- all radios do not display Pots Warning in model setup if no pots or sliders supported
