Commit Graph
9663 Commits
Author SHA1 Message Date
c3c8a2e3f1 feat: Model level ADC Jitter filter option (#1363)
* ADC Filter - On/off state configurable at the model level

* Updated YAML configuration to match change from ADC Filter feature commit

* Companion changes to support ADC jitter filter to be a model configuration item.

* Renamed jitterFilter field to noJitterFilter.

This better describes the semantic, which is inverted.

* Updated after review

* Re-run generate-yaml

* Changed ADC Jitter filter control on Model to be tri state.
Off, On or use the radio setting

* Adde NOBACKUP() to the added field

* Re-generate yaml_datastructs

* Making the default state to use radio setting/Global value

* Updated after review:
Changing to more consistent naming across firmware and companion.

* Reverted  files that was accidently added to the commit.

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-26 20:54:23 +10:00
Raphael CoefficandPeter Feerick 641cb7f4aa F4: Remove useless additional DMA buffer 2022-01-25 19:57:36 +10:00
Peter Feerick 1eaa904217 fix: Also patch conversion for X9LiteS/XLiteS 2022-01-24 15:38:48 +10:00
Peter Feerick 95a55ae8d7 fix: Wrong datastructs used for X9LiteS and XLiteS 2022-01-24 11:09:32 +10:00
d1ef6f866c [tpro] fix function switch behaviours and add always on capability (#1479)
* fix: tpro function switch toggle mode

* feat: Function switches now have alway on option

* Companion support for function switch always on

* Fix nasty eeprom error

* Update fs startup item model

* Fix Tpro SWITCH_EXISTS

Co-authored-by: 3djc <lesitewebdejc@hotmail.com>
Co-authored-by: elecpower <neilh713@tpg.com.au>
2022-01-23 18:42:31 +10:00
Raphael CoefficandGitHub 9c075d0a01 multi: Fix TQly & TRSS sensors not being discovered (#1480)
move the TQly & TRSS hack where it belongs
2022-01-23 11:09:46 +10:00
1b66af88af [colorlcd] Warn on model change if telemetry-enabled model connected (#1467)
* Warn on connected model (#1466)

* Make it so not confirming aborts model change

* add delay before accepting disconnected telemtry

* Add power off delay

* Remove whitespace + time unit in name

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-23 10:45:20 +10:00
Raphael Coeffic a177264759 Hotfix yaml generator
Sorry @stephenaa, it's blocking normal YAML generation right now.
2022-01-22 13:11:31 +01:00
Raphael Coeffic 55689c4084 hotfix: T-pro does not have TX DMA on internal module 2022-01-21 12:38:15 +01:00
88a4458cfe fix: Resolve some issues with touch TE_SLIDE_END, and tapCount on NV14 (#1434)
* move TE_SLIDE_END handling for slide inertia to libopenui
reset tapCount on TE_SLIDE_END on NV14

* Bump libopenui

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-21 20:29:18 +10:00
Raphael CoefficandGitHub 4048983ce5 Add a "No SD card" screen on boot (#1451)
This prevents certain issues related to SD card being now mandatory to run EdgeTx.
2022-01-21 20:18:27 +10:00
eshifriandGitHub e07695f1e9 [nv14] Use Flysky range units (#1212) 2022-01-21 20:04:29 +10:00
Stephen Mose AaskovandGitHub 2593bef711 Make compilation on M1 Macs work (#1383) 2022-01-21 20:02:37 +10:00
121a1ffee5 fix: Potential out of bounds access of flightmode name on main screen (#1337)
Take 2, without the Mac Companion breakage...

* fixed incorrect use of non-terminated-fixed-string for ctor of std::string

* introduced helper

* removed commented lines

* removed constexpr since in C++11 std::string ctro isn't still constexpr

Co-authored-by: wimalopaan <wilhelm.wm.meier@googlemail.com>
2022-01-21 19:53:45 +10:00
Raphael CoefficandGitHub 0adb6315c8 Merge pull request #1469 from gagarinlg/dialogbl
force backlight on when displaying full screen dialogs
2022-01-21 07:26:36 +01:00
RistoandGitHub 60bbe52f63 feat: More analog diagnostics screens on B&W colorlcd (#1421)
* Show true unscaled and unfiltered analogs for diagnose purpose on the analog diagnose screen.
Tested on physical RM TX16S, not yet tested on B/W targets.

* Changed to decimal display also on B/W targets. Tested now with RM Zorro as well.

* 5 fps refresh rate of the raw analog values. Much nicer to look at.

* Time-changing 3 views for color radios: std., filtered raw with deviation, unfiltered raw.

* Corrected deviation view output to not use old values.

* Changed analogs diagnose page to user navigatable TabsGroup with 3 tabs.

* Added fourth analog diagnose tab to show minimum and maximum values and the range (difference between min and max).
Left touch screen and IMU output tests only on first page (should also move in the future to their respective dedicated pages).

* Use Std. JitterAlpha filtering for Deviation screen to minimize delay, omit filtering for FlySky digital hall gimbals - not necessary, the signal is stable enough.

* 2 analog diagnose pages for 128x64 B/W radios: calibrated analogs and raw values with display output limited to 5 frames-per-second due to visibility reasons.

* Added 2 analogs diagnose pages also for 212x64 display B/W radios.
I was only able to simulate it, not tested on real hardware.

* Support also radios that do not have PageUp/PageDn keys, but only Page key (e.g. X7).

* Better key handling and improved style thx to @pfeerick
2022-01-21 14:45:56 +10:00
1d7b04d679 [nv14] Make Ghost menu work with joystick trims (#1416)
* Update radio_ghost_module_config.cpp

* Update board.h

* Update keys_driver.cpp

* Auto-formatting

* Add functions simply so gtests compiles

* Update board.h

define TRIMS_EMULATE_BUTTONS to avoid HW dependent defines in other code

* Update radio_ghost_module_config.cpp

Use TRIMS_EMULATE_BUTTONS rather than PCBNV14

* `simu` code behind build flag also

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-21 14:42:13 +10:00
91d3c88421 [cleanup] Remove unused READ_FILE_BY_LINE code from colorlcd (#1456)
* remove READ_FILE_BY_LINE from colorlcd

* Whole file autoformat + more unused code removal

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-21 13:42:55 +10:00
Raphael CoefficandGitHub 0ee144dd25 Remove useless DEBUG_TASKS (not supported on FreeRTOS) (#1448) 2022-01-21 12:59:45 +10:00
gagarinlg 9fea53702a force touch screen to be on in full screen dialogs
reset backlight timeout when changing backlight settings
2022-01-20 12:40:58 +01:00
gagarinlg ea29a68f23 force backlight on when displaying full screen dialogs
fixes #1428
2022-01-18 14:06:42 +01:00
Risto adca4f0a3b Fixed Zorro battery voltage sensing
New Zorro revision uses internally 3.3V VREG and requires this change to properly sense the battery voltage. Tested on latest revision of physical Zorro.
2022-01-17 16:06:26 +01:00
Peter FeerickandGitHub dcbdde2b74 Fix warning: "EVENT_BUFFER_SIZE" redefined 2022-01-17 11:34:09 +10:00
piotrvaandGitHub e47caddeb0 fix: Force translation.py script encoding to utf-8 (#1424) 2022-01-17 11:24:53 +10:00
stefan73andGitHub 7161c83d9c [nv14] Make Outputs widget work with two column layouts (#1454)
Changed code to allow one column display of outputs already with a width of 100. This fixes the initally reported problem

Reason: On the Nirvana the screen width is 320 pixels. Thus the widget width is less than 150 pixels, if you select a two column out layout.
The rendering of the outputs looks good with a width of 100px, so there is no need for the "150" - we can start displaying from 100. Should make no difference to the radios with width 480px.
2022-01-17 11:24:20 +10:00
Jesper FrickmannandGitHub 0069bcc52f Increased Lua buffer size for standalone and telemetry scripts (#1442) 2022-01-17 10:54:08 +10:00
Jesper FrickmannandGitHub c45b3d7114 Fix: [lua] Do not ever convert name to a number with getFieldInfo(name) (#1423)
Fix for Issue #1346
2022-01-17 10:20:40 +10:00
7a628d4c15 fix: Companion read/write of failsafe settings, how displayed on radio (#1399)
* Fix failsafe settings

Resolve #1393

* trigger save if failsafe numbers changed + cleanup

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-11 23:09:55 +10:00
Raphael CoefficandGitHub 71b0e72dd0 Remove calibration check when asserting availability of 6-pos switch positions (#1368)
Thus allowing it to show on radio when calibration is invalid
2022-01-11 22:46:41 +10:00
Jesper FrickmannandGitHub cc316e5a2c fix: Wrong x-coordinate for Lua touchState during sliding on mainviews other than the first screen (#1409)
Fix for issue #1348 as discussed on https://github.com/EdgeTX/libopenui/pull/49
2022-01-11 22:44:54 +10:00
Malte LangermannandGitHub 37ee8a68f8 fix: Force a valid min "backlight on" setting on color lcd radios (#1386)
* always have aat least a 5s backlight timeout and some backlight enabled when backlightshould be on on color lcd radios

* for backlight timeout to be at least 5s on color lcd radios under all circumstances

* fix indentation

* the backlight value is inverted on color lcd radios, so the calculation was wrong

* fix typos
2022-01-11 22:44:13 +10:00
piotrvaandGitHub 192ca87afb fix: rotary encoder movement should not close throttle warning (#1408) 2022-01-11 11:44:21 +10:00
Raphael Coeffic 91a676b64f Fix compiling with DSM2=OFF and MULTIMODULE=OFF 2022-01-10 16:23:32 +01:00
Raphael CoefficandPeter Feerick 9afae09f31 Load radio settings before power on delay is evaluated
Resolves #1366
2022-01-10 11:10:49 +10:00
Peter Feerick 733e272601 Revert "fix: Potential out of bounds access of flightmode name on main screen (#1337)"
This reverts commit 1b6f827b2c.
2022-01-10 11:10:04 +10:00
WilhelmandGitHub 1b6f827b2c fix: Potential out of bounds access of flightmode name on main screen (#1337)
* fixed incorrect use of non-terminated-fixed-string for ctor of std::string

* introduced helper

* removed commented lines
2022-01-10 09:28:47 +10:00
d30c5f46bc feat: Stuck key test for COLORLCD (#1289)
* Stuck key test for COLORLCD #1271

* always start with the first button, no matter what this button is.

* Add LED  error

* Move LED_ERROR_END to ensure runs after dlg close

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-09 12:24:43 +10:00
RistoandGitHub 293b8edd4b Disable VBatBridge after first run (#1388)
Checked with in-circuit-debugger on physical RM TX16S, only after this fix, isVBatBridgeEnabled() is really false.
2022-01-09 10:49:35 +10:00
Peter FeerickandPeter Feerick f8c01c3988 Show warning LED with switch and throttle alerts
Show warning LED for switch, throttle and ALERTS generally
i.e. MULTI failsafe not set, low RTC battery, storage warning
2022-01-08 14:12:26 +10:00
88ade987a7 [nv14] Minor code cleanup (#1364)
* Remove unused DMA defines

* Removed further unused DMA defines

* Removed obsolete unused files.

* Remove reference to removed file

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-08 13:40:10 +10:00
eshifriandGitHub 5c371bd39b [nv14] Improve support for old NV14 Radio Module FW (#1329)
* Improve support for old Radio Module FW

* Change OLD RSSI scaling to 100 - 40 range

* change boolean variable name
2022-01-08 13:37:23 +10:00
Piotr RzeszutandPeter Feerick 5defeeedf4 Allow to power-off the radio when displaying model notes. Fix for #1274 2022-01-08 09:28:40 +10:00
Raphael Coeffic 5be8724787 Fix internal module setup 2022-01-07 09:19:23 +01:00
Raphael CoefficandGitHub d46067fab2 Fix bit mask generation (#1358)
Avoids overflowing when the bit mask should be 32bits long.

Resolves #1351
2022-01-07 09:36:49 +10:00
Kevin KoenigGitHubkkoenig1@optonline.com <kkoenig1@optonline.com>Raphael Coeffic
2e5dbce2cb Fix removal of first mixer line rendering other mixes uneditable (#1163)
* fix 1100

* Delete mix line if it'S empty rather than hot-patching the list

Co-authored-by: kkoenig1@optonline.com <kkoenig1@optonline.com>
Co-authored-by: Raphael Coeffic <raphael.coeffic@frafos.com>
2022-01-04 20:10:24 +10:00
Raphael CoefficandPeter Feerick 10aab3dbef Fix vertically mirrored points
Resolves #1125
2022-01-04 14:21:07 +10:00
Raphael CoefficandPeter Feerick 44cdb4497f Fixed clearing curves
Resolves #1295
2022-01-04 14:21:07 +10:00
Peter FeerickandPeter Feerick a077f2e325 Change version references to 2.6 2022-01-04 09:51:47 +10:00
jfrickmannandPeter Feerick f2a360c9d3 Addressed the requests in issue #1285
`getfieldInfo` can now also take a source index as argument. Plus it was modified to also handle "telem1+" etc.
New functions `getSourceIndex(sourceName)` and `getSourceName(sourceIndex)` were added, which use the names shown on the
screen instead of the special names table used by `getFieldInfo` and `getValue`.
Indices are the same for all of the functions, so `getValue(sourceIndex)` also works with indices from `getSourceIndex`.
New iterator functions `sources([first[, last]])` and `switches([first[, last]])` for getting ranges of sources and switches.
`getPhysicalSwitches` was removed, as I consider the iterator function to be a better solution.
2022-01-04 09:51:47 +10:00
Peter FeerickandGitHub 351643b652 Clear active model internal module settings if radio level setting changed (#1316)
* [colorlcd] Ensure active internalModule is reset if different to radio level setting

* [B&W] Ensure active internalModule is reset if different to radio level setting

* storageDirty only when model setting cleared

* [b&w] Remove reusablebuffer, code re-order

* [colorlcd] More direct moduleType comparision
Consistent with B&W test
2022-01-03 20:55:49 +10:00