6872639ed8
The unconditional `apt-get update` added to satisfy review on #122 was fine on the PR runs (~5s) and then sat for six minutes on the first master push, still in progress when it was cancelled. Nothing was wrong with the tree; apt was just slow. That is a bad trade for this job in particular. Its argument for existing -- and for carrying a push trigger at all -- is that it answers in seconds, and it was made to depend on a network fetch it does not normally need. ubuntu-latest ships PyYAML. So import first and install only if that fails. The dependency is still handled rather than assumed, which was the point of the review finding, but a working runner pays nothing for it. `if` rather than `python3 -c 'import yaml' && exit 0`, because under `bash -e` the latter fails the step on the branch where the import fails -- exactly when the install needs to run. Both paths checked under -e. Also timeout-minutes: 10. The default is six hours, which is how a step that hangs rather than fails occupies a runner and tells nobody. The whole job now completes in three seconds, and selects 0 devices rather than 107 because #122 classified lint.yml as no-build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
67 lines
3.0 KiB
YAML
67 lines
3.0 KiB
YAML
name: lint
|
|
on:
|
|
pull_request:
|
|
branches:
|
|
- master
|
|
# A push trigger, unlike shell-tests in OpenIPC/firmware, which deliberately
|
|
# has none. The reasoning there -- every commit on master was already checked
|
|
# on its pull request -- holds only while master has not moved between the
|
|
# PR's last run and the merge. This job is the one thing standing between a
|
|
# workflow typo and a silently lost nightly, it costs seconds, and #121 cost
|
|
# a full night's release because nothing re-checked the merged result. Cheap
|
|
# enough to not be clever about.
|
|
push:
|
|
branches:
|
|
- master
|
|
paths:
|
|
- '.github/workflows/**'
|
|
- '.github/scripts/lint-workflow-shell.py'
|
|
workflow_dispatch:
|
|
|
|
# Reads the tree and reports; writes nothing. Declared rather than inherited so
|
|
# the job keeps the narrow token whatever the repo or org default becomes.
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
# Same guard the jobs in master.yml carry. A clone pushed to a new repository
|
|
# inherits this file, and on a private mirror every master sync push would
|
|
# otherwise run on that owner's bill. Upstream the first disjunct is true, so
|
|
# the condition is a tautology here.
|
|
workflow-shell:
|
|
name: workflow run blocks parse
|
|
if: >-
|
|
github.repository == 'OpenIPC/builder' ||
|
|
github.event_name == 'workflow_dispatch' ||
|
|
(github.event_name == 'pull_request' && !github.event.repository.private)
|
|
runs-on: ubuntu-latest
|
|
# The work takes about a second. The default is six hours, which is how a
|
|
# step that hangs rather than fails sits there occupying a runner and
|
|
# telling nobody -- see the apt note below.
|
|
timeout-minutes: 10
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
# ubuntu-latest ships PyYAML, so the common path must not touch the
|
|
# network: the first master push after #122 ran an unconditional
|
|
# `apt-get update` here and sat on it for six minutes, on a job whose
|
|
# entire argument for existing is that it answers in seconds. Import
|
|
# first, install only if that fails -- the dependency is still handled
|
|
# rather than assumed, but a working runner pays nothing for it. apt
|
|
# rather than pip in the fallback because 24.04 is PEP 668.
|
|
- name: Ensure PyYAML
|
|
run: |
|
|
if python3 -c 'import yaml' 2>/dev/null; then
|
|
echo "PyYAML already present; nothing to install."
|
|
else
|
|
echo "PyYAML missing from the runner image; installing."
|
|
sudo apt-get update -qq
|
|
sudo apt-get install -y -qq python3-yaml
|
|
fi
|
|
# Checks the checker before trusting it. The ${{ }} substitution it has to
|
|
# do is the kind of thing that breaks by making everything pass, which
|
|
# would look identical to a clean tree.
|
|
- name: Check the linter still catches what it should
|
|
run: python3 .github/scripts/lint-workflow-shell.py --self-test
|
|
- name: Parse every workflow run block
|
|
run: python3 .github/scripts/lint-workflow-shell.py
|