piotr/edgetx-gx12
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

[Companion] Telemetry screen bar range limits were unsigned (but are signed on ARM radios), didn't allow negative values.

Browse Source
This commit is contained in:
Max Paperno
2017-11-25 14:56:49 -05:00
parent b8042c9da1
commit caa9cd3060
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
companion/src/firmwares/opentx/opentxeeprom.cpp
+4 -4
View File
@@ -2583,13 +2583,13 @@ class FrskyScreenField: public DataField {
bars.Append(new SourceField<16>(this, screen.body.bars[i].source, board, version, variant));
else
bars.Append(new SourceField<8>(this, screen.body.bars[i].source, board, version, variant));
bars.Append(new UnsignedField<16>(this, screen.body.bars[i].barMin));
bars.Append(new UnsignedField<16>(this, screen.body.bars[i].barMax));
bars.Append(new SignedField<16>(this, screen.body.bars[i].barMin));
bars.Append(new SignedField<16>(this, screen.body.bars[i].barMax));
}
else {
bars.Append(new TelemetrySourceField<8>(this, screen.body.bars[i].source, board, version));
bars.Append(new UnsignedField<8>(this, screen.body.bars[i].barMin));
bars.Append(new UnsignedField<8>(this, screen.body.bars[i].barMax));
bars.Append(new UnsignedField<8>(this, (unsigned &)screen.body.bars[i].barMin));
bars.Append(new UnsignedField<8>(this, (unsigned &)screen.body.bars[i].barMax));
}
}
companion/src/radiodata.h
+2 -2
View File
@@ -625,8 +625,8 @@ class FrSkyChannelData {
struct FrSkyBarData {
RawSource source;
unsigned int barMin; // minimum for bar display
unsigned int barMax; // ditto for max display (would usually = ratio)
int barMin; // minimum for bar display
int barMax; // ditto for max display (would usually = ratio)
};
struct FrSkyLineData {