piotr/edgetx-gx12
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Prevent word splitting in compilation scripts when handling paths (#1502)

Browse Source 
These invocations will all cause bugs when pwd returns something that
 can be interpreted by bash, the most common case being a folder
 with whitespaces in its name. In other words these can be triggered by
 calling the scripts from any folder that contains whitespaces.

 More info on this specific finding by shellcheck:
 https://github.com/koalaman/shellcheck/wiki/SC2046
This commit is contained in:
Samuel Henrique
2022-01-26 20:58:24 +10:00
committed by GitHub
parent c3c8a2e3f1
commit d09ba3adca
7 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/linux_cpn.yml
+1 -1
View File
@@ -48,7 +48,7 @@ jobs:
shell: bash
run: |
mkdir output && \
tools/build-companion-nightly.sh $(pwd) $(pwd)/output/
tools/build-companion-nightly.sh "$(pwd)" "$(pwd)/output/"
- name: Compose release filename
# https://stackoverflow.com/questions/58033366/how-to-get-current-branch-within-github-actions
.github/workflows/macosx_cpn.yml
+1 -1
View File
@@ -92,7 +92,7 @@ jobs:
shell: bash
run: |
mkdir output && \
tools/build-companion-nightly.sh $(pwd) $(pwd)/output/
tools/build-companion-nightly.sh "$(pwd)" "$(pwd)/output/"
- name: Compose release filename
# https://stackoverflow.com/questions/58033366/how-to-get-current-branch-within-github-actions
.github/workflows/win-cpn-32.yml
+1 -1
View File
@@ -91,7 +91,7 @@ jobs:
run: |
mkdir output && \
CMAKE_PREFIX_PATH=$RUNNER_WORKSPACE/Qt/$QT_VERSION/$MINGW_PATH \
tools/build-companion-nightly-win32.sh $(pwd) $(pwd)/output/
tools/build-companion-nightly-win32.sh "$(pwd)" "$(pwd)/output/"
- name: Compose release filename
# https://stackoverflow.com/questions/58033366/how-to-get-current-branch-within-github-actions
run: echo "artifact_name=edgetx-cpn-win-32-${GITHUB_REF##*/}" >> $GITHUB_ENV
.github/workflows/win_cpn.yml
+1 -1
View File
@@ -94,7 +94,7 @@ jobs:
run: |
mkdir output && \
CMAKE_PREFIX_PATH=$RUNNER_WORKSPACE/Qt/$QT_VERSION/$MINGW_PATH \
tools/build-companion-nightly.sh $(pwd) $(pwd)/output/
tools/build-companion-nightly.sh "$(pwd)" "$(pwd)/output/"
- name: Compose release filename
# https://stackoverflow.com/questions/58033366/how-to-get-current-branch-within-github-actions
tools/build-gh.sh
+1 -1
View File
@@ -46,7 +46,7 @@ if [[ -n ${GCC_ARM} ]] ; then
export PATH=${GCC_ARM}:$PATH
fi
: ${SRCDIR:=$(dirname $(pwd)/"$0")/..}
: ${SRCDIR:=$(dirname "$(pwd)/$0")/..}
: ${BUILD_TYPE:=Release}
: ${COMMON_OPTIONS:="-DCMAKE_BUILD_TYPE=$BUILD_TYPE -DCMAKE_RULE_MESSAGES=OFF -DDISABLE_COMPANION=YES -Wno-dev "}
tools/commit-tests.sh
+1 -1
View File
@@ -46,7 +46,7 @@ if [[ -n ${GCC_ARM} ]] ; then
export PATH=${GCC_ARM}:$PATH
fi
: ${SRCDIR:=$(dirname $(pwd)/"$0")/..}
: ${SRCDIR:=$(dirname "$(pwd)/$0")/..}
: ${BUILD_TYPE:=Debug}
: ${COMMON_OPTIONS:="-DCMAKE_BUILD_TYPE=$BUILD_TYPE -Wno-dev "}
tools/generate-yaml.sh
+1 -1
View File
@@ -10,7 +10,7 @@ if [[ -n ${GCC_ARM} ]] ; then
fi
: ${FLAVOR:="t12;t8;tlite;tpro;tx12;zorro;tx16s;x12s;nv14;x7;x9d;x9dp;x9e;x9lite;x9lites;xlite;xlites"}
: ${SRCDIR:=$(dirname $(pwd)/"$0")/..}
: ${SRCDIR:=$(dirname "$(pwd)/$0")/..}
: ${COMMON_OPTIONS:="-DCMAKE_BUILD_TYPE=$BUILD_TYPE -DCMAKE_RULE_MESSAGES=OFF -DDISABLE_COMPANION=YES -Wno-dev -DYAML_STORAGE=YES "}