Commit Graph
17172 Commits
Author SHA1 Message Date
121a1ffee5 fix: Potential out of bounds access of flightmode name on main screen (#1337)
Take 2, without the Mac Companion breakage...

* fixed incorrect use of non-terminated-fixed-string for ctor of std::string

* introduced helper

* removed commented lines

* removed constexpr since in C++11 std::string ctro isn't still constexpr

Co-authored-by: wimalopaan <wilhelm.wm.meier@googlemail.com>
2022-01-21 19:53:45 +10:00
Raphael CoefficandGitHub 0adb6315c8 Merge pull request #1469 from gagarinlg/dialogbl
force backlight on when displaying full screen dialogs
2022-01-21 07:26:36 +01:00
Raphael Coeffic 83f03a81df Fixed logical switch index check in raw sources
Resolves #1474
2022-01-21 07:05:54 +01:00
RistoandGitHub 60bbe52f63 feat: More analog diagnostics screens on B&W colorlcd (#1421)
* Show true unscaled and unfiltered analogs for diagnose purpose on the analog diagnose screen.
Tested on physical RM TX16S, not yet tested on B/W targets.

* Changed to decimal display also on B/W targets. Tested now with RM Zorro as well.

* 5 fps refresh rate of the raw analog values. Much nicer to look at.

* Time-changing 3 views for color radios: std., filtered raw with deviation, unfiltered raw.

* Corrected deviation view output to not use old values.

* Changed analogs diagnose page to user navigatable TabsGroup with 3 tabs.

* Added fourth analog diagnose tab to show minimum and maximum values and the range (difference between min and max).
Left touch screen and IMU output tests only on first page (should also move in the future to their respective dedicated pages).

* Use Std. JitterAlpha filtering for Deviation screen to minimize delay, omit filtering for FlySky digital hall gimbals - not necessary, the signal is stable enough.

* 2 analog diagnose pages for 128x64 B/W radios: calibrated analogs and raw values with display output limited to 5 frames-per-second due to visibility reasons.

* Added 2 analogs diagnose pages also for 212x64 display B/W radios.
I was only able to simulate it, not tested on real hardware.

* Support also radios that do not have PageUp/PageDn keys, but only Page key (e.g. X7).

* Better key handling and improved style thx to @pfeerick
2022-01-21 14:45:56 +10:00
1d7b04d679 [nv14] Make Ghost menu work with joystick trims (#1416)
* Update radio_ghost_module_config.cpp

* Update board.h

* Update keys_driver.cpp

* Auto-formatting

* Add functions simply so gtests compiles

* Update board.h

define TRIMS_EMULATE_BUTTONS to avoid HW dependent defines in other code

* Update radio_ghost_module_config.cpp

Use TRIMS_EMULATE_BUTTONS rather than PCBNV14

* `simu` code behind build flag also

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-21 14:42:13 +10:00
91d3c88421 [cleanup] Remove unused READ_FILE_BY_LINE code from colorlcd (#1456)
* remove READ_FILE_BY_LINE from colorlcd

* Whole file autoformat + more unused code removal

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-21 13:42:55 +10:00
Peter FeerickandGitHub 294e250f08 [ghactions] Cache Qt dependencies for building Windows Companion (#1431)
* [action] Cache QT install files
* Take into account two windows builds

Note: If for any reason the cache is corrupted, the cache key will need to be updated to make it re-build.
2022-01-21 13:10:12 +10:00
Raphael CoefficandGitHub 0ee144dd25 Remove useless DEBUG_TASKS (not supported on FreeRTOS) (#1448) 2022-01-21 12:59:45 +10:00
gagarinlg 9fea53702a force touch screen to be on in full screen dialogs
reset backlight timeout when changing backlight settings
2022-01-20 12:40:58 +01:00
gagarinlg ea29a68f23 force backlight on when displaying full screen dialogs
fixes #1428
2022-01-18 14:06:42 +01:00
Peter FeerickandGitHub 7da7261e7b Various Companion fixes (#1449)
- Fix (de-)serializing enable param for backlight custom function
- Fix OFF backlight
- Fix power ON/OFF delay
- Fix flight mode trim disabled
- Fix trim switch index
- Fix deserializing SLIDER[1,2]
- Fix shift for logical switches in raw sources
2022-01-18 11:13:11 +10:00
Risto adca4f0a3b Fixed Zorro battery voltage sensing
New Zorro revision uses internally 3.3V VREG and requires this change to properly sense the battery voltage. Tested on latest revision of physical Zorro.
2022-01-17 16:06:26 +01:00
Peter FeerickandGitHub dcbdde2b74 Fix warning: "EVENT_BUFFER_SIZE" redefined 2022-01-17 11:34:09 +10:00
piotrvaandGitHub e47caddeb0 fix: Force translation.py script encoding to utf-8 (#1424) 2022-01-17 11:24:53 +10:00
stefan73andGitHub 7161c83d9c [nv14] Make Outputs widget work with two column layouts (#1454)
Changed code to allow one column display of outputs already with a width of 100. This fixes the initally reported problem

Reason: On the Nirvana the screen width is 320 pixels. Thus the widget width is less than 150 pixels, if you select a two column out layout.
The rendering of the outputs looks good with a width of 100px, so there is no need for the "150" - we can start displaying from 100. Should make no difference to the radios with width 480px.
2022-01-17 11:24:20 +10:00
Jesper FrickmannandGitHub 0069bcc52f Increased Lua buffer size for standalone and telemetry scripts (#1442) 2022-01-17 10:54:08 +10:00
Jesper FrickmannandGitHub c45b3d7114 Fix: [lua] Do not ever convert name to a number with getFieldInfo(name) (#1423)
Fix for Issue #1346
2022-01-17 10:20:40 +10:00
Peter FeerickandGitHub 1fe4936e7e Move discord, facebook, discussions links up 2022-01-17 09:11:50 +10:00
Raphael Coeffic cdd933d6e1 Fix shift for logical switches in raw sources
Resolves #1439
2022-01-16 11:46:55 +01:00
Raphael Coeffic 064a71f7f2 Fix deserializing SLIDER[1,2]
Resolves #1419
2022-01-16 11:17:50 +01:00
Raphael Coeffic b8553928ed Fix trim switch index 2022-01-16 10:49:23 +01:00
Raphael Coeffic 8071807584 Fix flight mode trim disabled 2022-01-16 10:38:52 +01:00
Raphael Coeffic 82aa94848e Fix power ON/OFF delay 2022-01-16 10:28:04 +01:00
Raphael Coeffic e986af77eb Fix OFF backlight
Resolves #1447
2022-01-16 10:20:49 +01:00
Raphael Coeffic 5cb0ca469f Fix (de-)serializing enable param for backlight custom function
Resolves #1446
Resolves #1447
2022-01-16 10:13:57 +01:00
Raphael CoefficandGitHub 8150b00823 fix: [companion] Throttle trace source conversion error (#1401)
Accounts now for EX3 & EX4

Resolves #1398
2022-01-13 11:51:37 +10:00
PaddyandGitHub db392408b9 [companion] Show commit hash and link to github issues in About dialog (#1415)
* Include Git Commit Number into about popup and refferencing to the github commit via link

* Add Link to Create New Issue on Github

* Add Link to Create New Issue on Github
2022-01-12 11:32:06 +10:00
7a628d4c15 fix: Companion read/write of failsafe settings, how displayed on radio (#1399)
* Fix failsafe settings

Resolve #1393

* trigger save if failsafe numbers changed + cleanup

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-11 23:09:55 +10:00
Raphael CoefficandGitHub 71b0e72dd0 Remove calibration check when asserting availability of 6-pos switch positions (#1368)
Thus allowing it to show on radio when calibration is invalid
2022-01-11 22:46:41 +10:00
Jesper FrickmannandGitHub cc316e5a2c fix: Wrong x-coordinate for Lua touchState during sliding on mainviews other than the first screen (#1409)
Fix for issue #1348 as discussed on https://github.com/EdgeTX/libopenui/pull/49
2022-01-11 22:44:54 +10:00
Malte LangermannandGitHub 37ee8a68f8 fix: Force a valid min "backlight on" setting on color lcd radios (#1386)
* always have aat least a 5s backlight timeout and some backlight enabled when backlightshould be on on color lcd radios

* for backlight timeout to be at least 5s on color lcd radios under all circumstances

* fix indentation

* the backlight value is inverted on color lcd radios, so the calculation was wrong

* fix typos
2022-01-11 22:44:13 +10:00
piotrvaandGitHub 192ca87afb fix: rotary encoder movement should not close throttle warning (#1408) 2022-01-11 11:44:21 +10:00
RistoandGitHub e97a3b15a5 Add asciitree and jinja2 to the list of installed Python packages 2022-01-10 20:04:07 +01:00
Raphael Coeffic 91a676b64f Fix compiling with DSM2=OFF and MULTIMODULE=OFF 2022-01-10 16:23:32 +01:00
Peter FeerickandPeter Feerick dc8f86700c [companion] fix: only write yaml to radio, not bin 2022-01-10 21:53:29 +10:00
Raphael Coeffic 1c8639baea Fix raw switch index checks (#1403)
Resolves #1403
2022-01-10 12:51:41 +01:00
Raphael Coeffic 22762e0a16 [companion] Properly write String zone option values 2022-01-10 08:32:49 +01:00
Neil HorneandGitHub fcf8fbdfff Companion hardware internal module continued (#1342)
* Add ability to undo hardware internal module change

* Add internal module protocol check on model edit

* Event driven check and update of all models

* Fix model edit dialog searches

* Add OFF to list of internal modules

* Fix internal module protocol list issue #1382
2022-01-10 11:13:21 +10:00
elecpowerandPeter Feerick b41cb2a75a Re-enable custom screens with new themes 2022-01-10 11:11:31 +10:00
Raphael CoefficandPeter Feerick 9afae09f31 Load radio settings before power on delay is evaluated
Resolves #1366
2022-01-10 11:10:49 +10:00
Peter Feerick 733e272601 Revert "fix: Potential out of bounds access of flightmode name on main screen (#1337)"
This reverts commit 1b6f827b2c.
2022-01-10 11:10:04 +10:00
Peter FeerickandGitHub 925043f4b3 fix: [companion] Show cause of error if unable to read from radio, scan MODELS dir if models.yml missing
Fallback to model file scanning if models.yml cannot be read
2022-01-10 10:13:40 +10:00
WilhelmandGitHub 1b6f827b2c fix: Potential out of bounds access of flightmode name on main screen (#1337)
* fixed incorrect use of non-terminated-fixed-string for ctor of std::string

* introduced helper

* removed commented lines
2022-01-10 09:28:47 +10:00
Raphael Coeffic 49e3e00b87 Fix models.yml for empty categories or unsorted models 2022-01-09 16:42:49 +01:00
Raphael Coeffic 67816e0d65 Fix current model index 2022-01-09 16:09:29 +01:00
Raphael Coeffic ff1e5cedc5 Add default category on-the-fly 2022-01-09 10:07:27 +01:00
Raphael Coeffic ef7a5d34c7 Improved errors displayed with corrupted YAML files
When reading directly from the radio's SD card.
2022-01-09 09:10:37 +01:00
d30c5f46bc feat: Stuck key test for COLORLCD (#1289)
* Stuck key test for COLORLCD #1271

* always start with the first button, no matter what this button is.

* Add LED  error

* Move LED_ERROR_END to ensure runs after dlg close

Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
2022-01-09 12:24:43 +10:00
RistoandGitHub 293b8edd4b Disable VBatBridge after first run (#1388)
Checked with in-circuit-debugger on physical RM TX16S, only after this fix, isVBatBridgeEnabled() is really false.
2022-01-09 10:49:35 +10:00
Raphael Coeffic 748435fa8f Various small fixes 2022-01-08 17:10:25 +01:00