* Reduce size of the YamlNode structure in FLASH storage.
Fix compiler warning.
* Further reduction of FLASH used by YamlNode structures.
* Reduce size of sensor definition arrays and audio tone volumes array.
* SF Audio amplifier mute port to 2.10
* added missing definition STR_SF_DISABLE_AUDIO_AMP
* exclude radios not able to switch audio amp off
* radio/src/storage/yaml/yaml_datastructs_128x64.cpp needs to distinguish between radios with or without switchable audio amps. Expample Zorro vs X9lites
* updated companion and radio language PL
* - added Companion and radio language SE
- removed type unfinished for translated languages
* added radio and companion language JP
* - reverted change to 128x64 yaml_datastructs.h
- moved exclusion of SF DISABLE_AUDIO_AMP based on hw capabilities to UI level
* confused FUNC_ with FUNCTION_
* confused FUNCTION_* with FUNC_*
* Fix handling of blank lines in YAML files.
* Added some basic EOL / blank line unit tests
---------
Co-authored-by: raphaelcoeffic <raphael.coeffic@frafos.com>
* chores(flysky): separate AFHDS2A and AFHDS3 into 2 different module type
This should allow to remove some of the hacks added earlier.
* chore: Add some EL18 CI bits
* fix(afhds): cmake defs
* fix(ci): add el18 to commit-tests.sh
* chore(cpn): separate AFHDS2A and AFHDS3
* chore(cpn): remove binary import of afhds and legacy fxFreq field for afhds3
* fix(cpn): limit available internal afhds protocols to those supported by hardware
* chore(cpn): update Flysky int module test
* fix(cpn): compile error
* fix(cpn): afhds2a max channels
* fix: TR_MODULE_PROTOCOLS
* enh(cpn): more support for afhds2a and 3
* fix(cpn): rebase compile error
* fix(cpn): bit indexes
* fix(cpn): emi toString
* fix(cpn): limit available internal afhds protocols to those supported by hardware
* enh(cpn): add support for Flysky EL18
* fix(cpn): available protocols
* fix(cpn): rebase moduledata
* chore(cpn): add module fields to model print
* Separate AFHDS2A and AFHDS3 UI settings.
* Fix AFHDS3 conversion from old subtype value.
Fix 'Channel Range' layout on portrait LCD.
* Fix name.
---------
Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
Co-authored-by: elecpower <neilh713@tpg.com.au>
Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
* initial version of clickable checklist
* do not display checkboxes for empty lines if checklist is shorter than screen size
* remove checklist exit after completing it
cannot exit menu from menuTextView as level above there is while loop that cannot be stopped from thic place in code
* menu entry to enable and disable interactive checklist
* only when complete interactive checklist is closed
* config updated & not display checkboxes when entered from "View Notes"
* add setup entry for colorlcd
* do not make interactive checkist when loaded from menu
* fix datastruct size after merge
* Companion support for interactive checklist
* mark checklist lines as non-checkable with '=' for B&W radios
* Process only items visible on screen
This is also crucial when it comes to analyse non-checkable items on a checklist, as in this way there is no need to load non-visible items from SD-card
* WIP fix merge problems
* update yaml datastructs
* restore most functionalities for interactive check lists on color LCD radios
currently no automatic line wrapping and you can always exit the checklist, even when it is not fully done
* finalise interactive checklists for color LCD
* fix: rebase/merge issues
* fix: model setup checklist section
* fix: fix 212 model setup
* Re-work of the some of the color lcd checklist code (#3787)
* Move checklist logic to sub-class.
Show model name instead of file name in title, show 'Preflight checks' in title2 for checklist.
Handle long line wrapping of text.
Don't indent lines without checkbox.
Add 'RTN' button when done.
* Code cleanup.
* Simplify code by storing a list of checkboxes instead of scanning LVGL object hierarchy.
* Indent checkboxes to make touch activation easier.
Keep 'RTN' button visible so last checkbox is further from bottom of screen (for touch activation).
'RTN' button is disabled until checklist complete.
* Add checkbox class constructor for preflight checks.
* Fix checkbox size.
---------
Co-authored-by: Piotr Rzeszut <piotrrze@gmail.com>
Co-authored-by: 3djc <lesitewebdejc@hotmail.com>
Co-authored-by: philmoz <philmoz@users.noreply.github.com>
Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
* feature request #1635
- added MIN (-MAX -> -1024) as source
* fix rebase
* fix rebase
* change to use language strings for MIN/MAX instead of instance
updated CN and TX language file for MIN use -RESX for MIN instead of magi number code cleanup
* updated test sources
* updated JP language
* JP language: changed translation text
* updated HE language translations
* fix: YAML timer handling
* chore: improve YAML set timer handling
* chore: improve timer handling
* feat: only offer defined timer for set and reset functions
* feat: only offer defined timer for set and reset functions (bw)
* chore: cosmetics
* Refactor object creation logic.
Remove unused LVGL features.
* Remove unused files.
Fix height for widgets.
* Rename 'OpenTxTheme' class to 'EdgeTxTheme'.
Cleanup commented out code.
Cleanup unused code from 'etx_lv_theme.cpp'.
* More cleanup.
* Move more style code to etx_lv_theme.cpp
* Update license
* Make default button height match other controls.
* Fix curve edit layout.
* Fix layouts.
* FormWindow and FormGroup provided identical functionality - rename FormGroup to FormWindow and remove duplicate.
* Simplify menu icon handling.
Remove unused 'flysky.cpp' file.
* Fix window size change.
* Simplify page header code.
Fix statistics view page.
* Remove unused file.
Replace redundant 'Subtitle' class with a macro.
Fix compiler warnings.
* Fix compiler warning in LvglWrapper.cpp.
Remove unused code in static.h.
Simplify about page.
* Rename ICON_OPENTX to ICON_EDGETX.
* Fix github build error.
* Fix github build error (attempt 2).
* Move ButtonMatrix styling to etx_lv_theme.cpp.
* Scroll bar consistency.
* Use styles for ButtonMatrix text color.
* Use 'active' color for selected USB advanced setup buttons. Move error message to bottom of page.
* Create style for popup window title bar.
Simplify advanced USB setup code.
Remove unused libopenui/carousel.* files.
* Add style for modal popup content.
* Remove unused BUTTON_BACKGROUND flag.
* Replace GridLayout with FormWindow. Remove unused gridlayout.h file.
* Fix rebase.
* Merge ChoiceEx class into Choice class code.
Remove unused CurveKeyboard.
* Use LVGL bar for progress indicator.
Update only style colors when theme changes (don't recreate all style settings).
* Move ProgressDialog class to dlalog.h/dialog.cpp files.
* Simplify trim and slider code in main view.
Simplify the hardware inputs code.
Fix dialog size.
Remove unused code in layout factory.
* Cleanup unused code.
* Add style for FormWindow class.
Merge BaseNumberEdit class into NumberEdit class and remove BaseNumberEdit.
Remove more unused files.
Cleanup libopenui_config.h files.
* Re-organise libopenui include files to fix build error.
* Fix build error.
* Add missed styles to etx_lv_theme.cpp.
Delete commented out #includes.
More cleaning up of libopenui_xxx.h files and dependencies.
Re-enable LVGL CHECKBOX feature.
* Merge libopenui_helpers.h into opentx_helpers.h file.
* Fix firmware build.
* Use object constructors for LVGL object creation as suggested by gagarinlg.
Add style for number edit text alignment.
Fix background color for focussed control.
* Move color related stuff from libopenui_defines.h to colors.h.
Remove need for libopenui_depends.h file.
* Merge libopenui_types.h content into opentx_types.h file.
* Rename CheckBox class to ToggleSwitch.
* Restore code to update flight mode text color when theme changes.
* Cleanup some more unused code.
* Remove redundant theme.h file.
* Fix rebase.
* Fix button matrix style.
* Fix rebase
* Fix rebase
* Ensure correct initialisation of Choice object.
* Fix rebase.
* Make the slider control bigger to make touch activation easier.
* Fix build error.
* Fix slider logic and cleanup code.
* Use ACTIVE theme color for inputs, mixes, LS, GV and SF.
* Improved border width consistency and focussed state consistency.
* Remove duplicate copy of the default theme colors.
* Enable startup splash screen duration for color LCD radios.
Add option to disable startup sound.
Add Companion support for changes.
* Add translation string for Hebrew language file.
* Fix rebase.
* chore: Add T20
* Update translations.
* Update translations.
* Update translations.
* Update translations.
* Right justify radio setup controls.
* Use longer translations for all radios.
* Enable splash screen timeout for NV14/EL18.
* Suspend watchdog timer to prevent EM if long splash display time selected.
* Simplify SPLASH_TIMEOUT code.
* Use WDG_RESET instead of watchdogSuspend.
---------
Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
* Support all current timezones.
* Fix function name and calculation for timezone offset.
* Allow setting any time offset value from -12 to +14 in 15 minutes increments.
* Alternate timezone editor in Companion (from elecpower).
* Fix compiler warning.
* chore: Add the T20
Add "hardware_defs" target to dump hardware defines from hal.h per target
Fixed hal.h definitions for switches & ADC inputs
Tools to generate hardware definitions from current hal.h
generator: add support for EXTx and analog switches
WiP
Add generated header to hardware_defs target
Add support for ADC input direction and index per GPIO port
Incredible: it compiles
Removed StdPeriph ADC driver
Works on QX7
Works on TX16S (VBat missing)
Switch driver using generated switches for stm32 targets
Switch driver with generated switches for simu
Use switch names from switch driver
Fixed single conversion handling
Fixed horus VBat reading
Added switch name
Fix warnings about bitfield offsets and GCC 4.4
This is caused by bitfields that cross type boundaries. In this particular case, it happens as the bitfield is not defined the same in `rtc_backup.cpp`.
Switches has already been moved to generic driver
Jitter measurement for each sample, not just for oversampled values
Moved periph clock init to the ADC driver
ADC & GPIOs.
Add switchInit() to init pins
Fix NV14 CMake
Fix taranis target
Fix NV14 (again)
Model audio files: use new interface for switch index
Fix X9-lite
Fix simu headers
Fix getSwitchName()
Add support for ADC switches
Fix switch warning YAML
Test only switches which are defined
Conversions tests for QX7 only on QX7
Fix X12S
Fix function switch names
Enable ADC periph clock before initialising channels
NV14: offset inputs for the sticks & fix switches
WiP: get rid of VSRCRAW and some more
Simu shall use normal ADC driver
fix x7
fix nv14
Fix 9x nav
fix 212x64
fix xlite
fix x9e
fix simu lib
fix unit tests
fix x7 tests
PWM stick values should be written directly into adcValues
... just like FlySky sticks.
fix x12s
fix nv14
Add some support for SPI ADC (only unit tests)
Remove `jq` usage
fix generate_yaml.py for newer libclang
fix pot config
fix stick names
Some YAML generator improvements
Max 16 Pots on COLORLCD
Fix some source names
Use 10 bits for switches to prevent overflow
Removed horus constants for switches & ADC inputs
Fix unit tests
Fix curve edit
Fix libsimulator
Fix function switches (tpro)
Refine ADC & analog API
Moved hardware definitions scripts and templates into own dir
cleanup API refine
Fix unit tests
Mixer: apply calibration only on required inputs
Place ADC switches after all other ADC inputs
Fix X12S
Remove useless TR_POTS_VSRCRAW, TR_SW_VSRCRAW, and TR_VSRCRAW
Cleanup redundant generated YAML parsers
Fixes Boxer rebase
Add boxer to generate-hw-defs.sh
Obsolete LUA exports
Add boxer ADC_DIRECTION
Split generate_hw_defs.py into multiple files
Some cleanup (+ LUA switches)
Fix AXIS definitions
Fixed translation strings declarations
Some rebase fixes
Remove some useless StdPeriph drivers
fix: set pin mode to reset state on usart deinit
fix: use canonical names for calibration data
fix: ADC driver does not care about unconfigured inputs
fix X12S ADC
Add support for ADC conversion chaining
Better X12S ADC implem
Moved X12S ADC driver to HAL/LL
Improve ADC driver separation
Fixed taranis & nv14
Moved PWM gimbals to HAL/LL
Removed useless TR_EXTRA_VSRCRAW
Fixed include guards
Small fixes
Renamed control inputs
Moved internal and external module pulse driver def to boards
Move more things to the generic_stm32 board
Remove STR_VMIXTRIMS
Added analog labels
Generate main control names
Misuse labels / short labels for main controls
Backward compatibility: sliders and legacy names
New keys driver
Let's get rid of StdPeriph headers in simu
Add jinja2 to CI workflows
Use `grep` instead of `sed`
chore: add python jinja2 oto msys setup script
Removed more static definitions and use dynamic ones instead
Fixes X9E
Fix x7 nav too
212 switch display
Fix default sliders
Removed NUM_STICKS
212 switch display working nicely
Surface radio 'stick' replacements
fix: switch, trim & rotary pin init
Remove old key drivers
Removed VKEYS
Removed ETX_FOURCC
Fixed SURFACE_NAME
Removed TR_VSWITCHES & TR_TRIMS_SWITCHES
Fix xpot switches
Store calibrated analogs in physical order
Use getSourceString in drawSource
Implement missing YAML read/write
Fix isSourceAvailableInInputs()
Fix isSourceAvailable()
Some surface fixes
Fix CLI debug
Ported colour UI of analog diagnostics to new ADC API
Small fixes
Better input mapping
Minor tpro fixes
Fix trims available
Remove TX mode choice on surface radio
Rename surface controls
Channel order alignement
Fix throttle warning
Fix checkTrims()
Fix pot config casting issue
Fix IS_SWITCH_FS()
Fixed input mapping
Fix fswitch auto-switch
Fixed storing / reading function switches in YAML
Fix enableVBatBridge() / disableVBatBridge()
Fix interesting mode conversion
Fix sources issues
Fix special funnction list
Proper function switch handling
128 GUI improvements
Fix compilation
Boxer cosmetics
128 hardware screen cosmetic
Fix TX12 switches
More switches fixes
Simplify CPU type handling
Fix flash size
Fixed page-up / page-down in libopenui
* fixes#2552
- remove edit option rssiSource
- reset rssiOption to default (none) if carried over from OpenTX conversion
* deleted rssiSource functional code Companion, simulator and radio
* forgot one commented line
* Refresh UI module settings when AHFDS3 config is updated.
* Fix scroll order for module options when 'FlySky' module type selected.
Fix simulator crash issues related to FlySky module.
* Fixed UI refresh problems in UI widget ordering fix.
* Refresh config when receiver is connected.
* Disable change of bind time options when receiver is connected.
* Rename methods to better distinguish between buffer fill or actual send.
* Clean and tidy up AFHDS3 state flow.
* Implemented settings sync upon setting changes.
* Added RF power settings for IRM301/FRM303.
* Added RF power sensors for FRM303.
* Fixed config not saved and only FRM303 supports RF power settings.
* Fixed RF power command error.
* Fixed a crash for IRM301.
* Always check if port exists and return nullptr for driver.
* fix: Make Companion preserve settings *as is*
---------
Co-authored-by: Phil Mitchell <phil.a.mitchell@gmail.com>
Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
* Add options to disable radio and model menu tabs.
- Update radio and model data structs
- UI for color LCD radios
- Convert existing 'noGlobalFunctions' property.
- Language strings.
* Make 'theme' control specific to color LCD radios.
* Add B&W radio UI.
* Simplify code, reduce compiled code size.
Fix page count display on model select tab.
Fix GVARS for 212x64 radios.
* Collapse timer sections if timer is off.
* Remove 'Use global functions' checkbox from B&W model setup.
* Make preflight checks, throttle and view options sections expand & collapse (default collapsed).
* Fix build.
* Add view options to companion data classes, save and load values in YAML files.
Fix scrolling for radio setup view options.
* Add Companion UI for view option settings.
* Remove 'Mixes' from list of tabs that can be hidden.
* Updated Companion UI from elecpower.
* Use view options flags to enable/disable functionality:
- skip heli mixer logic if heli not enabled
- Remove heli, gvars and telemetry options from source selection if not enabled
* Remove 'flight mode', 'curve' and 'global variable' settings from input & mix editors if option disabled.
* Rename 'View Options' to 'Enabled Features'.
Put GVAR option under Flight Mode and indent text.
Make relationship between FM and GV more obvious.
* Remove global variable option dependency on flight modes.
Hide FM1-FM8 in global variables if flight modes hidden.
* Hide 'Custom Mixer Scripts' in source selection menu popup if disabled.
* Add translation strings for Hebrew language file.
* Fix typo. Add comment for double call to setCurrentTab.
* - Concentrated Multi protocol definitions into a consistent single source. Actually two .h files, one for the protocol list and names, the other for subtypes and capababilites, see comments in .h files as to why
- updated available protocols reflecting 1.3.3.20 (15+ protocols)
- fixed Companion always showing f/s and channel map options in model setup disregarding the protocol capability
* Following @pfeerick's review: changed heaeders and typos
fixed Ubuntu runtime error on assert
fixed change of Multi protocol not triggering writing yaml file
* corrected copy/paste error
* fixed FrSky index juggling
* Updated Multiprotocol database to current MPM project status (ref. MPM Multiprotos.ino)
- changed protocol name FX816 to FX
- added Flysky AFHDS2A options PPM and PPWM SBUS 16ch subtypes "PWM,SB16" and "PPM,SB16
- added V761 option to select TOPRC
- added FX options "816" and "620"
- added FRSKYR9 option "-- 8ch"
* MPM protocol scan excludes some protocols which are not meant to be selected. For Companion and Simualtor (and for radios if there is no MPM connected) this was handled in different places with outdated information. Harmonized and centralized the handling of non-selectabale protocols into the single source for all companion, Simulator and all gui types.
* More cleanup:
- changed some MPM protocol names to the ones the MPM delivers with MPM protocol scan to harmonize names between CPN/Simulator/radio
- added XN2927DUMP and MOULDKG to the list of excluded MPM protocols just like the MPM does with MPM protocol scan
- added new option value limits and moved definitions to single source
- adapted CPN and radio to use common definitions of option values for all GUI types
- moved distributed MPM (as far as possible) to one coherent place under a single #if defined (MULTIMODULE)
- fixed option value not reset at change of protocol
- some editorial stuff
Note: There is still some work to be done on CPN GUI option values. DSM2 servo rates are hard coded, BAYANG telemetry options are only shown by index and not by text as in radio code, AFHDS2A servo update rate is shown as index too which is to no use for users.
I'll try to fix all this in the next session, but request to get rid of BAYANG telemetry options translations. It is much easier to define a common string list by using untranslated.h
* rebase due to fr.h
* resolve merge conflict with main fr.h
* more cleanup:
- deleted multiple definition of MM_RF_CUSTOM_SELECTED in favor of single source define
- bw radios: change to only allow defined protocols rather than a fixed 127 protocols
* Changes:
- magic sentinel number 0xfe as define
- add 10 NN protocol entries for future use of new MPM protocols not yet defined in ETX (still recommend timely ETX maintenance update if MPM releases new firmware)
* Changes by @elecpower:
- align field labels to radio
- change servo update frequency from combo box to spin box with edit only via up/down arrows to stop invalid values being entered via keyboard. Remove frequency list used to populate combo box as only used by Companion.
- add validation to module yaml decode checking for unsupported multi protocols and/or multi protocol sub types and if unsupported set module to OFF just to be safe.
* Changes:
- radio: added validation to module yaml decode checking for unsupported multi protocols and/or multi protocol sub types and if unsupported set module to OFF just to be safe.
* CPN: use sentinel define
* cpn: Sort multi protocols list (courtesy @elecpower)
* fixes#3480
changes:
- moved FrSky subtype defines to MultiProtoDefs.h
- updated bind_button_driver.cpp
* missed replacing one instance of setMultiProtocol()
* changes:
- editorial change
- added multi option to OMP protocol (ref #2713)
* rather go for STR_MULTI_RFTUNE because MPM manual talks about RF tune
* made XN297_DUMP selectable (available with MPM debug fw only)
* corrected merge mistakes
* introducing external MLink module telemetry as module PPM subtype
* implemented fix for sensor discovery display not showing all detected sensors (is in separate PR too)
implemented PPM subtypes in Companion
* add PPM subtype to model printer
finalize subtypes for PPM in Companion
* added logic to try to use HW UART with inverters turned off first (e.g. NV14), then, if not successfull use soft serial inverted (== uninverted data due to HW inverters on PCB)
changed start bit detection IRQ priority from 5 to the previous 0 (also in separate PR)
* extended telemetry timeout to 2s due to slow Mlink RSSI update rate
* changed the "NOTLM" sub-type texts to:
- "No Telem" for 128x64 (this is the max numbers of characters it can take)
- "No Telemetry" everything else including Companion
* Companion:
- lower case 1st charachter on PpmSubTypeStrings to ppmSubTypeStrings
- added telemetry hooks for ppmSubTypeStrings stringx
* simplified serial port initialization for MLink telemetry
* editorial change: corrected obsolete comment
* Add 'Show Instance ID' button to telemetry page to show/hide sensor instance number (default is hidden).
Fix issues with page refresh when all sensors deleted.
Select closest sensor when a single sensor is deleted.
On change, only refresh the sensor list instead of the whole page.
The 'showInstanceIds' property is saved to the model file.
Update Companion to save/load 'showInstanceIds' in model YAML file. Add checkbox to telemetry edit page.
* Update all radio specific files.
* Keep focus on 'Discover/Stop' button when searching for new sensors.
Start sensor ID index at 1 to match B&W radios.
Keep focus on changed parameter when editing sensor, don't rebuild entire parameter list on change.
* Display actual 'instance' ID instead of 'instance' + 1.
* Fix incorrect ID when reloading simulator data.
* Fix incorrect ID when reloading simulator data on B&W radios.
* Add layout 4+2B right side 3QRT+1QRT
* Fix Layout 4+2B LayoutId, length max 9 char
* Maybe this will work?
---------
Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
* Add support for the '1x' repeat option for 'Play Script' special functions.
* Add Companion and B&W radio support.
* Fix B&W radio logic and layout.
* Add translation hooks.
* Show the 'Press any key to skip' message on alerts that currently have no message.
* Show action button on storage format warning also
---------
Co-authored-by: Peter Feerick <peter.feerick@gmail.com>
* Change ThemeFile class to use generic YAML parser instead of hard wired code.
Fix handling of empty input lines in YAML parser.
Increase size of YAML parser variables to handle theme 'info' property length.
* Update comment.
* Fix error.
* Proper fix for blank lines in YAML file.
* Fix YAML blank line handling (attempt 3).
* Ensure theme YAML file is backward compatible.
* Store selected theme in radio settings instead of selectedtheme.txt file.
On start, if radio settings theme is empty, try and load from selectedtheme.txt file.
In Companion, save/load the selected theme in the radio settings YAML file; but no UI to select theme.
* Update selected theme name in radio.yml if the theme name was edited.
* Only save 'selectedTheme' in Companion on color LCD radios.
