open.20.fsguruh@xoxy.net
2b12eabcb9
brief description: - SLOW should be correct now, please test a lot - further small flash saving of 40 bytes - higher THROTTLE accuracy not for stock but all other boards as proposed by bsongis detailed: while first fix claimed to be correct, it wasn't because the original version was not wrong. I was confused because the simulator in companion9x simulates nearly half of real speed. Is this intended? You will see it also on the seconds measured. The original code was just a lot confusing and in a silly position. That's why I need your opinion! I moved now the speed calculation to the last position in mixing calculation. This causes the slow directly operate on the output values. This saves additional 40 bytes flash code. The original position was after trim, offset, curve, but before weight and differential. The before weight position makes this confusing weight correction necessary. A simple position change would avoid the weight division. My opinion for the best position for speed calculation is on the output, because whatever curve, diff, etc. calculation you had before the output will have the defined speed. However somebody want the output to change speed according a curve? This wasn't possible with the original implementation, but a change could make this be easily possible. As far as I know the implementation of the expensive Graupner remote controls do it that way. So speed is something like a controlled stickmovement speed and the rest is calculated on the base of it. I asked a lot, and most people do not really care if it is calculated on input or output. An advantage on the output is the easier calculation, which results in higher mixer speed and flash code savings. What's your opinion? Where is the best place for speed calculation? a) on the input b) somewhere in the middle (please specify) c) at the output