piotr/edgetx-gx12
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

chore(color): remove redundant calls to getValue() in Value widget (#7652)

Browse Source
This commit is contained in:
philmoz
2026-08-14 14:20:00 +10:00
committed by GitHub
parent 2cc978470e
commit a7e97d1485
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
radio/src/gui/colorlcd/widgets/value.cpp
+5 -6
View File
@@ -135,13 +135,12 @@ class ValueWidget : public Widget
// Set value text
if (field == MIXSRC_TX_VOLTAGE) {
valueTxt =
getSourceCustomValueString(field, getValue(field), valueFlags);
getSourceCustomValueString(field, newValue, valueFlags);
valueTxt += STR_V;
} else if (field == MIXSRC_TX_TIME) {
int32_t tme = getValue(MIXSRC_TX_TIME);
TimerOptions timerOptions;
timerOptions.options = SHOW_TIME;
valueTxt = getTimerString(tme, timerOptions);
valueTxt = getTimerString(newValue, timerOptions);
} else if (field >= MIXSRC_FIRST_TIMER && field <= MIXSRC_LAST_TIMER) {
TimerState& timerState = timersStates[field - MIXSRC_FIRST_TIMER];
TimerOptions timerOptions;
@@ -151,16 +150,16 @@ class ValueWidget : public Widget
std::string getSensorCustomValue(uint8_t sensor, int32_t value,
LcdFlags flags);
valueTxt = getSensorCustomValue((field - MIXSRC_FIRST_TELEM) / 3,
getValue(field), valueFlags);
newValue, valueFlags);
#if defined(LUA_INPUTS)
}
else if (field >= MIXSRC_FIRST_LUA && field <= MIXSRC_LAST_LUA) {
valueTxt =
getSourceCustomValueString(field, calcRESXto1000(getValue(field)), valueFlags | PREC1);
getSourceCustomValueString(field, calcRESXto1000(newValue), valueFlags | PREC1);
#endif
} else {
valueTxt =
getSourceCustomValueString(field, getValue(field), valueFlags);
getSourceCustomValueString(field, newValue, valueFlags);
}
lv_label_set_text(value, valueTxt.c_str());